From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out.smtp-auth.no-ip.com (smtp-auth.no-ip.com [8.23.224.61]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 90AB877FF5 for ; Thu, 23 Jun 2016 04:21:13 -0700 (PDT) X-No-IP: carhart.net@noip-smtp X-Report-Spam-To: abuse@no-ip.com Received: from carhart.net (unknown [99.52.200.227]) (Authenticated sender: carhart.net@noip-smtp) by smtp-auth.no-ip.com (Postfix) with ESMTPA id DBC6040092F for ; Thu, 23 Jun 2016 04:22:42 -0700 (PDT) Received: from carhart.net (localhost [127.0.0.1]) by carhart.net (8.13.8/8.13.8) with ESMTP id u5NBMfsS027814 for ; Thu, 23 Jun 2016 04:22:42 -0700 Received: from localhost (kevin@localhost) by carhart.net (8.13.8/8.13.8/Submit) with ESMTP id u5NBMfsE027811 for ; Thu, 23 Jun 2016 04:22:41 -0700 Date: Thu, 23 Jun 2016 04:22:41 -0700 (PDT) From: Kevin Carhart To: edbrowse-dev@lists.the-brannons.com Message-ID: User-Agent: Alpine 2.03 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII Subject: [Edbrowse-dev] questions about new finds X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.21 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2016 11:21:13 -0000 Predominantly for Karl , hi Karl: I have several things to submit. There are a couple of areas where I'd like to find out if you think the entire class of correction is a mistake and wouldn't be good, before I make a patch out of it. Or I have discovered a couple of areas where I'd like to know if you think there would be a good approach. (1) Not a JS problem for a change: Sites are creating kinds of tags with their own invented vocabulary as the type. These tag types are not in availableTags, so we get a message that the tag could not be created. For instance, Amazon and other pages want to create: video canvas header comment fragment nav modernizr Do we want to add these phrases to availableTags even though they are just made-up names? Probably not, since it becomes silly to hardcode an endless number of them. 'video' and 'comment' seem plausible, but 'modernizr' is just some library. Is there some way that availableTags could be amended on the fly and these and all future unencountered tag types would get a generic placeholder? The reason I for wanting to support these things would be that maybe the site's javascript expects to address its own tag type and then write to it later on. (2) Amazon has a strange . In prepareScript, you have code to check that the language is "javascript". What do you think about also testing the "type" attribute? If a script has a strange type specified, return without parsing. (3) I think some page code within a timeout isn't getting to run, because it fails the strict test at the top of setTimeout where there must be 2 arguments and the second one must be numeric. Some of the jquery versions say this, for example: setTimeout( callback ); It doesn't run, and good thing too, if the strictness is necessary. However, it seems like a lot of site developers consider just 1 argument to be legitimate. Should we loosen the test? I am worried about this either way. I tried it more lenient, and bad code seemed to run. It was hard to isolate but edbrowse was crashing - so I don't know what to do. I was between a rock and a hard place, so I just went on to something else. I bet this is a cause of some sites not working. (4) I was wondering about a change in the event listener. At least some of the time, I have gotten events to work by having a kind of object called Event. Then you pass an object called 'click' or whatever it needs to be. I had some success with this on the Drescher page from Sebastian, in fact. (Sebastian points out that online banking is a higher priority to fix than Austrian metal with a sense of humor, but I happened to learn a lot from the Drescher site because they use jquery and xhr!) So, in startwindow, the handler is currently fired off like a[i](); But what if there was an argument inside the parentheses, which would be your event object. So the eval block begins eval('this.' + ev + ........................ var tempEvent = new Event tempEvent.type = ev; // actually would be ev without the "on" prepended a[i](tempEvent);} };'); That's enough for now, there are a lot of exciting areas to amend which I think will improve some sites. We have that whole iframe question as well. I also have some more normal additions I can submit soon for domLink and for the createElement switch statement in startwindow. For instance, elements need to have nodeType. thanks for reading Kevin