From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (mailfrom) identity=mailfrom; client-ip=8.23.224.61; helo=out.smtp-auth.no-ip.com; envelope-from=kevin@carhart.net; receiver= Received: from out.smtp-auth.no-ip.com (smtp-auth.no-ip.com [8.23.224.61]) by hurricane.the-brannons.com (Postfix) with ESMTPS id D1DDD77DE5 for ; Sun, 13 Aug 2017 21:54:32 -0700 (PDT) X-No-IP: carhart.net@noip-smtp X-Report-Spam-To: abuse@no-ip.com Received: from carhart.net (unknown [99.52.200.227]) (Authenticated sender: carhart.net@noip-smtp) by smtp-auth.no-ip.com (Postfix) with ESMTPA id 96A56304 for ; Sun, 13 Aug 2017 21:54:36 -0700 (PDT) Received: from carhart.net (localhost [127.0.0.1]) by carhart.net (8.13.8/8.13.8) with ESMTP id v7E4sXAG002297 for ; Sun, 13 Aug 2017 21:54:34 -0700 Received: from localhost (kevin@localhost) by carhart.net (8.13.8/8.13.8/Submit) with ESMTP id v7E4sXau002290 for ; Sun, 13 Aug 2017 21:54:33 -0700 Date: Sun, 13 Aug 2017 21:54:32 -0700 (PDT) From: Kevin Carhart To: Edbrowse-dev@lists.the-brannons.com In-Reply-To: <20170713220453.eklhad@comcast.net> Message-ID: References: <20170713073152.eklhad@comcast.net> <20170713220453.eklhad@comcast.net> User-Agent: Alpine 2.03 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Subject: [Edbrowse-dev] explanation of patch 20170813 X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.24 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Aug 2017 04:54:32 -0000 On Sun, 13 Aug 2017, Karl Dahlke wrote: > Indeed you do, but yours takes no arguments, and the one in acid is given 2 arguments. > Something doesn't line up. > > Karl Dahlke > Ok, I researched this a little and wrote a patch. Here are some notes on what is going on. What's defaultView? document.defaultView just returns window. Why does the acid3 test say document.defaultView.getComputedStyle? According to MDN, this is redundant. So I just put in code so that document.defaultView.getComputedStyle will call window.getComputedStyle and proceed. What is the point of window.getComputedStyle? I think the point is that there is supposed to be a cascading effect in the values of styles. As the comment says "whether removing an element that is the last child correctly recomputes styles for the new last child" Why are there two arguments and what do the arguments do? Here's the syntax for window.getComputedStyle, from MDN: var style = window.getComputedStyle(element[, pseudoElt]); The first argument is the element to return the styles for. The second argument is optional. It refers to pseudoelements. I'm leaving aside what those are, for now. Onwards and upwards.... this doesn't make test zero pass yet, but it's important to fix. The element called 'penultimate' isn't working correctly, but there is no longer a syntactical problem trying to say: document.defaultView.getComputedStyle(penultimate, '').whiteSpace Kevin