From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (mailfrom) identity=mailfrom; client-ip=8.23.224.60; helo=out.smtp-auth.no-ip.com; envelope-from=kevin@carhart.net; receiver= Received: from out.smtp-auth.no-ip.com (out.smtp-auth.no-ip.com [8.23.224.60]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 082AD77C83 for ; Tue, 15 Aug 2017 00:33:28 -0700 (PDT) X-No-IP: carhart.net@noip-smtp X-Report-Spam-To: abuse@no-ip.com Received: from carhart.net (unknown [99.52.200.227]) (Authenticated sender: carhart.net@noip-smtp) by smtp-auth.no-ip.com (Postfix) with ESMTPA id D49B2306; Tue, 15 Aug 2017 00:33:34 -0700 (PDT) Received: from carhart.net (localhost [127.0.0.1]) by carhart.net (8.13.8/8.13.8) with ESMTP id v7F7XXCQ025666; Tue, 15 Aug 2017 00:33:33 -0700 Received: from localhost (kevin@localhost) by carhart.net (8.13.8/8.13.8/Submit) with ESMTP id v7F7XXhB025663; Tue, 15 Aug 2017 00:33:33 -0700 Date: Tue, 15 Aug 2017 00:33:32 -0700 (PDT) From: Kevin Carhart To: Karl Dahlke cc: Edbrowse-dev@lists.the-brannons.com In-Reply-To: Message-ID: References: <20170713214236.kevin@carhart.net > <20170715024317.eklhad@comcast.net> User-Agent: Alpine 2.03 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Subject: Re: [Edbrowse-dev] defaultView and getComputedStyle patch X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.24 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Aug 2017 07:33:29 -0000 Sorry, that was kind of a distraction. :) Apparently I need to go read more articles like "Semicolons in Javascript are optional" by Mislav Marohnic. On Tue, 15 Aug 2017, Kevin Carhart wrote: > > It looks great to me! > I think my existing jsrt test still does the trick, right, even though the > ...... > > jesus, I left the semicolon off at 842 of jsrt. Shouldn't this make it fail? > > > > On Tue, 15 Aug 2017, Karl Dahlke wrote: > >>> Where does it live, and how should we do it? >> >> Both C and JS. I pushed the change, most of it but not all, look and see if >> it is reasonable. >> If this is the right path then I still have to change the actual html tag >>