From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (mailfrom) identity=mailfrom; client-ip=8.23.224.62; helo=out.smtp-auth.no-ip.com; envelope-from=kevin@carhart.net; receiver= Received: from out.smtp-auth.no-ip.com (smtp-auth.no-ip.com [8.23.224.62]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 32EFD77DE5 for ; Sun, 20 Aug 2017 13:56:44 -0700 (PDT) X-No-IP: carhart.net@noip-smtp X-Report-Spam-To: abuse@no-ip.com Received: from carhart.net (unknown [99.52.200.227]) (Authenticated sender: carhart.net@noip-smtp) by smtp-auth.no-ip.com (Postfix) with ESMTPA id 78129518; Sun, 20 Aug 2017 13:57:01 -0700 (PDT) Received: from carhart.net (localhost [127.0.0.1]) by carhart.net (8.13.8/8.13.8) with ESMTP id v7KKv0u0003412; Sun, 20 Aug 2017 13:57:00 -0700 Received: from localhost (kevin@localhost) by carhart.net (8.13.8/8.13.8/Submit) with ESMTP id v7KKux8a003403; Sun, 20 Aug 2017 13:57:00 -0700 Date: Sun, 20 Aug 2017 13:56:59 -0700 (PDT) From: Kevin Carhart To: Karl Dahlke cc: Edbrowse-dev@lists.the-brannons.com In-Reply-To: <20170720162422.eklhad@comcast.net> Message-ID: References: <20170719113834.eklhad@comcast.net> <20170720162422.eklhad@comcast.net> User-Agent: Alpine 2.03 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Subject: Re: [Edbrowse-dev] getAttributeNode / setAttributeNode X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.24 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Aug 2017 20:56:44 -0000 On Sun, 20 Aug 2017, Karl Dahlke wrote: > Well as you see, I implemented getAttributeNode(), because it wasn't hard, but a little harder than your example suggests because of side effects. Ah! Thank you. > > Sounds like I misunderstood though, and it should really be called querySelectorAll, but that's just a one line change if we want to do that. > Let me know if that's what we should do. Well.. I believe so, in the same way that we have apch, but pages by some random web developer in the world expect to lock on to appendChild. It's the DOM. querySelector and querySelectorAll are part of the DOM as far as they are concerned. We just happen to be implementing them in open javascript. > I notice inside the code it checks navigator.userAgent, so it tailors itself to the kind of browser we are. Yes.. I remember having a problem with a couple of lines that I think test for an IE version. I remember that the qS code has some multi byte Asian letters in some comments. I'll track them down later. Maybe they will sit merrily and be ignored, but I'm worried that they would make startwindow garbled if someone was compiling from source and didn't have a charset that renders these alphabets. Maybe it's fine.