From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (mailfrom) identity=mailfrom; client-ip=8.23.224.61; helo=out.smtp-auth.no-ip.com; envelope-from=kevin@carhart.net; receiver= Received: from out.smtp-auth.no-ip.com (smtp-auth.no-ip.com [8.23.224.61]) by hurricane.the-brannons.com (Postfix) with ESMTPS id 76969779FB for ; Fri, 24 Nov 2017 17:13:31 -0800 (PST) X-No-IP: carhart.net@noip-smtp X-Report-Spam-To: abuse@no-ip.com Received: from carhart.net (unknown [99.52.200.227]) (Authenticated sender: carhart.net@noip-smtp) by smtp-auth.no-ip.com (Postfix) with ESMTPA id 44C53566 for ; Fri, 24 Nov 2017 17:15:03 -0800 (PST) Received: from carhart.net (localhost [127.0.0.1]) by carhart.net (8.13.8/8.13.8) with ESMTP id vAP1F2V1026969 for ; Fri, 24 Nov 2017 17:15:02 -0800 Received: from localhost (kevin@localhost) by carhart.net (8.13.8/8.13.8/Submit) with ESMTP id vAP1F2bB026961 for ; Fri, 24 Nov 2017 17:15:02 -0800 Date: Fri, 24 Nov 2017 17:15:02 -0800 (PST) From: Kevin Carhart To: Edbrowse-dev@lists.the-brannons.com In-Reply-To: <20171024195602.eklhad@comcast.net> Message-ID: References: <20171016072958.eklhad@comcast.net> <20171024195602.eklhad@comcast.net> User-Agent: Alpine 2.03 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Subject: Re: [Edbrowse-dev] data-* attributes / new work on RC X-BeenThere: edbrowse-dev@lists.the-brannons.com X-Mailman-Version: 2.1.24 Precedence: list List-Id: Edbrowse Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Nov 2017 01:13:33 -0000 Yep, thank you for improving it, please fire away. Kevin On Fri, 24 Nov 2017, Karl Dahlke wrote: > This is lovely! > I applied your startwindow.js file and was going to push but I had to change something and wanted to check with you first. > You have localStorage in eb$master but I don't think that works. > I suspect each window has its own local storage. > Furthermore, if one window could access the local storage of another window it is probably a security hole that some clever person could exploit for bad things. > So I put it in the standard window, including localStorage.attributes = [] which you forgot but setAttribute() needs. > If this seems right to you I'll push. > > Karl Dahlke > -------- Kevin Carhart * 415 225 5306 * The Ten Ninety Nihilists