From: Kevin Carhart <kevin@carhart.net>
To: Edbrowse-dev@lists.the-brannons.com
Subject: [Edbrowse-dev] XHR same-domain restriction
Date: Sun, 11 Mar 2018 22:09:55 -0700 (PDT) [thread overview]
Message-ID: <alpine.LRH.2.03.1803112157580.21857@carhart.net> (raw)
Speaking of securing the filesystem and following up on Dominique's
message from a few days ago, do we want to implement the restriction that
XHR is only allowed to load pages from the domain that you are currently on?
If so, is this a workable phrasing to make the test? Assuming an xhr
object which I am referencing as 'this', this.url is a string. So I turn
it into our URL class in order to easily grab and test the host.
if (new URL(this.url).host == window.location.host)
{
allow fetchHTTP to run
} else {
prevent fetchHTTP from running
set this.aborted = true
throw a new error with a message
}
Here's a startwindow that makes this change if we want to do this.
http://carhart.net/~kevin/startwindow_20180311.zip
Tested on the dummy page http://carhart.net/~kevin/badxhr.html
Without the change, xhr.responseText gets the contents of http://pizza.com
With the change, it refuses to load http://pizza.com from carhart.net
next reply other threads:[~2018-03-12 5:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 5:09 Kevin Carhart [this message]
2018-03-12 6:33 ` Karl Dahlke
2018-03-12 7:17 ` Dominique Martinet
2018-03-12 12:38 ` Karl Dahlke
2018-03-12 12:57 ` Dominique Martinet
2018-03-14 1:54 ` Kevin Carhart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.03.1803112157580.21857@carhart.net \
--to=kevin@carhart.net \
--cc=Edbrowse-dev@lists.the-brannons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).