edbrowse-dev - development list for edbrowse
 help / color / mirror / Atom feed
From: Geoff McLane <ubuntu@geoffair.info>
To: Dominique Martinet <asmadeus@codewreck.org>,
	"alf.siciliano@gmail.com" <alf.siciliano@gmail.com>
Cc: edbrowse-dev@edbrowse.org
Subject: Re: [edbrowse-dev] tidySetOptBool vs tidySetOptInt on debian
Date: Sun, 8 Dec 2019 03:29:04 +0100	[thread overview]
Message-ID: <b756b325-34ce-6fb5-6af0-ce6aeb3cd74c@geoffair.info> (raw)
In-Reply-To: <20191207221625.GA12745@nautica>

Hi all,

So sorry for the role 'libTidy' plays in this...

Since it was introduced, circa 2017, the option 'TidyStyleTags' is a 
boolean... ie use 'tidyOptSetBool'... No change is allowed... even if it 
works... no ifdef whatever... since commit [1]... full stop...

When linking, the installed version of tidy, through 'FindTidy.cmake', 
when found, and used, it is of paramount importance, that the installed 
'lbtidy-dev', namely the headers, are of the /SAME/ version...

That is the tidy.h, which includes tidyenum.h, are of the /SAME/ version 
as the shared library found... not very easy to determine...

Else there will be 'assert' problems in the non-release build, and 
unknown, untold, unseen, problems otherwise...

Now specific os distributions muddy the water... and the 'tidy' cmake 
build of 'libTidy' is very flexible... so you get differences...

Like I am very alarmed by the 'findTidy.cmake' change -

```
set(TIDY_NAMES tidy)
if (${CMAKE_SYSTEM_NAME} STREQUAL  "FreeBSD")
     set(TIDY_NAMES tidy5)
endif ()
```

Ugh, a library name change! But the cmake build allows it, for 
distros... and IF the installed 'tidy.h' agree, ie are the same 
version... then why not...

So we have to look, case by case, at these failures...

How can I help?

Usually, need more information...

The results from -

```
$ ldd edbrowse | grep tidy
```

can help... of course that link usually needs to be traced back to its 
source... and then to the installed 'tidy.h' public headers...

And especially in the cases where `find /usr/include -name tidy.h` 
yields things like -

```
/usr/include/tidy/tidy.h
/usr/include/tidy.h
```

What is installed =

```
$ dpkg -l | grep tidy
```

can also help... but can be /very/ misleading... if you have built, and 
installed, the current tidy from source...

Each problem has a solution... but usually /NOT/ from altering the 
source code...

Just hope this helps...

At the moment, my os windows build fails on 'main.c:140 - if (ti == 
pthead_self())`, since you can not compare  structures in that way... 
but maybe this is just windows specific... but the docs suggest if 
(pthread_equal(t1, t2)) ...

Regards, Geoff.

[1] 
https://github.com/htacg/tidy-html5/commit/50859e82583c383a866e76a4289f601352c335b7


  reply	other threads:[~2019-12-08  2:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-07 17:15 Adam Thompson
2019-12-07 18:43 ` Dominique Martinet
2019-12-07 19:01   ` Alfonso S. Siciliano
2019-12-07 19:34     ` Dominique Martinet
2019-12-07 19:49       ` Adam Thompson
2019-12-07 21:45         ` alf.siciliano
2019-12-07 22:16           ` Dominique Martinet
2019-12-08  2:29             ` Geoff McLane [this message]
2019-12-08  3:56               ` Karl Dahlke
2019-12-08  8:08                 ` Alfonso Sabato Siciliano
2019-12-08  8:07               ` Dominique Martinet
2019-12-08 13:22               ` Adam Thompson
2019-12-08 21:22                 ` Geoff McLane
2019-12-07 19:44     ` Adam Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b756b325-34ce-6fb5-6af0-ce6aeb3cd74c@geoffair.info \
    --to=ubuntu@geoffair.info \
    --cc=alf.siciliano@gmail.com \
    --cc=asmadeus@codewreck.org \
    --cc=edbrowse-dev@edbrowse.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).