From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by hurricane.the-brannons.com (Postfix) with ESMTPS id EAD317B35A for ; Sat, 7 Dec 2019 18:29:08 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id z3so12136572wru.3 for ; Sat, 07 Dec 2019 18:29:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=geoffair-info.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=Vr5y3MXpzwhFyFiVPqZucKP/+RbPrN/RJQL6FTBRqGE=; b=qsJKfpTyvQGsfroYio9IKGvB6D9Qf5mFZb+Qcqo6ZJUHm17c2wD4saw714mHyndSsS eHFPMg6khTrnIp8FhjAJomjlp7xQqc7vf+8VOk+6D7u4k1DHbCkbi7b1hgvpgJjWEw8I 05hLOfujWWVtE9D56zc3E+py94zHwA0S3RKUq/Uo+F+iOxyNcrz5UjPZSgtucuCplrMf r4gumn+ilz2MCEfOfEwLqdZ/G0giBk6abLwqTdhOcDfbYw8Ng3hbwFQKAW7J5IBDIgHH R7pbWu10Tz16LfEWbJ/xYgGcih6Caca1iE+ExXzXg3jkgY33nAOdQJBaCqttNHFPr4ML MMYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=Vr5y3MXpzwhFyFiVPqZucKP/+RbPrN/RJQL6FTBRqGE=; b=hxnMJcLjksT6F1jBv7Iy7WVGCNiFhOgZmzD4RY8StbK/E4cDZAXr6LGRHmZ/6BoFdb ei2BD1o+mglR/OxStFZAls/j6FIf7sQULz/B2u1KI9XIQ7Armk4vDvHIaAroTzMpqeNk eWQdoSXmhqGXHyEvxo5DGDcUZlkdcZXV4Ytqa22wPM5PVxeXMWnH4zOnCITvO3Db6tLS GZdZmceL8CEEJ2lZLWl3xZ72d+CVuNQg8u6ptxhxdgbU7g0m+IBFjj241fxNPsOVXlAV fNKAdzSI5vRWVhKHDpORXTrFx38WwMm/ApYEe2V6aCWC0qHObfBEie4/eFrHzAZDu5B9 Lblg== X-Gm-Message-State: APjAAAVIQCQJtcGSLhC7+qbDMLJ6gVU8u92bl1qmjaY+pg4bQgJXVi4W 8Eahho+Qti9LegLD/8bPix2HnoCVCn4= X-Google-Smtp-Source: APXvYqySpa+6SvFIsVsDn6VeS89VK3sVcxwJVgkyGJJf0uky75C4FGbVt1t1PBHKFdJdOzHktVl4uw== X-Received: by 2002:a5d:42c5:: with SMTP id t5mr24149830wrr.73.1575772146514; Sat, 07 Dec 2019 18:29:06 -0800 (PST) Received: from ?IPv6:2a01:cb04:4ba:c500:81c4:dbb8:c33c:5a62? (2a01cb0404bac50081c4dbb8c33c5a62.ipv6.abo.wanadoo.fr. [2a01:cb04:4ba:c500:81c4:dbb8:c33c:5a62]) by smtp.googlemail.com with ESMTPSA id f16sm8486363wrm.65.2019.12.07.18.29.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Dec 2019 18:29:05 -0800 (PST) Subject: Re: [edbrowse-dev] tidySetOptBool vs tidySetOptInt on debian To: Dominique Martinet , "alf.siciliano@gmail.com" Cc: edbrowse-dev@edbrowse.org References: <20191207171534.GA194728@toaster> <20191207184354.GA5418@nautica> <20191207200147.ca1a7b961f790d11feab8fe7@gmail.com> <20191207193433.GA15586@nautica> <20191207194928.GD194728@toaster> <20191207224543.ec830db69d404376505a33ea@gmail.com> <20191207221625.GA12745@nautica> From: Geoff McLane Message-ID: Date: Sun, 8 Dec 2019 03:29:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 X-BeenThere: edbrowse-dev@edbrowse.org List-Id: Edbrowse Development List MIME-Version: 1.0 In-Reply-To: <20191207221625.GA12745@nautica> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Hi all, So sorry for the role 'libTidy' plays in this... Since it was introduced, circa 2017, the option 'TidyStyleTags' is a boolean... ie use 'tidyOptSetBool'... No change is allowed... even if it works... no ifdef whatever... since commit [1]... full stop... When linking, the installed version of tidy, through 'FindTidy.cmake', when found, and used, it is of paramount importance, that the installed 'lbtidy-dev', namely the headers, are of the /SAME/ version... That is the tidy.h, which includes tidyenum.h, are of the /SAME/ version as the shared library found... not very easy to determine... Else there will be 'assert' problems in the non-release build, and unknown, untold, unseen, problems otherwise... Now specific os distributions muddy the water... and the 'tidy' cmake build of 'libTidy' is very flexible... so you get differences... Like I am very alarmed by the 'findTidy.cmake' change - ``` set(TIDY_NAMES tidy) if (${CMAKE_SYSTEM_NAME} STREQUAL  "FreeBSD")     set(TIDY_NAMES tidy5) endif () ``` Ugh, a library name change! But the cmake build allows it, for distros... and IF the installed 'tidy.h' agree, ie are the same version... then why not... So we have to look, case by case, at these failures... How can I help? Usually, need more information... The results from - ``` $ ldd edbrowse | grep tidy ``` can help... of course that link usually needs to be traced back to its source... and then to the installed 'tidy.h' public headers... And especially in the cases where `find /usr/include -name tidy.h` yields things like - ``` /usr/include/tidy/tidy.h /usr/include/tidy.h ``` What is installed = ``` $ dpkg -l | grep tidy ``` can also help... but can be /very/ misleading... if you have built, and installed, the current tidy from source... Each problem has a solution... but usually /NOT/ from altering the source code... Just hope this helps... At the moment, my os windows build fails on 'main.c:140 - if (ti == pthead_self())`, since you can not compare  structures in that way... but maybe this is just windows specific... but the docs suggest if (pthread_equal(t1, t2)) ... Regards, Geoff. [1] https://github.com/htacg/tidy-html5/commit/50859e82583c383a866e76a4289f601352c335b7