public inbox for developer@lists.illumos.org (since 2011-08)
 help / color / mirror / Atom feed
From: Bill Sommerfeld <sommerfeld@hamachi.org>
To: developer@lists.illumos.org
Subject: [REVIEW] 16750 ACPI fails to build if VERSION contains spaces
Date: Sat, 31 Aug 2024 14:12:37 -0700	[thread overview]
Message-ID: <08fb98ed-a9f5-40f9-988a-ff8f430cc569@hamachi.org> (raw)

Issue: https://www.illumos.org/issues/16750
CR: https://code.illumos.org/c/illumos-gate/+/3656
Diff: 
https://code.illumos.org/~diff/bc17c9b56361b6c3250d98f972fb98b9276ef836

While doing test builds for 16742 I tripped over this little anomaly -
the cmd/acpi makefiles need to borrow a trick from the uts makefiles
to avoid brokenness if VERSION happens to contain a space.

Thanks in advance for your review.

					- Bill

                 reply	other threads:[~2024-08-31 21:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08fb98ed-a9f5-40f9-988a-ff8f430cc569@hamachi.org \
    --to=sommerfeld@hamachi.org \
    --cc=developer@lists.illumos.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).