Call for testers: upstreaming pcie/hotplug improvements

Call for testers: upstreaming pcie/hotplug improvements

[Andy Fiddaman]

Hi All,

We're in the process of upstreaming some improvements to PCIe pieces
in the kernel and would appreciate some wider testing of these before the
next steps.

The set of changes can be seen in Gerrit via the "Relation chain" links at
the top right of https://code.illumos.org/c/illumos-gate/+/3060 and it
should be possible to check out the whole chain via the kebab menu if you
want to build the bits yourself.

If you're using OmniOS, then there is a hot fix available that's easy to apply
and, if you can schedule a reboot, it would be really helpful if you can give
this a try and collect some data before and after.

### Before installing the new change

* Grab `prtconf -dD`
* Grab `cfgadm -alv`
* Grab `/usr/lib/fm/fmd/fmtopo -V` output
* Grab `/usr/lib/pci/pcieadm show-devs`
* Grab `/usr/lib/pci/pcieadm save-cfgspace -a /path/to/directory`

### Installing the hot fix (OmniOS r151046 or OmniOS bloody)

pkg apply-hot-fix --be-name=pcieus2023 https://hf.omnios.org/r46/pcie-202310.p5p
init 6     # or reboot in some other way

( https://hf.omnios.org/bloody/pcie-202310.p5p if you are running OmniOS bloody)

### After the reboot

Please collect the same information again, tar or zip everything up and let me
know how I can get it.

Thanks in advance, your help is appreciated.

Andy

Re: [developer] Call for testers: upstreaming pcie/hotplug improvements

[Dan McDonald]

[-- Attachment #1.1: Type: text/plain, Size: 728 bytes --]

I've constructed non-DEBUG SmartOS artifacts (.tgz PI, .iso, and .usb.gz USB) available here:

https://kebe.com/~danmcd/webrevs/pcieus/

If anyone has problems and needs a DEBUG build, please let me know.

You can take samples on stock SmartOS, then the new ones, on interesting hardware you might have per Andy's instructions which I quote here:

> ### Before installing the new change
>
> * Grab `prtconf -dD`
> * Grab `cfgadm -alv`
> * Grab `/usr/lib/fm/fmd/fmtopo -V` output
> * Grab `/usr/lib/pci/pcieadm show-devs`
> * Grab `/usr/lib/pci/pcieadm save-cfgspace -a /path/to/directory`

I'm also including a script that does the above and places results into a ./<timestamp> directory.

Thanks!
Dan




[-- Attachment #1.2: Type: text/html, Size: 1278 bytes --]

[-- Attachment #2: snapshot.sh --]
[-- Type: application/octet-stream, Size: 397 bytes --]

#!/bin/bash

dir=$(date "+%Y%m%d%T")
path=/root/pcie-test

mkdir $path/$dir
if [[ $? != 0 ]]; then echo "mkdir $path/$dir failed" ; exit 1 ; fi
cd $path/$dir
prtconf -dD >& prtconf.txt
cfgadm -alv >& cfgadm.txt
/usr/lib/fm/fmd/fmtopo -V >& fmtopo.txt
/usr/lib/pci/pcieadm show-devs >& show-devs.txt
mkdir $path/$dir/cfgspace
/usr/lib/pci/pcieadm save-cfgspace -a $path/$dir/cfgspace