From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx2.listbox.com (lb-mx2.nyi.icgroup.com [10.90.30.79]) by arc2.listbox.com (Postfix) with ESMTP id 36629183A8 for ; Tue, 28 Jun 2016 10:58:34 -0400 (EDT) Received: from lb-mx2.nyi.icgroup.com (localhost [127.0.0.1]) by mx2.listbox.com (Postfix) with ESMTP id 34079F0D5 for ; Tue, 28 Jun 2016 10:58:34 -0400 (EDT) Received: from mail-lf0-f45.google.com (mail-lf0-f45.google.com [209.85.215.45]) by mx2.listbox.com (Postfix) with ESMTPS id 1A20FF0D4 for ; Tue, 28 Jun 2016 10:58:31 -0400 (EDT) Received: by mail-lf0-f45.google.com with SMTP id q132so13335912lfe.3 for ; Tue, 28 Jun 2016 07:58:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexenta-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:organization:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=jZrESnCpf0EXfpaCLfoLmj4A7KAEUcuHCzB1gHrU01s=; b=DWWwFVllIKYHgTx9KbMrNeH8gz7D2SYQKUO9su0AYGpUtmkbdeqSOF8F3j+mFE2k19 bgJmrWVpSfPKKYS572NDUEkd3nUTlU4u1Px67zu+mbNkibXQHEzpcijkHYGfiUYPu74G lwfhzVmG24yOM9sJwXq5PXjFsENuf6E5CVOX+rsFfSQsPG0HwSXOpU1gom13ouNKemzf XYWHp8pEHehhKzY4mjd98NWj705cR1XhPaO9NASQ8q3chGxhkzOeleb6ifawIjk1rsJ0 zIiBn4euTaHpBJkreAglrP8yRA3+tvKcYjvAVu+L833DBUQaRdNpj/2ZfJj2IMCORlzo GECw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding; bh=jZrESnCpf0EXfpaCLfoLmj4A7KAEUcuHCzB1gHrU01s=; b=Wldzv7+PYncYg/7zC4/jXJEGYX/iTm4fD+i8otASB/ugG3xhzCV7ufUMuXTrsI8EIy cR3UpiW+9uD5TtiZZCnbcSReR+57jNNqn67tdHdSPABPkfSqYH71RSyHKaCoPO1MHl05 IT4V+vg78oJcbZSkDnGKtScvVTslEstr0/V5Y50rMePE+IFJAZFQo/dkTkZY/ZBXn0P9 csCsc+3Zlz6zcmT3mOrTcIh0Oxuwbe68lsG+0VYaasV94ptzAOWL4YNf1aqRpizQb+Q+ l6ykkGIr630zSQkrYA+sSFQmIII46sq+uhqRX7obFaf3O/LJa3f3DvBIw2znNgfQrp8w YAaA== X-Gm-Message-State: ALyK8tKQJDuMS+6g0M3RfKe5XDBBoW/eVJoVJemavmnQcdA0GPq6AwRZDbGnUgfFVBmGs+NI X-Received: by 10.25.4.4 with SMTP id 4mr1121136lfe.208.1467125909214; Tue, 28 Jun 2016 07:58:29 -0700 (PDT) Received: from ?IPv6:2001:470:28:4ba:203d:d6bd:9227:b058? ([2001:470:28:4ba:203d:d6bd:9227:b058]) by smtp.gmail.com with ESMTPSA id 193sm4284095ljj.49.2016.06.28.07.58.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Jun 2016 07:58:28 -0700 (PDT) Subject: Re: [developer] [REVIEW] (again) 5713, 5714, 5715 updates to share man pages To: Robert Mustacchi , illumos-developer References: <29706517-0a76-1565-2cf2-b054edf56813@nexenta.com> From: Yuri Pankov Organization: Nexenta Systems, Inc. Message-ID: <108d5d95-1c35-1119-f862-c75c4f70fb03@nexenta.com> Date: Tue, 28 Jun 2016 17:58:25 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed content-transfer-encoding: quoted-printable Listbox-Message-Date: 2016-06-28T14:58:36Z Topicbox-Message-UUID: c88be15a-3d40-11e6-b259-a4af2520a431 On Tue, 21 Jun 2016 16:50:41 -0700, Robert Mustacchi wrote: > On 6/19/16 7:38 , Yuri Pankov wrote: >> issue: https://www.illumos.org/issues/5713 >> issue: https://www.illumos.org/issues/5714 >> issue: https://www.illumos.org/issues/5715 >> webrev: http://www.xvoid.org/illumos/webrev/il-man-share/ >> >> The changes are tied together thus one webrev. >> >> - remove NFS/SMB options and access_list description from sharemgr(1M) >> - remove access_list description from share_nfs(1M) >> - add share_smb(1M) describing SMB options >> - add shareacl(4) describing access_list format > > I started going through this and I'm a bit confused. Your sharemgr(1M) > in sdiffs doesn't look anything like the one currently in the gate. What > was this built against? I have more specific comments below: Sorry, forgot the conversion diff, which also moved the examples to=20 where they belong - I understand that this makes the review harder, and=20 I'm sorry for that, but I did that work long ago and just don't want to=20 see it got lost. http://www.xvoid.org/illumos/webrev/il-man-sharemgr-mdoc/ > man/man1m/sharemgr.1m: > > I get that you're trying to consolidate information here that used to be > here, but you need to give the user some kidn of hint of where to look. > You've removed all the content and there's not even a See Also. In > general, I'd expect there to be at least something like you had in the > share_nfs(1M) changes. Added the man pages to SEE ALSO, and added the text to 'share'=20 subcommand description. > man/man1m/share_smb.1m: Note line numbers correspond to the raw manual pa= ge. > > - In general I find the description a little confusing. The mount manual > pages separate out the distinction between the core mount binary doing > things and for example, what mount_nfs does. I get that share is what > ultimately from a user perspective does this, but it's not that all > invocations of share do this. Maybe change things here to say that > it's share_smb that starts this in a similar fashion to mount_nfs(1M). Updated the wording in both share_nfs(1M) and share_smb(1M). > - What are valid strings for the cksumlist argument to the cksum option? Thanks for asking this question, I incorrectly moved that option to=20 share_smb(1M) man page, while it should have gone to share_nfs(1M), but=20 looks like it isn't implemented in libshare at all, so simply removed. > +40: This should be .Sh, not .Ss in our manual page conventions. Fixed. I wasn't sure about this either, most likely we need to add it to=20 mdoc(5), or have a separate man page describing what *our* man pages=20 should look like, mdoc(5) shouldn't really describe that and do only markup. > +196, +202, +206: Presumably these should all include the reference that > the format is in shareacl(4) like the share_nfs page does. Done. incremental webrev:=20 http://www.xvoid.org/illumos/webrev/il-man-share-review1/ Note that I fixed the width specifiers in share_nfs(1M), the *real*=20 changes are at the top. And thanks for review, Robert!