From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.listbox.com (unknown [172.16.13.6]) by arc2.listbox.com (Postfix) with ESMTP id 3C9EC1C422 for ; Wed, 29 Jun 2016 19:28:55 -0400 (EDT) Received: from lb-mx1.int.icgroup.com (localhost [127.0.0.1]) by mx1.listbox.com (Postfix) with ESMTP id 125E012DBE for ; Wed, 29 Jun 2016 19:28:55 -0400 (EDT) Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by mx1.listbox.com (Postfix) with ESMTPS id 1367012DBD for ; Wed, 29 Jun 2016 19:28:52 -0400 (EDT) Received: by mail-pa0-f51.google.com with SMTP id wo6so21891254pac.3 for ; Wed, 29 Jun 2016 16:28:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joyent.com; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=UnV+Cy2WXs8sx+fQjjCaySLnJnc8Q5Y2yMiP+n29G/8=; b=j2r+eQ4X72T8au3vohjPIIYEfe8/04mLOJDGF3iUHYZgcnNC8qCU7J0RxMKCeemlb4 /22ugC3zbnTszVYPARjzEa8UgZnfWsOD7rsOEji9bo1nKTwll34lAJ7Gp3Y+w2LgfvgC msf/HY52PapjKrsGFJTDOpi+p2e1LrefcK+Hw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=UnV+Cy2WXs8sx+fQjjCaySLnJnc8Q5Y2yMiP+n29G/8=; b=UQw6qmghn5KVlIVWLO/vKqbqNc42wJMqVJ+4AdbSwSnpW8HM+/gvObI5OGhomVqWWy qBKb68Z3Xxwkj5XcQQOZZpHneWaoDjjXYy1T1LP7P5cEppLqITxuNDqImpUPAVrpLAGC Z91DwbfZF6MWT1pJ4mylPeox5HeTCq2Gh2OpUBrWHZtA3DK82rD0HHFuQlvy8Wg1iFct eLcy2SmUUjJ1T5FP78Y/J7fmtyqylyCjcZYLUoP+HqtATK4e81z6GSjezfMxTCbl1TB2 6m4toTFpT2wKC5ona2TBgktstfwVzjIIni6Y6vWjx5WRLYrduMkZP67G69QnNntJ1qOj R84w== X-Gm-Message-State: ALyK8tKf3E3YMr2t175/7nYrY0fkFHlGyw7xIAKo9GYUyz6CHRnIgljn5sBwTq0GMh0hle04 X-Received: by 10.66.85.41 with SMTP id e9mr16428469paz.88.1467242930964; Wed, 29 Jun 2016 16:28:50 -0700 (PDT) Received: from zanarkand.local ([208.184.5.170]) by smtp.gmail.com with ESMTPSA id k74sm370003pfk.78.2016.06.29.16.28.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Jun 2016 16:28:50 -0700 (PDT) Subject: Re: [developer] [REVIEW] (again) 5713, 5714, 5715 updates to share man pages To: Yuri Pankov , illumos-developer References: <29706517-0a76-1565-2cf2-b054edf56813@nexenta.com> <108d5d95-1c35-1119-f862-c75c4f70fb03@nexenta.com> From: Robert Mustacchi Message-ID: <1293b549-293d-7c55-b285-0b518035d902@joyent.com> Date: Wed, 29 Jun 2016 16:28:49 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <108d5d95-1c35-1119-f862-c75c4f70fb03@nexenta.com> Content-Type: text/plain; charset=utf-8 content-transfer-encoding: quoted-printable Listbox-Message-Date: 2016-06-29T23:28:57Z Topicbox-Message-UUID: 3e5f86dc-3e51-11e6-97c2-97c6f010038b On 6/28/16 7:58 , Yuri Pankov wrote: > On Tue, 21 Jun 2016 16:50:41 -0700, Robert Mustacchi wrote: >> On 6/19/16 7:38 , Yuri Pankov wrote: >>> issue: https://www.illumos.org/issues/5713 >>> issue: https://www.illumos.org/issues/5714 >>> issue: https://www.illumos.org/issues/5715 >>> webrev: http://www.xvoid.org/illumos/webrev/il-man-share/ >>> >>> The changes are tied together thus one webrev. >>> >>> - remove NFS/SMB options and access_list description from sharemgr(1M) >>> - remove access_list description from share_nfs(1M) >>> - add share_smb(1M) describing SMB options >>> - add shareacl(4) describing access_list format >> >> I started going through this and I'm a bit confused. Your sharemgr(1M) >> in sdiffs doesn't look anything like the one currently in the gate. What >> was this built against? I have more specific comments below: >=20 > Sorry, forgot the conversion diff, which also moved the examples to > where they belong - I understand that this makes the review harder, and > I'm sorry for that, but I did that work long ago and just don't want to > see it got lost. >=20 > http://www.xvoid.org/illumos/webrev/il-man-sharemgr-mdoc/ For what it's worth, it wasn't just the example shuffling, but also the reordering and the options changing a bunch. I've tried to go through this as best as I can. I don't quite get why -h is going away, especially when this is noted as committed. Would it be possible to make sure that we have references to the examples. e.g. see example n. sharemgr unset used to take a [-s sharepath] option in the long form. It doesn't seem to in the synopsis or otherwise anymore in the new form; however, you still reference the -s option in the description. What should it be? Robert