Suggestions on CP

Suggestions on CP

[bottaawesome633]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

Anyone working on these issues or I am allowed to work on them?
https://www.illumos.org/issues/16197
https://www.illumos.org/issues/16198
Do you have any suggestions concerning these issues?  

[-- Attachment #2: Type: text/html, Size: 398 bytes --]

Re: [developer] Suggestions on CP

[Andy Fiddaman]

[-- Attachment #1: Type: text/plain, Size: 1600 bytes --]


On Mon, 22 Jan 2024, bottaawesome633@gmail.com wrote:

> Anyone working on these issues or I am allowed to work on them?
> https://www.illumos.org/issues/16197
> https://www.illumos.org/issues/16198
> Do you have any suggestions concerning these issues?  

Hi,

I filed those because I came across them when porting some software to
illumos. As far as I know, nobody is working on them so please feel free
to pick them up, and thank you!

In general, if there is nobody listed in the `Assignee` field in the issue,
then it's most likely that nobody is working on it yet. Do you have an
illumos issue account? If so, we can set the assignee to you.

In terms of suggestions, I don't have anything specific to the change as
I haven't looked at the source, but here are a few optional ones:

- The code is probably quite old at this point, so when you make your changes
  and run `git pbchk`, it may well report issues with other parts of the code.
  Please consider fixing these up too as part of the change.
- Consider adding a test to usr/src/test/util-tests for the new functionality.
- If there are any compiler warnings turned off in the Makefile, please
  consider turning them back on and fixing any fallout. Same for if
  the `smatch` checker is disabled, or currently has pieces turned off.
- cp is currently a 32-bit binary. We are generally trying to move things
  towards 64-bit so if that extra work is something you'd like to look at,
  please feel free. Depending on the software, that port can be a bit of a
  challenge.

Thanks for asking,

Andy

Re: [developer] Suggestions on CP

[bottaawesome633]

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

Hii :)
Yes, my username is bottaX633 <https://www.illumos.org/users/13897>. I'd like to work on the, so please feel free to assign them to me. Thanks
Ahmed

[-- Attachment #2: Type: text/html, Size: 916 bytes --]

Re: [developer] Suggestions on CP

[Alan Coopersmith]

On 1/22/24 01:35, Andy Fiddaman wrote:
> - The code is probably quite old at this point, so when you make your changes
>    and run `git pbchk`, it may well report issues with other parts of the code.
>    Please consider fixing these up too as part of the change.

And for cp, the source code is cleverly hidden in the tree in the file
usr/src/cmd/mv/mv.c where few people expect to find it until they learn
it's secret (cp, mv, and ln in Solaris are all different personalities
of the same command).

	-alan-

Re: [developer] Suggestions on CP

[bottaawesome633]

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

> And for cp, the source code is cleverly hidden in the tree in the file
usr/src/cmd/mv/mv.c where few people expect to find it until they learn
it's secret (cp, mv, and ln in Solaris are all different personalities
of the same command).
So that is different from the cp.c file in libcmd?

[-- Attachment #2: Type: text/html, Size: 1305 bytes --]

Re: [developer] Suggestions on CP

[Peter Tribble]

[-- Attachment #1: Type: text/plain, Size: 906 bytes --]

On Tue, Jan 23, 2024 at 11:51 AM <bottaawesome633@gmail.com> wrote:

> And for cp, the source code is cleverly hidden in the tree in the file
> usr/src/cmd/mv/mv.c where few people expect to find it until they learn
> it's secret (cp, mv, and ln in Solaris are all different personalities
> of the same command).
>
> So that is different from the cp.c file in libcmd?
>

Yes, it is. That's for the ksh builtin.

(If you run ksh, and then type 'builtin cp', you get to use that one rather
than
the one in /usr/bin/cp, and if you then do 'cp --help' you'll see it's a
rather
different thing entirely.)

Some of the ksh builtins (but not cp) replaced the old standalone commands
in /usr/bin (wc is an example of one that's been replaced - there are a
number
that are hard links to /usr/bin/alias).

-- 
-Peter Tribble
http://www.petertribble.co.uk/ - http://ptribble.blogspot.com/

[-- Attachment #2: Type: text/html, Size: 2183 bytes --]