* 16614 cxgbe: support code for cxgbetool register read/write functionality @ 2024-07-10 6:20 bharat 2024-07-11 11:40 ` [developer] " Ryan Zezeski 0 siblings, 1 reply; 4+ messages in thread From: bharat @ 2024-07-10 6:20 UTC (permalink / raw) To: illumos-developer [-- Attachment #1: Type: text/plain, Size: 132 bytes --] Please review https://code.illumos.org/c/illumos-gate/+/3560 These changes add register dump support to cxgbtool of cxgbe drivers. [-- Attachment #2: Type: text/html, Size: 262 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [developer] 16614 cxgbe: support code for cxgbetool register read/write functionality 2024-07-10 6:20 16614 cxgbe: support code for cxgbetool register read/write functionality bharat @ 2024-07-11 11:40 ` Ryan Zezeski 2024-07-12 16:08 ` bharat 2024-07-16 13:35 ` bharat 0 siblings, 2 replies; 4+ messages in thread From: Ryan Zezeski @ 2024-07-11 11:40 UTC (permalink / raw) To: illumos-developer "bharat via illumos-developer" <developer@lists.illumos.org> writes: > Please review https://code.illumos.org/c/illumos-gate/+/3560 > These changes add register dump support to cxgbtool of cxgbe drivers. Hi Bharat, thanks for the contribution. I notice there are two CRs open against issue 16614. The first which you linked in your original email, and this following one. https://code.illumos.org/c/illumos-gate/+/3559/7 This later CR looks to add support for dumping the T6 regs, which I believe you want to be part of the overall work for issue 16614. The illumos project prefers to have logically related work as one commit; that is, one commit per issue. I would roll these into one commit under the 3560 CR. Furthermore, rather than removing the T4 regs I would also add support for dumping T4 regs. Finally, the commit message should match the issue title verbatim; so you'll want to change one or the other so that they match. Thanks, Ryan ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [developer] 16614 cxgbe: support code for cxgbetool register read/write functionality 2024-07-11 11:40 ` [developer] " Ryan Zezeski @ 2024-07-12 16:08 ` bharat 2024-07-16 13:35 ` bharat 1 sibling, 0 replies; 4+ messages in thread From: bharat @ 2024-07-12 16:08 UTC (permalink / raw) To: illumos-developer [-- Attachment #1: Type: text/plain, Size: 204 bytes --] Thanks for the review Ryan, I thought of removing T4 regs as its reaching EOl. Based on your feedback, I think I will add back the T4 regs and add support for T4 aswell. I shall post the v2 for review. [-- Attachment #2: Type: text/html, Size: 273 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [developer] 16614 cxgbe: support code for cxgbetool register read/write functionality 2024-07-11 11:40 ` [developer] " Ryan Zezeski 2024-07-12 16:08 ` bharat @ 2024-07-16 13:35 ` bharat 1 sibling, 0 replies; 4+ messages in thread From: bharat @ 2024-07-16 13:35 UTC (permalink / raw) To: illumos-developer [-- Attachment #1: Type: text/plain, Size: 82 bytes --] posted V2 patch @ https://code.illumos.org/c/illumos-gate/+/3560. Please review [-- Attachment #2: Type: text/html, Size: 216 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-16 13:35 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-07-10 6:20 16614 cxgbe: support code for cxgbetool register read/write functionality bharat 2024-07-11 11:40 ` [developer] " Ryan Zezeski 2024-07-12 16:08 ` bharat 2024-07-16 13:35 ` bharat
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).