From: Dan McDonald <danmcd@mnx.io>
To: illumos-developer <developer@lists.illumos.org>
Subject: Recent NVMe changes break testing on a VMware guest?
Date: Thu, 11 Jul 2024 16:00:02 +0000 [thread overview]
Message-ID: <1A82FA49-90F0-4B2B-AF0F-B6BF90F9A62F@mnx.io> (raw)
I'm hoping this is a quirk of VMware Fusion's virtual NVMe device, but testing this my recent SmartOS release, I found new errors:
kebe(~/smartos-tests/release-20240711)[0]% find . -type f | xargs grep firmware.32
./test_results/20240711T034200/unit/firmware.32/stderr:firmware.32: TEST FAILED: invalid fw load numd 8k gran (3): found wrong return value NVME_FIELD_ERR_OK (0), expected NVME_FIELD_ERR_BAD_VALUE (3)
./test_results/20240711T034200/unit/firmware.32/stderr:firmware.32: TEST FAILED: invalid fw load numd 8k gran (4): found wrong return value NVME_FIELD_ERR_OK (0), expected NVME_FIELD_ERR_BAD_VALUE (3)
./test_results/20240711T034200/unit/firmware.32/merged:firmware.32: TEST FAILED: invalid fw load numd 8k gran (3): found wrong return value NVME_FIELD_ERR_OK (0), expected NVME_FIELD_ERR_BAD_VALUE (3)
./test_results/20240711T034200/unit/firmware.32/merged:firmware.32: TEST FAILED: invalid fw load numd 8k gran (4): found wrong return value NVME_FIELD_ERR_OK (0), expected NVME_FIELD_ERR_BAD_VALUE (3)
./test_results/20240711T034200/log:Test: /opt/nvme-tests/tests/unit/firmware.32 (run as root) [00:00] [FAIL]
./test_results/20240711T034200/log:03:42:00.06 firmware.32: TEST FAILED: invalid fw load numd 8k gran (3): found wrong return value NVME_FIELD_ERR_OK (0), expected NVME_FIELD_ERR_BAD_VALUE (3)
./test_results/20240711T034200/log:03:42:00.06 firmware.32: TEST FAILED: invalid fw load numd 8k gran (4): found wrong return value NVME_FIELD_ERR_OK (0), expected NVME_FIELD_ERR_BAD_VALUE (3)
kebe(~/smartos-tests/release-20240711)[0]%
I know I didn't mismerge anything, because there are no diffs between gate and illumos-joyent's nvme code:
smartos-build(~/illumos-merge-tools)[2]% diff -ru illumos-{gate,joyent}/usr/src/uts/intel/nvme
smartos-build(~/illumos-merge-tools)[0]% diff -ru illumos-{gate,joyent}/usr/src/uts/common/io/nvme
smartos-build(~/illumos-merge-tools)[0]% diff -ru illumos-{gate,joyent}/usr/src/uts/common/sys/nvme
smartos-build(~/illumos-merge-tools)[0]% diff -ru illumos-{gate,joyent}/usr/src/common/nvme
smartos-build(~/illumos-merge-tools)[0]% diff -ru illumos-{gate,joyent}/usr/src/cmd/nvmeadm
smartos-build(~/illumos-merge-tools)[0]% diff -ru illumos-{gate,joyent}/usr/src/lib/libnvme
Common subdirectories: illumos-gate/usr/src/lib/libnvme/amd64 and illumos-joyent/usr/src/lib/libnvme/amd64
Common subdirectories: illumos-gate/usr/src/lib/libnvme/common and illumos-joyent/usr/src/lib/libnvme/common
Common subdirectories: illumos-gate/usr/src/lib/libnvme/i386 and illumos-joyent/usr/src/lib/libnvme/i386
smartos-build(~/illumos-merge-tools)[0]% diff -ru illumos-{gate,joyent}/usr/src/test/nvme-tests
Common subdirectories: illumos-gate/usr/src/test/nvme-tests/cmd and illumos-joyent/usr/src/test/nvme-tests/cmd
Common subdirectories: illumos-gate/usr/src/test/nvme-tests/runfiles and illumos-joyent/usr/src/test/nvme-tests/runfiles
Common subdirectories: illumos-gate/usr/src/test/nvme-tests/tests and illumos-joyent/usr/src/test/nvme-tests/tests
Common subdirectories: illumos-gate/usr/src/test/nvme-tests/tests/ioctl and illumos-joyent/usr/src/test/nvme-tests/tests/ioctl
Common subdirectories: illumos-gate/usr/src/test/nvme-tests/tests/libnvme and illumos-joyent/usr/src/test/nvme-tests/tests/libnvme
Common subdirectories: illumos-gate/usr/src/test/nvme-tests/tests/nvmeadm and illumos-joyent/usr/src/test/nvme-tests/tests/nvmeadm
Common subdirectories: illumos-gate/usr/src/test/nvme-tests/tests/unit and illumos-joyent/usr/src/test/nvme-tests/tests/unit
smartos-build(~/illumos-merge-tools)[0]%
Does anyone with NVMe experience have insight into why the two tests (unit/firmware.*) fail now?
Thanks,
Dan
next reply other threads:[~2024-07-11 16:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 16:00 Dan McDonald [this message]
2024-07-11 16:12 ` [developer] " Dan McDonald
2024-07-11 16:40 ` Andy Fiddaman
2024-07-11 17:51 ` Dan McDonald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1A82FA49-90F0-4B2B-AF0F-B6BF90F9A62F@mnx.io \
--to=danmcd@mnx.io \
--cc=developer@lists.illumos.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).