public inbox for developer@lists.illumos.org (since 2011-08)
 help / color / mirror / Atom feed
From: Andy Fiddaman <illumos@fiddaman.net>
To: developer@lists.illumos.org
Subject: Review - 16612 libshare does not build with libxml2 2.13
Date: Mon, 17 Jun 2024 15:54:29 +0000	[thread overview]
Message-ID: <20240617155429.GA25151@reaper.citrus-it.net> (raw)

Please can you review the following change?

I put some details in the issue but the short version is that libxml2 version
2.13 has changed a function signature without bumping the library version.
This fixes libshare so that it continues to build after libxml2 is updated,
and still builds with previous versions. It just ignores the return value
which is not ideal but fairly consistent with the way in libshare is already
using the library.

    16612 libshare does not build with libxml2 2.13
    https://www.illumos.org/issues/16612
    https://code.illumos.org/c/illumos-gate/+/3552

Thanks,

Andy

                 reply	other threads:[~2024-06-17 15:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240617155429.GA25151@reaper.citrus-it.net \
    --to=illumos@fiddaman.net \
    --cc=developer@lists.illumos.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).