From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from tb-mx0.topicbox.com (localhost.local [127.0.0.1]) by tb-mx0.topicbox.com (Postfix) with ESMTP id B0C011C4599F for ; Mon, 17 Jun 2024 11:54:32 -0400 (EDT) (envelope-from prvs=189874fc17=illumos@fiddaman.net) Received: from tb-mx0.topicbox.com (localhost [127.0.0.1]) by tb-mx0.topicbox.com (Authentication Milter) with ESMTP id B2C04135F57; Mon, 17 Jun 2024 11:54:32 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1718639672; b=w0Yc7BPIEZqqPzQhz5oyoUrQr9X/XH0hFjzGV/+mjhhal1zN/q kZUChib8fn+iK0ILsSUZBt6NZb6diWkwUYE8S0g19aL8eVAju/SaKeZaVbkZZqR0 zQnAO0uDbLxvWTxxGhoOMDdFT3CD9f3nPcyKiwz8qDCc9Oa00NG8ab9YR2zzNY7p 10qt+X0a/DfJArNKzfK7q1/pCHQ+t8364mZ9fi8KuRkhjm9GY2oNGVnhrWTlCGzg GPAFjij7w9sYEEm/3D/nyB4DndXFalD+usTBFbJ0YB+1PHRlwVBxkJIjbMlmKtXt 4UnWSiSl50smTG77Vm4awOjXAumg/Hgk/bMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=date:from:to:subject:message-id:mime-version :content-type; s=arcseal; t=1718639672; bh=H35uYeQfvc0qlFnvhmRU1 RXWxT2e+X3kZhEh97jaghU=; b=xGa956mSpq6+G0qH9wx2q1ypZx/Sb895rPe7X J93HhdBMLKzFpJ8VfvMXKLPf4ii7fVtmQ+mjxYmtyrM1JVPKXrdHH7vk20E+6HEy mONM0OItgdrZ1ww6Ybis05ydhek9u8uVDcwpA6ZwUuGMRHAoEfpOEVjWdoRICLN+ 6SsEAs3TUsuZ9Mi0Q55UNcMZCmicKxwJ9pbWqRV1b+tNKVVRW+JkR26pcE0NMKl9 y6rSKljmQTECgSeBJpdbiUbXtL0QXykr6sbCN7LLyDtz4UaYjiHf+jBdeR9HtzYI XOhQiCFvcgk2bf54tyG3A3Is8nLEG8jnjiySbGqZ1Ukc26LrQ== ARC-Authentication-Results: i=1; tb-mx0.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=pass (1024-bit rsa key sha256) header.d=fiddaman.net header.i=@fiddaman.net header.b=PSat0DQj header.a=rsa-sha256 header.s=boomer x-bits=1024; dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=fiddaman.net; iprev=pass smtp.remote-ip=89.248.55.103 (mail.citrus-it.net); spf=pass smtp.mailfrom="prvs=189874fc17=illumos@fiddaman.net" smtp.helo=mail.citrus-it.net; x-aligned-from=domain_pass (Domain match); x-me-sender=none; x-ptr=pass smtp.helo=mail.citrus-it.net policy.ptr=mail.citrus-it.net; x-return-mx=pass header.domain=fiddaman.net policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-return-mx=pass smtp.domain=fiddaman.net policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=0 state=0 Authentication-Results: tb-mx0.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=pass (1024-bit rsa key sha256) header.d=fiddaman.net header.i=@fiddaman.net header.b=PSat0DQj header.a=rsa-sha256 header.s=boomer x-bits=1024; dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=fiddaman.net; iprev=pass smtp.remote-ip=89.248.55.103 (mail.citrus-it.net); spf=pass smtp.mailfrom="prvs=189874fc17=illumos@fiddaman.net" smtp.helo=mail.citrus-it.net; x-aligned-from=domain_pass (Domain match); x-me-sender=none; x-ptr=pass smtp.helo=mail.citrus-it.net policy.ptr=mail.citrus-it.net; x-return-mx=pass header.domain=fiddaman.net policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-return-mx=pass smtp.domain=fiddaman.net policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=0 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgedvledrfedvhedgleegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuf fkgggtugesthdtredttddtvdenucfhrhhomheptehnugihucfhihguuggrmhgrnhcuoehi lhhluhhmohhssehfihguuggrmhgrnhdrnhgvtheqnecuggftrfgrthhtvghrnhepteeuff duieehuedugefhgedulefhheeuheehieeiuddukeejjedvfeduvefhkeeunecuffhomhgr ihhnpehilhhluhhmohhsrdhorhhgnecukfhppeekledrvdegkedrheehrddutdefpdekle drvdegkedrheehrdejleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhn vghtpeekledrvdegkedrheehrddutdefpdhhvghlohepmhgrihhlrdgtihhtrhhushdqih htrdhnvghtpdhmrghilhhfrhhomhepoehprhhvshepudekleekjeegfhgtudejpehilhhl uhhmohhssehfihguuggrmhgrnhdrnhgvtheqpdhnsggprhgtphhtthhopedupdhrtghpth htohepoeguvghvvghlohhpvghrsehlihhsthhsrdhilhhluhhmohhsrdhorhhgqe X-ME-VSScore: 0 X-ME-VSCategory: clean Received-SPF: pass (fiddaman.net: 89.248.55.103 is authorized to use 'prvs=189874fc17=illumos@fiddaman.net' in 'mfrom' identity (mechanism 'ip4:89.248.55.64/26' matched)) receiver=tb-mx0.topicbox.com; identity=mailfrom; envelope-from="prvs=189874fc17=illumos@fiddaman.net"; helo=mail.citrus-it.net; client-ip=89.248.55.103 Received: from mail.citrus-it.net (mail.citrus-it.net [89.248.55.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx0.topicbox.com (Postfix) with ESMTPS for ; Mon, 17 Jun 2024 11:54:31 -0400 (EDT) (envelope-from prvs=189874fc17=illumos@fiddaman.net) Authentication-Results: citrusmail; dkim=pass header.i=@fiddaman.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fiddaman.net; s=boomer; t=1718639670; bh=fii4/XjfI0yp+adWZydEjUnC3NpHcSnkqrMSwkLzbuU=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=PSat0DQjRP73gRw8VnebYKFhKpFkmZlRX5o8/gmZFfQ2lN0k74b95L+UeWhcR2ahh 4TldWg/wJV8kuxXs/AzeM7xBHi6Kix1mEVlCCRUO454QTepxJoFN1hBCyudI68Eh9u GMoYzu4+ZezFuMGFQ+wcQp677CDSbiceF+ZvR2ls= Received: from reaper.citrus-it.net (reaper.citrus-it.net [89.248.55.79]) by mail.citrus-it.net with ESMTP id 45HFsTD3000899 for ; Mon, 17 Jun 2024 15:54:30 GMT Date: Mon, 17 Jun 2024 15:54:29 +0000 From: Andy Fiddaman To: developer@lists.illumos.org Subject: Review - 16612 libshare does not build with libxml2 2.13 Message-ID: <20240617155429.GA25151@reaper.citrus-it.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Citrus-Version: 6.0.3ba253c X-Citrus-ID: 545HFsTD3000899 X-Citrus-Virus-Scanned: Clean X-Citrus-Spam: Whitelisted X-Citrus-Trust: Trusted Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: e62be786-2cc1-11ef-8680-f816fc8b7b06 Please can you review the following change? I put some details in the issue but the short version is that libxml2 version 2.13 has changed a function signature without bumping the library version. This fixes libshare so that it continues to build after libxml2 is updated, and still builds with previous versions. It just ignores the return value which is not ideal but fairly consistent with the way in libshare is already using the library. 16612 libshare does not build with libxml2 2.13 https://www.illumos.org/issues/16612 https://code.illumos.org/c/illumos-gate/+/3552 Thanks, Andy