From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from tb-mx0.topicbox.com (localhost.local [127.0.0.1]) by tb-mx0.topicbox.com (Postfix) with ESMTP id B53F21C600F4 for ; Tue, 18 Jun 2024 08:42:58 -0400 (EDT) (envelope-from prvs=189991e482=illumos@fiddaman.net) Received: from tb-mx0.topicbox.com (localhost [127.0.0.1]) by tb-mx0.topicbox.com (Authentication Milter) with ESMTP id 6D7E167BECE; Tue, 18 Jun 2024 08:42:58 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1718714578; b=HbAHkNd+Ya+Jnhou53N4y/k565ZGuNps1KqH3TzzObBKSpQK25 YiuXx8D/PZPp/95G8nEl7csfqXsipuQBZqrI5UeKrdmRVc4bG1MSwlwvPTTj46t4 nV1YtSZtiS52oYRWcUy1OtkPMnP0yVuxLk9CmFstqWsNUM+3GQiGhzF8gebeRPOO c5u0CuxosUKNnrBa0T2icWQzUP3LBKfG5s4kMcaS77qFSjHeRs3LblHIhgw5bsm4 2iBehYoqUrR2Us0v1yKVsubTCU4r6KDW66WbfEHaDiDvJT6Lj9fTLhnjdqkOk/3j UXNToCMcxTW/Ti9bIKk4NLnjpxbD1kbRiLQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=date:from:to:subject:message-id:mime-version :content-type; s=arcseal; t=1718714578; bh=WDn1Rqsouu5F7mbcFRTTs sEE6A9qecjznWyvx6fP1zM=; b=lOzlirZMp9sxVpL7la8dhIUCiD0evPYP2Ov+i iJr1mJp+SyeldqzqVIahg2abSbagiHNHMjPS1sF1ZbhRaJo0Mx+NOasPXexsJwNv XVEK9ZL0pLqNFHGyU/2Cg6xSZ6XkyyT/krFQqJG9zrqxBJbFGrGZXp5wIa67ENX2 EL07ebNv5ZEidKhq2TEDSWk2dnAOeKHR1ypJ++1j30dPZRlU05pCowlg/O1POLtt MKTBJFKWwok2lHqRxRTO/U0nUpziNFCTMnFDgXbq0N+A6++7kjTaG3o/CWj8pfna VszLM+ew2020MrLjQ0m6+Z16jC7UuPdDDczbaketia3Y0fkdA== ARC-Authentication-Results: i=1; tb-mx0.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=pass (1024-bit rsa key sha256) header.d=fiddaman.net header.i=@fiddaman.net header.b=JDV6GAUX header.a=rsa-sha256 header.s=boomer x-bits=1024; dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=fiddaman.net; iprev=pass smtp.remote-ip=89.248.55.103 (mail.citrus-it.net); spf=pass smtp.mailfrom="prvs=189991e482=illumos@fiddaman.net" smtp.helo=mail.citrus-it.net; x-aligned-from=domain_pass (Domain match); x-me-sender=none; x-ptr=pass smtp.helo=mail.citrus-it.net policy.ptr=mail.citrus-it.net; x-return-mx=pass header.domain=fiddaman.net policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-return-mx=pass smtp.domain=fiddaman.net policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=0 state=0 Authentication-Results: tb-mx0.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=pass (1024-bit rsa key sha256) header.d=fiddaman.net header.i=@fiddaman.net header.b=JDV6GAUX header.a=rsa-sha256 header.s=boomer x-bits=1024; dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=fiddaman.net; iprev=pass smtp.remote-ip=89.248.55.103 (mail.citrus-it.net); spf=pass smtp.mailfrom="prvs=189991e482=illumos@fiddaman.net" smtp.helo=mail.citrus-it.net; x-aligned-from=domain_pass (Domain match); x-me-sender=none; x-ptr=pass smtp.helo=mail.citrus-it.net policy.ptr=mail.citrus-it.net; x-return-mx=pass header.domain=fiddaman.net policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-return-mx=pass smtp.domain=fiddaman.net policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=0 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgedvledrfedvkedgvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuf fkgggtugesthdtredttddtvdenucfhrhhomheptehnugihucfhihguuggrmhgrnhcuoehi lhhluhhmohhssehfihguuggrmhgrnhdrnhgvtheqnecuggftrfgrthhtvghrnhepteeuff duieehuedugefhgedulefhheeuheehieeiuddukeejjedvfeduvefhkeeunecuffhomhgr ihhnpehilhhluhhmohhsrdhorhhgnecukfhppeekledrvdegkedrheehrddutdefpdekle drvdegkedrheehrdejleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhn vghtpeekledrvdegkedrheehrddutdefpdhhvghlohepmhgrihhlrdgtihhtrhhushdqih htrdhnvghtpdhmrghilhhfrhhomhepoehprhhvshepudekleelleduvgegkedvpehilhhl uhhmohhssehfihguuggrmhgrnhdrnhgvtheqpdhnsggprhgtphhtthhopedupdhrtghpth htohepoeguvghvvghlohhpvghrsehlihhsthhsrdhilhhluhhmohhsrdhorhhgqe X-ME-VSScore: 0 X-ME-VSCategory: clean Received-SPF: pass (fiddaman.net: 89.248.55.103 is authorized to use 'prvs=189991e482=illumos@fiddaman.net' in 'mfrom' identity (mechanism 'ip4:89.248.55.64/26' matched)) receiver=tb-mx0.topicbox.com; identity=mailfrom; envelope-from="prvs=189991e482=illumos@fiddaman.net"; helo=mail.citrus-it.net; client-ip=89.248.55.103 Received: from mail.citrus-it.net (mail.citrus-it.net [89.248.55.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx0.topicbox.com (Postfix) with ESMTPS for ; Tue, 18 Jun 2024 08:42:57 -0400 (EDT) (envelope-from prvs=189991e482=illumos@fiddaman.net) Authentication-Results: citrusmail; dkim=pass header.i=@fiddaman.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fiddaman.net; s=boomer; t=1718714576; bh=hKJVz+zMY5URipcClAGIYjrX0SzTHjsI6o0xnYwE5fM=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=JDV6GAUXShPj37FGYolSTFMnLIkpiN9dcPBKEqXV3j6lXDDR+RquQcK5LfPE7NCsY nV7G1iW7hI0B1gH6vSlg5sWEPRgUdcZAelVZEykvUo3qHvXhUc21GGdFl5mU0EgtR+ EmRYCjK4I0yIamzSt/Eit80HHvqHio1e9InlagiY= Received: from reaper.citrus-it.net (reaper.citrus-it.net [89.248.55.79]) by mail.citrus-it.net with ESMTP id 45ICgts9017330 for ; Tue, 18 Jun 2024 12:42:55 GMT Date: Tue, 18 Jun 2024 12:42:55 +0000 From: Andy Fiddaman To: developer@lists.illumos.org Subject: Review - 16591 nvme_field_validate swallows more specific error messages Message-ID: <20240618124255.GA16067@reaper.citrus-it.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Citrus-Version: 6.0.3ba253c X-Citrus-ID: 545ICgts9017330 X-Citrus-Virus-Scanned: Clean X-Citrus-Spam: Whitelisted X-Citrus-Trust: Trusted Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: 4fdf5f7e-2d70-11ef-9a7e-a5fd068c7b06 Please can you review the following changes? These are some small things we found when using nvmeadm and libnvme to update firmware on a Micron 7300 M.2 NVMe drive. 16591 nvme_field_validate swallows more specific error messages 16592 Cannot update NVMe firmware on Micron 7300 16593 nvme panic when committing partially loaded firmware 16596 nvmeadm: some firmware activation controller errors are not https://www.illumos.org/issues/16591 https://www.illumos.org/issues/16592 https://www.illumos.org/issues/16593 https://www.illumos.org/issues/16596 https://code.illumos.org/c/illumos-gate/+/3536 https://code.illumos.org/c/illumos-gate/+/3537 https://code.illumos.org/c/illumos-gate/+/3538 https://code.illumos.org/c/illumos-gate/+/3540 Thanks, Andy