From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from tb-mx0.topicbox.com (localhost.local [127.0.0.1]) by tb-mx0.topicbox.com (Postfix) with ESMTP id 08E971DFC749 for ; Wed, 3 Jul 2024 08:32:09 -0400 (EDT) (envelope-from prvs=1914b1f225=illumos@fiddaman.net) Received: from tb-mx0.topicbox.com (localhost [127.0.0.1]) by tb-mx0.topicbox.com (Authentication Milter) with ESMTP id DF6D151DD39; Wed, 3 Jul 2024 08:32:09 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1720009928; b=TCk+vgxCSPRqspXZFk38kCgR8HBxK1CucqOsekwI92REcFgX5s eD+Gb2RxsQXXsxquksiqJhU54q25WCLpWu8Zd+2bEoH2qyEtvHxM75n73x9hCFhj 3OAegMubURB93KS72oBu/MD6FaANDMrD/RFsrslCDfDleGG0f67lDdbGQG4nr5aP hsBO6tKGfXSLuJli4XATN99h15Js80n0qlgOfjSw35GjG5iMVCCVKLZY4vHUWNIw 6Fk1MzuHPs/8gIRw9pgqYt1L6AqhrnkULT+hjpZrv6+IZkIwq7ZELEBpF9hWCFUv RjIZWpkCx8gP0wDxdRR/Xvtntt/n3F3emuPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=date:from:to:subject:message-id:mime-version :content-type; s=arcseal; t=1720009928; bh=BLCvocguA6NykLZRVizEk Mf2Osm/G+GsFlI7ZR/5RSw=; b=Ys5Y64+rKUpp/q9a/DSI3LATkX262f+Y1KkMc EZqGa2/SWtxqIZfw9uOWQ/ywsPBOxIP2DzavcnkJSP6s68sALD0G5Wc14l2A4TPY 5mOCnVbueRn3G411WymVb375bw5aF4svW2mOlH97sQjgLtcSj0IyEsItOTiPvXwc 53NA0zcuBtm2KDeWQ449GBufYP8sl0Y5TNLjdqlrXCLg3Ty4Qt0nz8hC/mtBOxk7 uEneX+8R7XIPHABCFTFTjFHY4jgLN0eaVuWtW4kSmzKuQR2EpJRHoIHrCV2k10CJ f3MvlaASyWvxUGIvDAcMCsK8Hy46juV8CwwJ5RX1Tw73EnMEQ== ARC-Authentication-Results: i=1; tb-mx0.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=pass (1024-bit rsa key sha256) header.d=fiddaman.net header.i=@fiddaman.net header.b=T/GNLFkM header.a=rsa-sha256 header.s=boomer x-bits=1024; dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=fiddaman.net; iprev=pass smtp.remote-ip=89.248.55.103 (mail.citrus-it.net); spf=pass smtp.mailfrom="prvs=1914b1f225=illumos@fiddaman.net" smtp.helo=mail.citrus-it.net; x-aligned-from=domain_pass (Domain match); x-me-sender=none; x-ptr=pass smtp.helo=mail.citrus-it.net policy.ptr=mail.citrus-it.net; x-return-mx=pass header.domain=fiddaman.net policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-return-mx=pass smtp.domain=fiddaman.net policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=0 state=0 Authentication-Results: tb-mx0.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=pass (1024-bit rsa key sha256) header.d=fiddaman.net header.i=@fiddaman.net header.b=T/GNLFkM header.a=rsa-sha256 header.s=boomer x-bits=1024; dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=fiddaman.net; iprev=pass smtp.remote-ip=89.248.55.103 (mail.citrus-it.net); spf=pass smtp.mailfrom="prvs=1914b1f225=illumos@fiddaman.net" smtp.helo=mail.citrus-it.net; x-aligned-from=domain_pass (Domain match); x-me-sender=none; x-ptr=pass smtp.helo=mail.citrus-it.net policy.ptr=mail.citrus-it.net; x-return-mx=pass header.domain=fiddaman.net policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-return-mx=pass smtp.domain=fiddaman.net policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=0 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgeeftddrudejgdehfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukf ggtggusehttdertddttddvnecuhfhrohhmpeetnhguhicuhfhiuggurghmrghnuceoihhl lhhumhhoshesfhhiuggurghmrghnrdhnvghtqeenucggtffrrghtthgvrhhnpeetueffud eiheeuudeghfegudelhfehueehheeiieduudekjeejvdefudevhfekueenucffohhmrghi nhepihhllhhumhhoshdrohhrghenucfkphepkeelrddvgeekrdehhedruddtfedpkeelrd dvgeekrdehhedrjeelnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgv thepkeelrddvgeekrdehhedruddtfedphhgvlhhopehmrghilhdrtghithhruhhsqdhith drnhgvthdpmhgrihhlfhhrohhmpeeophhrvhhspeduledugegsudhfvddvheepihhllhhu mhhoshesfhhiuggurghmrghnrdhnvghtqedpnhgspghrtghpthhtohepuddprhgtphhtth hopeeouggvvhgvlhhophgvrheslhhishhtshdrihhllhhumhhoshdrohhrgheq X-ME-VSScore: 0 X-ME-VSCategory: clean Received-SPF: pass (fiddaman.net: 89.248.55.103 is authorized to use 'prvs=1914b1f225=illumos@fiddaman.net' in 'mfrom' identity (mechanism 'ip4:89.248.55.64/26' matched)) receiver=tb-mx0.topicbox.com; identity=mailfrom; envelope-from="prvs=1914b1f225=illumos@fiddaman.net"; helo=mail.citrus-it.net; client-ip=89.248.55.103 Received: from mail.citrus-it.net (mail.citrus-it.net [89.248.55.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx0.topicbox.com (Postfix) with ESMTPS for ; Wed, 3 Jul 2024 08:32:07 -0400 (EDT) (envelope-from prvs=1914b1f225=illumos@fiddaman.net) Authentication-Results: citrusmail; dkim=pass header.i=@fiddaman.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fiddaman.net; s=boomer; t=1720009925; bh=OXxICUPCQfHeq0CTt7b+fH8gp+zyUIkkliWz6feY0AQ=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=T/GNLFkMfeKUMC6zNkX2yzw/awLvNlHyUTizDxM4HZ+PnhXPjMu+uOYGkfNhV73Zn l6I4iZmQB5vfee9CGW9+lRV+Z/QzwdNta6IKwvu/9OetQBKQHCBD/rZhea2jkIh0rJ qLR3GsmrOUG3nwV2zg2DmetJSvNTnILzhEKe0XUU= Received: from reaper.citrus-it.net (reaper.citrus-it.net [89.248.55.79]) by mail.citrus-it.net with ESMTP id 463CW4h6011776 for ; Wed, 3 Jul 2024 12:32:05 GMT Date: Wed, 3 Jul 2024 12:32:02 +0000 From: Andy Fiddaman To: developer@lists.illumos.org Subject: Review - 16634 nvme: nvme_cq_t.ncq_tail is unused Message-ID: <20240703123202.GA4498@reaper.citrus-it.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Citrus-Version: 6.0.3ba253c X-Citrus-ID: 5463CW4h6011776 X-Citrus-Virus-Scanned: Clean X-Citrus-Spam: Whitelisted X-Citrus-Trust: Trusted Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: 464bf368-3938-11ef-8e31-5c84ff8b7b06 Please can you review the following tiny change? There is a field in the nvme cq structure which is not used and can be removed. 16634 nvme: nvme_cq_t.ncq_tail is unused https://www.illumos.org/issues/16634 https://code.illumos.org/c/illumos-gate/+/3566 Thanks, Andy