From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from tb-mx1.topicbox.com (localhost.local [127.0.0.1]) by tb-mx1.topicbox.com (Postfix) with ESMTP id D1DD82053197 for ; Thu, 22 Aug 2024 07:31:40 -0400 (EDT) (envelope-from prvs=1964c7c60a=illumos@fiddaman.net) Received: from tb-mx1.topicbox.com (localhost [127.0.0.1]) by tb-mx1.topicbox.com (Authentication Milter) with ESMTP id CE728F63998; Thu, 22 Aug 2024 07:31:40 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1724326300; b=l6DEacf9HSfGQh/JCER2IY/uiGJmqtzfQw844inwjuayo3Ssls 9E+VFF6SHKqrsD6doVv5oO6Dv+5jKUHO3jAtpX7UhoEeveg4RT+Z2r1p6TqIIE5X U1zCmq4xW6dkpvvZ5lNfGtyU3frypXgkFkQ3gtqeW/seJWp5P9bghNR2I/KGJohs 3W2ruvECK7kyJd25oMn8nV/33Apy9BYWo48aZ5BL6c2ZpL0Dm0Fp5KbRb9+Vl6PT lVsdpqPjjuV7y/zAr65r0kUE6dkllhH6WQu9qF6BcGQFOWDxRME6cd2t1xRYCGuW ChQmp95N9PdQTdIfUZdI1Pp1qJAMRw0GZDqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=date:from:to:subject:message-id:mime-version :content-type; s=arcseal; t=1724326300; bh=XExGnANnelLhaTfXtseXk JV2DJZgqJr6c06G+5MNSNM=; b=PF75jkDsSHPKo/RCTT3x0YGU8qzZubqpU+wsG LyYT3JSv7RbuAJ8eKD0rcWxXNZ1dg5T1jr9weKScv+lIR4QCtgQHWZU+l4/KPp9E O77UqyXYFZfte8OVuPTBag3/r30VJ14jncO0jGFZD1CuQKle7h3JesX94UTkYCMO FkctnQ+jvlBEmkReSTrzr6S6bz/eQ7jgHacDFBjbfxCveBWXj37+A18oTrG3FQ+9 OSM86Vh1lwSOq3OscA+a+jghdz//8Alx0zjqDAruFM09BaBwnr9xYJf2GKdoZmGQ 3SIDEn7JUZ+VKV1dXYES/7HU/M7Plz7DtZqM7M9EeKPF5wV/g== ARC-Authentication-Results: i=1; tb-mx1.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=pass (1024-bit rsa key sha256) header.d=fiddaman.net header.i=@fiddaman.net header.b=bMSI7XoY header.a=rsa-sha256 header.s=boomer x-bits=1024; dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=fiddaman.net; iprev=pass smtp.remote-ip=89.248.55.103 (mail.citrus-it.net); spf=pass smtp.mailfrom="prvs=1964c7c60a=illumos@fiddaman.net" smtp.helo=mail.citrus-it.net; x-aligned-from=domain_pass (Domain match); x-me-sender=none; x-ptr=pass smtp.helo=mail.citrus-it.net policy.ptr=mail.citrus-it.net; x-return-mx=pass header.domain=fiddaman.net policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-return-mx=pass smtp.domain=fiddaman.net policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=0 state=0 Authentication-Results: tb-mx1.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=pass (1024-bit rsa key sha256) header.d=fiddaman.net header.i=@fiddaman.net header.b=bMSI7XoY header.a=rsa-sha256 header.s=boomer x-bits=1024; dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=fiddaman.net; iprev=pass smtp.remote-ip=89.248.55.103 (mail.citrus-it.net); spf=pass smtp.mailfrom="prvs=1964c7c60a=illumos@fiddaman.net" smtp.helo=mail.citrus-it.net; x-aligned-from=domain_pass (Domain match); x-me-sender=none; x-ptr=pass smtp.helo=mail.citrus-it.net policy.ptr=mail.citrus-it.net; x-return-mx=pass header.domain=fiddaman.net policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-return-mx=pass smtp.domain=fiddaman.net policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=0 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgeeftddruddvtddggedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuf fkgggtugesthdtredttddtvdenucfhrhhomheptehnugihucfhihguuggrmhgrnhcuoehi lhhluhhmohhssehfihguuggrmhgrnhdrnhgvtheqnecuggftrfgrthhtvghrnhepteduud elffeuvefhgeehleefudekiefgieffkeelieekvdekteeuueekuefgkeevnecuffhomhgr ihhnpehgihhthhhusgdrtghomhdpihhllhhumhhoshdrohhrghenucfkphepkeelrddvge ekrdehhedruddtfedpkeelrddvgeekrdehhedrjeelnecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehinhgvthepkeelrddvgeekrdehhedruddtfedphhgvlhhopehmrg hilhdrtghithhruhhsqdhithdrnhgvthdpmhgrihhlfhhrohhmpeeophhrvhhspeduleei gegtjegtiedtrgepihhllhhumhhoshesfhhiuggurghmrghnrdhnvghtqedpnhgspghrtg hpthhtohepuddprhgtphhtthhopeeouggvvhgvlhhophgvrheslhhishhtshdrihhllhhu mhhoshdrohhrgheq X-ME-VSScore: 0 X-ME-VSCategory: clean Received-SPF: pass (fiddaman.net: 89.248.55.103 is authorized to use 'prvs=1964c7c60a=illumos@fiddaman.net' in 'mfrom' identity (mechanism 'ip4:89.248.55.64/26' matched)) receiver=tb-mx1.topicbox.com; identity=mailfrom; envelope-from="prvs=1964c7c60a=illumos@fiddaman.net"; helo=mail.citrus-it.net; client-ip=89.248.55.103 Received: from mail.citrus-it.net (mail.citrus-it.net [89.248.55.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx1.topicbox.com (Postfix) with ESMTPS for ; Thu, 22 Aug 2024 07:31:40 -0400 (EDT) (envelope-from prvs=1964c7c60a=illumos@fiddaman.net) Authentication-Results: citrusmail; dkim=pass header.i=@fiddaman.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fiddaman.net; s=boomer; t=1724326299; bh=cSEI7M0uiwYi7I7/X5XNRSmWv9iATu43Q9kXvT0Emcc=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=bMSI7XoYOeiIIkhivIpeuVrl4CdarBqh2/8GxfT+sZ48w6aszx8M3IVJqgOmiDlIM fWPCy8MRIAknKs1Zxo4bi5W0Ne7xJ8tDQedcPSPJssAtqqO55YwzCu/tZh3bx3q1eO cy7zgDKjR3fMAZOxUPWXHl2NoJdlnBO2a64lCZ9I= Received: from reaper.citrus-it.net (reaper.citrus-it.net [89.248.55.79]) by mail.citrus-it.net with ESMTP id 47MBVdr5017974 for ; Thu, 22 Aug 2024 11:31:39 GMT Date: Thu, 22 Aug 2024 11:31:38 +0000 From: Andy Fiddaman To: developer@lists.illumos.org Subject: Review - 16718 Want mechanism to select smrt over cpqary3 Message-ID: <20240822113138.GA10575@reaper.citrus-it.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Citrus-Version: 6.0.3ba253c X-Citrus-ID: 547MBVdr5017974 X-Citrus-Virus-Scanned: Clean X-Citrus-Spam: Whitelisted X-Citrus-Trust: Trusted Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: 1c766b2c-607a-11ef-a107-9af33791bd1a When the `smrt` driver was introduced, it was done so without defining any PCI aliases to which it should attach since there is an overlap between it and the extant `cpqary3`, and there is an obvious complication of changing device paths on a running system which may have a root pool on a device using one of these drivers. Over the past five years, SmartOS has been assigning `smrt` to a range of newer devices. Since the pools are imported fresh on each boot, this works fine. https://github.com/TritonDataCenter/illumos-joyent/blob/93ed51f2345b1342f4659875b79cf853d1078f0a/usr/src/uts/intel/os/driver_aliases#L1589-L1625 I've raised the following change that allows systems which use IPS to easily switch the overlapping aliases back and forth between the two drivers via a new IPS variant. To make this seamless, I'm using a boolean variant and so this depends on an IPS feature which was introduced in Oracle's IPS in 2016, OpenIndiana's in 2019 and OmniOS' in 2023. Helios does not yet have this but I am going to take care of that prior to integration, as well as send out a heads-up for any other IPS-using distributions to check/update. 23254680 'false' should be assumed for unknown variants https://github.com/oracle/solaris-ips/commit/b9f932cb82 In OmniOS we will start building installation media with the variant set to true so that new installations use smrt for compatible devices. With all that said, please can you review the following change? I've put initial testing notes in the issue. 16718 Want mechanism to select smrt over cpqary3 https://www.illumos.org/issues/16718 https://code.illumos.org/c/illumos-gate/+/3648 Thanks, Andy