From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from tb-mx0.topicbox.com (localhost.local [127.0.0.1]) by tb-mx0.topicbox.com (Postfix) with ESMTP id BDEFB19DF2B4 for ; Fri, 24 May 2024 07:04:26 -0400 (EDT) (envelope-from tsoome@me.com) Received: from tb-mx0.topicbox.com (localhost [127.0.0.1]) by tb-mx0.topicbox.com (Authentication Milter) with ESMTP id 76443A6C94D; Fri, 24 May 2024 07:04:26 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1716548666; b=mznXR8vlcbNvp6QLxE9AU4Z3xSCoPZc8/sT/pf2U3MtfXBq3G9 NkjYz8RsZmJFK/pKkBBiCdsvNEyzBA8DGBXP8g5n1HTRulKgQYeOHzNGc9ZhS4vm 7+iI9oBVj5bOJr6MD9L3vJxL/uBzQPfRkmIidSDziu5ykoV6voYZLPL4m6+HqMeI aASM5jvsja4WeKudbe8jfc/qdYtuAhnjjG93nIKe/U9UQm99GfIPAkwDXz4AGFlb bTxW7oUpT2RZ+RzaPDzwcxZbNanBt83jJnP4qe8mAAybUJg4hGC8TVRgi1BB3jJs EC+4uUcjeY/QaLl8Z72Uytb26DhkNFWFvR1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=from:content-type:mime-version:subject:date :references:to:in-reply-to:message-id; s=arcseal; t=1716548666; bh=qqaEk5kbiZIt73J5U0td465FbkIAJ/xLH1BbgVaOkGw=; b=L2Wbbu9CmsxO jdVf8AjZZzL8nlGvAXDhBmcsKdzklr6yPKdmzerSDgud7fKlLrp+LkneRpYmzcrH bagigufjZ0+wHHVa8ipDi3z7dtTRYPqXCLfQ23z6HUtcH6EEecSvLWR/YvM2xho1 +iGJkIO1bYmXgx6nVSRQdDc877mXrWUYyMWKAwOuetg7ejikpKRJih2KPVHzKZrc fDf4WrWegslw5FXYbsBtQL6ePQ/pj7Y78YEyIH+PJd3sPdsHasdHKbd4lxQE0eNa CbAyJNRqPWfsTUC69msanX1EmGYmUWL5wdcsyr9OsHTig5uvnpB+frmibDVUoSlD +hLMTwXC7w== ARC-Authentication-Results: i=1; tb-mx0.topicbox.com; arc=none (no signatures found); bimi=declined (Domain declined to participate); dkim=pass (2048-bit rsa key sha256) header.d=me.com header.i=@me.com header.b=0cq6kYyZ header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=me.com; iprev=pass smtp.remote-ip=17.58.6.46 (pv50p00im-zteg10021301.me.com); spf=pass smtp.mailfrom=tsoome@me.com smtp.helo=pv50p00im-zteg10021301.me.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=pv50p00im-zteg10021301.me.com policy.ptr=pv50p00im-zteg10021301.me.com; x-return-mx=pass header.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-return-mx=pass smtp.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 Authentication-Results: tb-mx0.topicbox.com; arc=none (no signatures found); bimi=declined (Domain declined to participate); dkim=pass (2048-bit rsa key sha256) header.d=me.com header.i=@me.com header.b=0cq6kYyZ header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=me.com; iprev=pass smtp.remote-ip=17.58.6.46 (pv50p00im-zteg10021301.me.com); spf=pass smtp.mailfrom=tsoome@me.com smtp.helo=pv50p00im-zteg10021301.me.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=pv50p00im-zteg10021301.me.com policy.ptr=pv50p00im-zteg10021301.me.com; x-return-mx=pass header.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-return-mx=pass smtp.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgedvledrvdeikedgfeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephfgtggfuffhfvfgjkffosegrtdhmrehhtdejnecu hfhrohhmpefvohhomhgrshcuufhoohhmvgcuoehtshhoohhmvgesmhgvrdgtohhmqeenuc ggtffrrghtthgvrhhnpeffvddthfduudfhtddutddtudduuedvudeljeegfffhgfeffeeh veefudfgkedtveenucffohhmrghinhepihhllhhumhhoshdrohhrghenucfkphepudejrd ehkedriedrgeeipddujedrheeirdelrddutdenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepihhnvghtpedujedrheekrdeirdegiedphhgvlhhopehpvhehtdhptddtih hmqdiithgvghdutddtvddufedtuddrmhgvrdgtohhmpdhmrghilhhfrhhomhepoehtshho ohhmvgesmhgvrdgtohhmqedpnhgspghrtghpthhtohepuddprhgtphhtthhopeeouggvvh gvlhhophgvrheslhhishhtshdrihhllhhumhhoshdrohhrgheq X-ME-VSScore: -100 X-ME-VSCategory: clean Received-SPF: pass (me.com: 17.58.6.46 is authorized to use 'tsoome@me.com' in 'mfrom' identity (mechanism 'ip4:17.58.0.0/16' matched)) receiver=tb-mx0.topicbox.com; identity=mailfrom; envelope-from="tsoome@me.com"; helo=pv50p00im-zteg10021301.me.com; client-ip=17.58.6.46 Received: from pv50p00im-zteg10021301.me.com (pv50p00im-zteg10021301.me.com [17.58.6.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx0.topicbox.com (Postfix) with ESMTPS for ; Fri, 24 May 2024 07:04:26 -0400 (EDT) (envelope-from tsoome@me.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1716548665; bh=qqaEk5kbiZIt73J5U0td465FbkIAJ/xLH1BbgVaOkGw=; h=From:Content-Type:Mime-Version:Subject:Date:To:Message-Id; b=0cq6kYyZwSpgYzr3STj6D/OYDjNpuOwToAeEGLpP9m3UA4p4P2VKJGFYvlS+iBFPe +1xdji98J/Z5XC04JiC668qcNoiMwz2lrFsQ7rNUJEtwPJMXcDJplN4mPOOlVlcqhe KYCqwRzHnD07mMMLc3BXI3W91W+gyoN0DLVi3F72Y4j4ow3sy2GTN7sB1op8YAKAwn aWpRO0Oicvem7+Jhw9UN672iTqgAIC8uPNoRw01Yxkfcsui7J6zLMXmrJ7buljPRxw H4lApu5rE7xewDnJB8GyZC1mcDgdbGImijM/dXEj7dEYVEhZfGQvcunjCLsnpIRcXN V6U24HBaXOttw== Received: from smtpclient.apple (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-zteg10021301.me.com (Postfix) with ESMTPSA id 26DDF50015A for ; Fri, 24 May 2024 11:04:23 +0000 (UTC) From: Toomas Soome Content-Type: multipart/alternative; boundary="Apple-Mail=_D9691622-9CE1-4CFF-A709-246CA7304869" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Subject: Re: REVIEW: 15685 iscsi: the comparison will always evaluate as 'true' Date: Fri, 24 May 2024 14:04:09 +0300 References: <426E955B-B7F4-4091-AC30-513396470C0E@me.com> To: illumos-developer In-Reply-To: <426E955B-B7F4-4091-AC30-513396470C0E@me.com> Message-Id: <241B76EB-8E0F-4E1E-B7F2-C685AAE7B67D@me.com> X-Mailer: Apple Mail (2.3774.600.62) X-Proofpoint-ORIG-GUID: cFcrXflptCk0BX6WCfStO5C3-wlFhL4v X-Proofpoint-GUID: cFcrXflptCk0BX6WCfStO5C3-wlFhL4v X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16 definitions=2024-05-24_04,2024-05-23_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=701 adultscore=0 malwarescore=0 mlxscore=0 clxscore=1015 bulkscore=0 suspectscore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2405240077 Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: 6592a4c8-19bd-11ef-9c37-725dfe8b7b06 --Apple-Mail=_D9691622-9CE1-4CFF-A709-246CA7304869 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Ping? thanks, toomas > On 23. May 2023, at 14:53, Toomas Soome wrote: >=20 > Hi! >=20 > Please review: https://code.illumos.org/c/illumos-gate/+/2875 >=20 > bunch of never-NULL string pointers are used in if statements=E2=80=A6 >=20 > thanks, > toomas --Apple-Mail=_D9691622-9CE1-4CFF-A709-246CA7304869 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Ping?

thanks,
toomas

On 23. May 2023, at 14:53, Toomas Soome = <tsoome@me.com> wrote:

Hi!

Please review: https://code.illumos.org/c/illumos-gate/+/2875

bunch of never-NULL = string pointers are used in if = statements=E2=80=A6

thanks,
toomas

= = --Apple-Mail=_D9691622-9CE1-4CFF-A709-246CA7304869--