From: Robert Mustacchi <rm@fingolfin.org>
To: illumos-developer <developer@lists.illumos.org>
Subject: Re: [developer] 16777 dladm show-vnic, vlan, and etherstub class confusion
Date: Sun, 22 Sep 2024 17:27:00 -0700 [thread overview]
Message-ID: <2b1ec972-9465-4887-b050-e8ea02d686ac@fingolfin.org> (raw)
In-Reply-To: <53e4d1f8-74a9-4e3d-bac3-fe79c2966b94@fingolfin.org>
Sorry, this went to the wrong list, please ignore this.
On 9/22/24 17:24, Robert Mustacchi wrote:
> Hi there,
>
> I'd like to integrate this change to dladm to fix up some confusing
> beahvior int he show-vnic, show-vlan, and show-etherstub department. I
> have testing notes in the ticket with a new test suite addition around
> this and Dan McDonald helped regression test this in some broader cases
> through Triton. Please let me know if you have any questions or if
> there's anything else I can provide.
>
> Robert
>
> whatchanged:
> commit 05a95a75b53b43920de2733e3f7f38cceb4e9f1d (HEAD -> upstream)
> Author: Robert Mustacchi <rm@fingolfin.org>
> Date: Thu Sep 5 03:03:32 2024 +0000
>
> 16777 dladm show-vnic, vlan, and etherstub class confusion
> 16776 dladm warning functions should use printf attributes
> Reviewed by: Toomas Soome <tsoome@me.com>
> Reviewed by: Andy Fiddaman <illumos@fiddaman.net>
> Reviewed by: ixi meow <illumos@iximeow.net>
>
> :100644 100644 aea1c826a0 c4f97bdb48 M usr/src/cmd/dladm/dladm.c
> :100644 100644 c68f9197ab 5d3e22e55d M
> usr/src/pkg/manifests/system-test-utiltest.p5m
> :100644 100644 e0f38c758e 7b30173575 M
> usr/src/test/util-tests/runfiles/default.run
> :100644 100644 50ef1b876a 56282af813 M
> usr/src/test/util-tests/tests/dladm/Makefile
> :000000 100644 0000000000 22271091e8 A
> usr/src/test/util-tests/tests/dladm/show-class-confusion.ksh
>
> pbchk:
> Copyrights:
> test/util-tests/runfiles/default.run: no copyright claim for current
> year found
> test/util-tests/tests/dladm/Makefile: no copyright claim for current
> year found
>
> https://www.illumos.org/issues/16776
> https://www.illumos.org/issues/16777
> https://code.illumos.org/c/illumos-gate/+/3687
> mail_msg attached
------------------------------------------
illumos: illumos-developer
Permalink: https://illumos.topicbox.com/groups/developer/T824390bc2066367f-M054cff277827e4024b02f264
Delivery options: https://illumos.topicbox.com/groups/developer/subscription
prev parent reply other threads:[~2024-09-23 0:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 0:24 Robert Mustacchi
2024-09-23 0:27 ` Robert Mustacchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b1ec972-9465-4887-b050-e8ea02d686ac@fingolfin.org \
--to=rm@fingolfin.org \
--cc=developer@lists.illumos.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).