public inbox for developer@lists.illumos.org (since 2011-08)
 help / color / mirror / Atom feed
* [developer] 16777 dladm show-vnic, vlan, and etherstub class confusion
@ 2024-09-23  0:24 Robert Mustacchi
  2024-09-23  0:27 ` Robert Mustacchi
  0 siblings, 1 reply; 2+ messages in thread
From: Robert Mustacchi @ 2024-09-23  0:24 UTC (permalink / raw)
  To: illumos-developer

[-- Attachment #1: Type: text/plain, Size: 1879 bytes --]

Hi there,

I'd like to integrate this change to dladm to fix up some confusing
beahvior int he show-vnic, show-vlan, and show-etherstub department. I
have testing notes in the ticket with a new test suite addition around
this and Dan McDonald helped regression test this in some broader cases
through Triton. Please let me know if you have any questions or if
there's anything else I can provide.

Robert

whatchanged:
commit 05a95a75b53b43920de2733e3f7f38cceb4e9f1d (HEAD -> upstream)
Author: Robert Mustacchi <rm@fingolfin.org>
Date:   Thu Sep 5 03:03:32 2024 +0000

    16777 dladm show-vnic, vlan, and etherstub class confusion
    16776 dladm warning functions should use printf attributes
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Andy Fiddaman <illumos@fiddaman.net>
    Reviewed by: ixi meow <illumos@iximeow.net>

:100644 100644 aea1c826a0 c4f97bdb48 M  usr/src/cmd/dladm/dladm.c
:100644 100644 c68f9197ab 5d3e22e55d M
usr/src/pkg/manifests/system-test-utiltest.p5m
:100644 100644 e0f38c758e 7b30173575 M
usr/src/test/util-tests/runfiles/default.run
:100644 100644 50ef1b876a 56282af813 M
usr/src/test/util-tests/tests/dladm/Makefile
:000000 100644 0000000000 22271091e8 A
usr/src/test/util-tests/tests/dladm/show-class-confusion.ksh

pbchk:
Copyrights:
test/util-tests/runfiles/default.run: no copyright claim for current
year found
test/util-tests/tests/dladm/Makefile: no copyright claim for current
year found

https://www.illumos.org/issues/16776
https://www.illumos.org/issues/16777
https://code.illumos.org/c/illumos-gate/+/3687
mail_msg attached
------------------------------------------
illumos: illumos-developer
Permalink: https://illumos.topicbox.com/groups/developer/T824390bc2066367f-M13b0495d2b0f3d6d9fd0f851
Delivery options: https://illumos.topicbox.com/groups/developer/subscription

[-- Attachment #2: mail_msg --]
[-- Type: text/plain, Size: 4516 bytes --]


==== Nightly distributed build started:   Sun Sep 22 19:45:34 UTC 2024 ====
==== Nightly distributed build completed: Sun Sep 22 20:16:18 UTC 2024 ====

==== Total build time ====

real    0:30:43

==== Build environment ====

/usr/bin/uname
SunOS atrium 5.11 helios-2.0.22827 i86pc i386 i86pc

/opt/onbld/bin/i386/dmake
dmake: illumos make
number of concurrent jobs = 48

cw version 9.1
primary: /opt/gcc-10/bin/gcc
gcc (Helios 2/10.4.0-il-1) 10.4.0
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

shadow: /opt/gcc-7/bin/gcc
gcc (Helios 2/7.5.0-il-2) 7.5.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

shadow: /home/rm/src/vnic/projects/illumos/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/smatch
0.6.1-rc1-il-7

/usr/jdk/openjdk11.0/bin/javac
openjdk full version "11.0.21+9-helios-2"

/usr/bin/openssl
OpenSSL 3.0.14 4 Jun 2024 (Library: OpenSSL 3.0.14 4 Jun 2024)

/usr/ccs/bin/ld
ld: Software Generation Utilities - Solaris Link Editors: 5.11-1.1790 (illumos)

Build project:  group.staff
Build taskid:   1351

==== Nightly argument issues ====


==== Make clobber ERRORS ====


==== Make tools clobber ERRORS ====


==== Build version ====

upstream-0-g05a95a75b5

==== Bootstrap build errors ====


==== Tools build errors ====


==== Build errors (non-DEBUG) ====


==== Build warnings (non-DEBUG) ====


==== Elapsed build time (non-DEBUG) ====

real    14:03.6
user  3:22:16.7
sys   1:05:13.8

==== Build noise differences (non-DEBUG) ====


==== package build errors (non-DEBUG) ====


==== Build errors (DEBUG) ====


==== Build warnings (DEBUG) ====


==== Elapsed build time (DEBUG) ====

real     8:56.5
user  3:01:05.3
sys   1:01:30.9

==== Build noise differences (DEBUG) ====


==== package build errors (DEBUG) ====


==== Linting packages ====


==== Validating manifests against proto area ====


==== Check versioning and ABI information ====


==== Check ELF runtime attributes ====


==== Diff ELF runtime attributes (since last build) ====

16474a16475,16480
> opt/nvme-tests/tests/libnvme/pev.32: NEEDED=libc.so.1
> opt/nvme-tests/tests/libnvme/pev.32: NEEDED=libnvme.so.1
> opt/nvme-tests/tests/libnvme/pev.32: RPATH=/usr/gcc/10/lib
> opt/nvme-tests/tests/libnvme/pev.64: NEEDED=libc.so.1
> opt/nvme-tests/tests/libnvme/pev.64: NEEDED=libnvme.so.1
> opt/nvme-tests/tests/libnvme/pev.64: RPATH=/usr/gcc/10/lib/amd64
16716a16723,16728
> opt/os-tests/tests/sockfs/timeouts.32: NEEDED=libc.so.1
> opt/os-tests/tests/sockfs/timeouts.32: NEEDED=libsocket.so.1
> opt/os-tests/tests/sockfs/timeouts.32: RPATH=/usr/gcc/10/lib
> opt/os-tests/tests/sockfs/timeouts.64: NEEDED=libc.so.1
> opt/os-tests/tests/sockfs/timeouts.64: NEEDED=libsocket.so.1
> opt/os-tests/tests/sockfs/timeouts.64: RPATH=/usr/gcc/10/lib/amd64
16975a16988,16995
> opt/util-tests/tests/libjedec_hex2spd.32: NEEDED=libc.so.1
> opt/util-tests/tests/libjedec_hex2spd.32: NEEDED=libjedec.so.1
> opt/util-tests/tests/libjedec_hex2spd.32: NEEDED=libnvpair.so.1
> opt/util-tests/tests/libjedec_hex2spd.32: RPATH=/usr/gcc/10/lib
> opt/util-tests/tests/libjedec_hex2spd.64: NEEDED=libc.so.1
> opt/util-tests/tests/libjedec_hex2spd.64: NEEDED=libjedec.so.1
> opt/util-tests/tests/libjedec_hex2spd.64: NEEDED=libnvpair.so.1
> opt/util-tests/tests/libjedec_hex2spd.64: RPATH=/usr/gcc/10/lib/amd64
16990,16995c17010,17015
< opt/util-tests/tests/libjedec_test.32: NEEDED=libc.so.1
< opt/util-tests/tests/libjedec_test.32: NEEDED=libjedec.so.1
< opt/util-tests/tests/libjedec_test.32: RPATH=/usr/gcc/10/lib
< opt/util-tests/tests/libjedec_test.64: NEEDED=libc.so.1
< opt/util-tests/tests/libjedec_test.64: NEEDED=libjedec.so.1
< opt/util-tests/tests/libjedec_test.64: RPATH=/usr/gcc/10/lib/amd64
---
> opt/util-tests/tests/libjedec_vendors.32: NEEDED=libc.so.1
> opt/util-tests/tests/libjedec_vendors.32: NEEDED=libjedec.so.1
> opt/util-tests/tests/libjedec_vendors.32: RPATH=/usr/gcc/10/lib
> opt/util-tests/tests/libjedec_vendors.64: NEEDED=libc.so.1
> opt/util-tests/tests/libjedec_vendors.64: NEEDED=libjedec.so.1
> opt/util-tests/tests/libjedec_vendors.64: RPATH=/usr/gcc/10/lib/amd64

==== cstyle/hdrchk errors ====


==== Find core files ====


==== Check lists of files ====


==== Impact on file permissions ====


^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-23  0:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-23  0:24 [developer] 16777 dladm show-vnic, vlan, and etherstub class confusion Robert Mustacchi
2024-09-23  0:27 ` Robert Mustacchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).