From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4 Received: from tb-ob1.topicbox.com (tb-ob1.topicbox.com [64.147.108.173]) by inbox.vuxu.org (Postfix) with ESMTP id 45E8625EA8 for ; Tue, 12 Nov 2024 07:21:42 +0100 (CET) Received: from tb-mx0.topicbox.com (tb-mx0.nyi.icgroup.com [10.90.30.73]) by tb-ob1.topicbox.com (Postfix) with ESMTP id 67A3919EBF for ; Tue, 12 Nov 2024 01:21:41 -0500 (EST) (envelope-from bounce.mMc08c98af25e077799cc2d612.r81958daa-7202-11ef-bbf2-18142b2d11b0@illumos.bounce.topicbox.com) Received: by tb-mx0.topicbox.com (Postfix, from userid 1132) id 65745266B38; Tue, 12 Nov 2024 01:21:41 -0500 (EST) ARC-Authentication-Results: i=2; topicbox.com; arc=pass; dkim=pass (2048-bit rsa key sha256) header.d=icloud.com header.i=@icloud.com header.b=L238mwxw header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=icloud.com; spf=pass smtp.mailfrom=gusev.vitaliy@icloud.com smtp.helo=pv50p00im-tydg10011801.me.com; x-internal-arc=fail (as.1.topicbox.com=pass, ams.1.topicbox.com=fail (message has been altered)) (Message modified while forwarding at Topicbox) ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=content-type:mime-version:subject:date :references:to:in-reply-to:message-id:list-help:list-id :list-post:list-subscribe:reply-to:content-transfer-encoding :from:list-unsubscribe; s=sysmsg-1; t=1731392501; bh=F5gb5IQoYwU /2zcynavmsMQnkvj9bqRmroY1PAn+jpg=; b=Qs7H3XsLIUlgYumi18BwIBWQ2OM SzGJMIYznp0bCHcqEbVOcbQAT22E8MZSAMK9WGFdYo+reL2L+jSCKdBphZnn6MiP kirIHeCZwABEUo2fHJHj9PkxcBpq234aRbu1OVKHbYjrSniM3j6mykZGcQYM7BVX 4Ap/lgNTF3lomlaE= ARC-Seal: i=2; a=rsa-sha256; cv=pass; d=topicbox.com; s=sysmsg-1; t= 1731392501; b=SO6X3Ex7/myT7ilaWzp/xfsN89xfWdPN0exX8mWlXASLsfQ6EF m54kLv2DnyH4JQzxlFM4jLabS12U9YFVIVWDKk+INUMKWxYq71ytUzhgsph5sLZ1 h6Aqu8q7po/Xh7Ou/uLfr8U7d41hKz3awto/V/xqrn9OMOcZu6F/DoPyY= Authentication-Results: topicbox.com; arc=pass; dkim=pass (2048-bit rsa key sha256) header.d=icloud.com header.i=@icloud.com header.b=L238mwxw header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=icloud.com; spf=pass smtp.mailfrom=gusev.vitaliy@icloud.com smtp.helo=pv50p00im-tydg10011801.me.com; x-internal-arc=fail (as.1.topicbox.com=pass, ams.1.topicbox.com=fail (message has been altered)) (Message modified while forwarding at Topicbox) X-Received-Authentication-Results: tb-mx1.topicbox.com; arc=none (no signatures found); bimi=declined (Domain declined to participate); dkim=pass (2048-bit rsa key sha256) header.d=icloud.com header.i=@icloud.com header.b=L238mwxw header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=icloud.com; iprev=pass smtp.remote-ip=17.58.6.52 (pv50p00im-tydg10011801.me.com); spf=pass smtp.mailfrom=gusev.vitaliy@icloud.com smtp.helo=pv50p00im-tydg10011801.me.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=pv50p00im-tydg10011801.me.com policy.ptr=pv50p00im-tydg10011801.me.com; x-return-mx=pass header.domain=icloud.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-return-mx=pass smtp.domain=icloud.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lists.illumos.org; h= content-type:mime-version:subject:date:references:to:in-reply-to :message-id:list-help:list-id:list-post:list-subscribe:reply-to :content-transfer-encoding:from:list-unsubscribe; s=dkim-1; t= 1731392501; x=1731478901; bh=X/CYFib2TbBdfY7VAcREczJUpCsw5OKx8DP PdY2Yr1w=; b=oud47jlkx0ie5mKCtggfOqIF93hy/9wU5J/48uRa50GYJuivtiX roiaOk6mUymMdY+2OdTAaPKm90FDzfEufNT4v+J003kgbiUPfsg/V+APw1JYZh4h CzxAMJvdRZSPNk0PPoIwQYRWD88UiTV4Rq8eLwpoOzcRDXCglGcwRYoE= Received: from tb-mx1.topicbox.com (localhost.local [127.0.0.1]) by tb-mx1.topicbox.com (Postfix) with ESMTP id 1B22F275A70 for ; Tue, 12 Nov 2024 01:18:54 -0500 (EST) (envelope-from gusev.vitaliy@icloud.com) Received: from tb-mx1.topicbox.com (localhost [127.0.0.1]) by tb-mx1.topicbox.com (Authentication Milter) with ESMTP id DF6684F22D7; Tue, 12 Nov 2024 01:18:53 -0500 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1731392333; b=t9xlnmZC5rYIT0GD+0l6b/OEi7LHPrm0+EbZEjultrq3crnapu xDQ0g3LEzdZ1UV5gyXhsOuLIiKbRr8kmxLspLAHzmDqvfqPgX88DYermkJf3PsJV tvPI4c0oRVjI7qMzH3gAW+GxhPjHi84AjZUJWn3iPc2zE/JzTFhuv8mWHmW1JL5/ KBA5eWXoeL8srJ7dlVc2KzrcNUqr4q6Aq1iDU4roSI5WXhDBzJ7gnhfV79Nwnmed isnbT0Ma/46+eLFpAjT55IyhY14xdEEB3F1Y8BUs2Gho3CtzIXbjkbKUc6+UBsIL YY5a7gpMVfQDtaH42k/S9tnTDKqeJpcWOGxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=from:content-type:mime-version:subject:date :references:to:in-reply-to:message-id; s=arcseal; t=1731392333; bh=PxaYysUF0aY5YkySq1m7wBMYdy+ET1jN/REtAss4NOc=; b=Q3biLZGtrBF5 NjeibbZrPDJTprVMKYdxss7PaNi6pGRoEBIB/mDfECkU6zk6+22+PKQVDJ7qfnIG bwij5Zdw/ALGVKcM6JOKpr3jW+NxAkhDD93GCdjm4ZVGp/UNR5m2dJEZbG8CZRVf yVS9gQwofIjW0oahyh+exBOheDgpzo7FGJ9AErpeJr4aUnViODJZLf0k6WIUMpHh nlJN3RdGE2lFYgfHn5YN0mhNBqG47tk47O9rOO4s92CZTlvwQqrEmk+7ywFYO+9J dy4EALbaQiPZ2iYaQzq3NKupX42PoNHt2mI+5TvSkF/gOpblnckABP/vP5ZF0yP3 T8qVQzoEEA== ARC-Authentication-Results: i=1; tb-mx1.topicbox.com; arc=none (no signatures found); bimi=declined (Domain declined to participate); dkim=pass (2048-bit rsa key sha256) header.d=icloud.com header.i=@icloud.com header.b=L238mwxw header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=icloud.com; iprev=pass smtp.remote-ip=17.58.6.52 (pv50p00im-tydg10011801.me.com); spf=pass smtp.mailfrom=gusev.vitaliy@icloud.com smtp.helo=pv50p00im-tydg10011801.me.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=pv50p00im-tydg10011801.me.com policy.ptr=pv50p00im-tydg10011801.me.com; x-return-mx=pass header.domain=icloud.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-return-mx=pass smtp.domain=icloud.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgeefuddrudefgdelfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpefhtggguffffhfvjgfkofesrgdtmherhhdtjeenucfh rhhomhepghhushgvvhdrvhhithgrlhhihiesihgtlhhouhgurdgtohhmnecuggftrfgrth htvghrnhepledtfeekleeludelueejtdeuveeujeegtdekgfffffevteeiheelkeelhfeu veeknecuffhomhgrihhnpehgihhthhhusgdrtghomhdpthhophhitggsohigrdgtohhmne cukfhppedujedrheekrdeirdehvddpudejrdehiedrledruddtnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehinhgvthepudejrdehkedriedrhedvpdhhvghlohepph hvhedtphdttdhimhdqthihughguddttdduudektddurdhmvgdrtghomhdpmhgrihhlfhhr ohhmpeeoghhushgvvhdrvhhithgrlhhihiesihgtlhhouhgurdgtohhmqedpnhgspghrtg hpthhtohepuddprhgtphhtthhopeeouggvvhgvlhhophgvrheslhhishhtshdrihhllhhu mhhoshdrohhrgheq X-ME-VSScore: -100 X-ME-VSCategory: clean Received-SPF: pass (icloud.com: 17.58.6.52 is authorized to use 'gusev.vitaliy@icloud.com' in 'mfrom' identity (mechanism 'ip4:17.58.0.0/16' matched)) receiver=tb-mx1.topicbox.com; identity=mailfrom; envelope-from="gusev.vitaliy@icloud.com"; helo=pv50p00im-tydg10011801.me.com; client-ip=17.58.6.52 Received: from pv50p00im-tydg10011801.me.com (pv50p00im-tydg10011801.me.com [17.58.6.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx1.topicbox.com (Postfix) with ESMTPS for ; Tue, 12 Nov 2024 01:18:53 -0500 (EST) (envelope-from gusev.vitaliy@icloud.com) Received: from smtpclient.apple (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-tydg10011801.me.com (Postfix) with ESMTPSA id 57CF18000C6; Tue, 12 Nov 2024 06:18:48 +0000 (UTC) Content-Type: multipart/alternative; boundary="Apple-Mail=_CE4150A3-872C-480C-867F-84D8663E5BE7" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: [developer] Panic during pkg update Date: Tue, 12 Nov 2024 09:18:25 +0300 References: <17219899-949B-417B-8226-B3BC012C9EA4@me.com> <3959AC6D-6D8E-4139-A107-7809AB79B12B@icloud.com> To: illumos-developer , Tom Caputi In-Reply-To: <3959AC6D-6D8E-4139-A107-7809AB79B12B@icloud.com> Message-Id: <3459173C-4C67-4F32-BDFF-27005E54922D@icloud.com> X-Mailer: Apple Mail (2.3776.700.51) X-Proofpoint-GUID: GLGJPKGey7yXXsDcSL-GaBUJM52fqQQf X-Proofpoint-ORIG-GUID: GLGJPKGey7yXXsDcSL-GaBUJM52fqQQf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-11-11_08,2024-11-08_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 clxscore=1015 adultscore=0 spamscore=0 mlxscore=0 phishscore=0 suspectscore=0 bulkscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2411120050 Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: 13a09412-a0be-11ef-92ad-94f5957e2e25 Archived-At: =?UTF-8?B?PGh0dHBzOi8vaWxsdW1vcy50b3BpY2JveC5jb20vZ3JvdXBz?= =?UTF-8?B?L2RldmVsb3Blci9UZTExNTNjN2FhYTNlMDVjNy1NYzA4Yzk4YWYyNWUwNzc3?= =?UTF-8?B?OTljYzJkNjEyPg==?= List-Help: List-Id: "illumos-developer" List-Post: List-Software: Topicbox v0 List-Subscribe: Precedence: list Reply-To: illumos-developer Content-Transfer-Encoding: 7bit From: "gusev.vitaliy via illumos-developer" List-Unsubscribe: , Topicbox-Delivery-ID: 2:illumos:a901537c-2aea-11e7-965f-d98f9f16e227:81958daa-7202-11ef-bbf2-18142b2d11b0:Mc08c98af25e077799cc2d612:1:eguhAEQWuF3_Dfmrcd8U2rvWsytLPUl-FIoAfW7KeG0 --Apple-Mail=_CE4150A3-872C-480C-867F-84D8663E5BE7 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 > On 12 Nov 2024, at 00:11, gusev.vitaliy via illumos-developer wrote: >=20 > Panic comes from this function: >=20 > usr/src/uts/common/fs/zfs/arc.c >=20 > 5369 /*=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 > 5370 * XXX this should be changed to return an error, and callers=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20 > 5371 * re-read from disk on failure (on nondebug bits).=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20 > 5372 */=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 > 5373 static void=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 > 5374 arc_hdr_verify_checksum(spa_t *spa, arc_buf_hdr_t *hdr, const blkpt= r_t *bp) >=20 > =E2=80=A6 >=20 > 5395 err =3D zio_checksum_error_impl(spa, bp,=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20 > 5396 BP_GET_CHECKSUM(bp), abd, psize, 0, NULL);=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20 > 5397 if (err !=3D 0) {=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20 > 5398 /*=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20 > 5399 * Use abd_copy_to_buf() rather than=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20 > 5400 * abd_borrow_buf_copy() so that we are sur= e to=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20 > 5401 * include the buf in crash dumps.=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20 > 5402 */=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20 > 5403 void *buf =3D kmem_alloc(psize, KM_SLEEP);= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20 > 5404 abd_copy_to_buf(buf, abd, psize);=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20 > 5405 panic("checksum of cached data doesn't matc= h BP "=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 > 5406 "err=3D%u hdr=3D%p bp=3D%p abd=3D%p buf= =3D%p",=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20 > 5407 err, (void *)hdr, (void *)bp, (void *)a= bd, buf);=20=20=20=20=20=20=20=20=20=20 >=20 > OpenZFS though doesn=E2=80=99t have this piece of code and generally retu= rns error as written in comment XXX. >=20 > Tom, do you think the panic() call should be replaced with returning an e= rror? >=20 I mean Tom Caputi :) Since this code was added in "8727 Native data and met= adata encryption for zfs=E2=80=9D. Tom, could you clarify, in which cases zio_checksum_error_impl() can retur= n error here: arc_read -> arc_hdr_verify_checksum -> zio_checksum_error_imp= l ? Is is so critical to panic? =E2=80=94 Vitaliy Gusev > =E2=80=94 > Vitaliy Gusev >=20 >> On 11 Nov 2024, at 21:36, Toomas Soome via illumos-developer wrote: >>=20 >>=20 >>=20 >>> On 30. Oct 2024, at 20:57, Gary Mills wrote: >>>=20 >>> I'm not sure if this is a bug or just ZFS being careful, but I got a >>> panic and reboot while I was doing a "pkg update". The system >>> has an AMD 6-core CPU with B550 support hardware. The next >>> "pkg update" completed normally, without a panic. Here's what >>> I found in /var/adm/messages. Does it look familiar? >>>=20 >>> Oct 30 09:14:31 b550 unix: [ID 836849 kern.notice]=20 >>> Oct 30 09:14:31 b550 ^Mpanic[cpu4]/thread=3Dfffffe2cc9e88780:=20 >>> Oct 30 09:14:31 b550 genunix: [ID 129249 kern.notice] checksum of cache= d data doesn't match BP err=3D50 hdr=3Dfffffe3d478f51c0 bp=3Dfffffe00404339= 88 abd=3Dfffffe3d478f7cc0 buf=3Dfffffe3b5a6f9000 >>> Oct 30 09:14:31 b550 unix: [ID 100000 kern.notice]=20 >>> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433760 = zfs:zfs_nfsshare_inited+378b87f0 () >>> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433890 = zfs:arc_read+de1 () >>> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe00404338e0 = zfs:dbuf_issue_final_prefetch+77 () >>> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433a70 = zfs:dbuf_prefetch_impl+502 () >>> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433b20 = zfs:dmu_zfetch+2ed () >>> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433bd0 = zfs:dmu_buf_hold_array_by_dnode+321 () >>> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433c70 = zfs:dmu_read_uio_dnode+54 () >>> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433cc0 = zfs:dmu_read_uio_dbuf+51 () >>> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433d60 = zfs:zfs_read+19c () >>> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433de0 = genunix:fop_read+60 () >>> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433f00 = genunix:read+2b5 () >>> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433f10 = unix:brand_sys_syscall+1fe () >>> Oct 30 09:14:31 b550 unix: [ID 100000 kern.notice]=20 >>> Oct 30 09:14:31 b550 genunix: [ID 111219 kern.notice] dumping to /dev/z= vol/dsk/rpool/dump, offset 65536, content: kernel >>> Oct 30 09:14:31 b550 ahci: [ID 405573 kern.info] NOTICE: ahci0: ahci_tr= an_reset_dport port 0 reset port >>> Oct 30 09:14:32 b550 ahci: [ID 405573 kern.info] NOTICE: ahci0: ahci_tr= an_reset_dport port 1 reset port >>> Oct 30 09:14:50 b550 genunix: [ID 100000 kern.notice]=20 >>> Oct 30 09:14:50 b550 genunix: [ID 665016 kern.notice] ^M100% done: 8598= 75 pages dumped,=20 >>> Oct 30 09:14:50 b550 genunix: [ID 851671 kern.notice] dump succeeded >>> Oct 30 09:15:34 b550 genunix: [ID 107833 kern.notice] ^MOpenIndiana Hip= ster 2022.10 Version illumos-806838751b 64-bit >>>=20 >>>=20 >>=20 >> Dan got blown up while running zfs-tests (rsend), and that resulted on m= e picking one series of updates from OpenZFS concerning dbuf and dmu. There= are still few XXX notes for myself, but so far both debug and non-debug bu= ilds have been behaving nicely (debug build used to run zfs-tests). I have = seen myself also panic from arc (ASSERT fired while running zfs-tests on de= builg build =E2=80=94 that was before the work mentioned above). Most likel= y need to pick some arc bits as well. >>=20 >> The current wip branch is: https://github.com/tsoome/illumos-gate/tree/r= send if you like to test. The problem about those panics is that they seem = to be random, or at least not easily repeatable. >>=20 >> rgds, >> toomas >>=20 >=20 > illumos / illumos-developer / see d= iscussions + participants <= https://illumos.topicbox.com/groups/developer/members> + delivery=C2=A0opti= ons Permalink <= https://illumos.topicbox.com/groups/developer/Te1153c7aaa3e05c7-M5484aceef4= b12b181bfff6f0> ------------------------------------------ illumos: illumos-developer Permalink: https://illumos.topicbox.com/groups/developer/Te1153c7aaa3e05c7-= Mc08c98af25e077799cc2d612 Delivery options: https://illumos.topicbox.com/groups/developer/subscription --Apple-Mail=_CE4150A3-872C-480C-867F-84D8663E5BE7 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=UTF-8
On 12 Nov 2024, at 00:11, gusev.vitaliy via illumos-= developer <developer@lists.illumos.org> wrote:

Panic comes from this= function:

usr/src/uts/common/fs/zfs/arc.c

 5369 /*       = ;                     &nb= sp;                     &= nbsp;                    =                     &nbs= p;                     &n= bsp;                     =        
 53= 70  * XXX this should be changed to ret= urn an error, and callers                 &= nbsp;                    =                     &nbs= p;                     &n= bsp;  
 5371 <= span style=3D"font-variant-ligatures: no-common-ligatures; color: #75a174">= * re-read from disk on failure (on nondebug bits).         &nb= sp;                     &= nbsp;                    =                     &nbs= p;                    
 5372  */     &nbs= p;                     &n= bsp;                     =                      = ;                     &nb= sp;                     &= nbsp;                    =        
 5= 373 static void               &nb= sp;                     &= nbsp;                    =                     &nbs= p;                     &n= bsp;                     =            
 5374 arc_hdr_verify_checksum(spa_t *spa, arc_buf_hdr_t *hdr, blkptr_t *bp)

  …

 5395             &= nbsp;   err =3D zio_checksum_error_impl= (spa, bp,                  &nb= sp;                     &= nbsp;                    =                     &nbs= p;        
 5396                  =   BP_GET_CHECKSUM(bp), abd, psize, 0, = NULL);      &= nbsp;                    =                     &nbs= p;                     &n= bsp;            
 5= 397               &n= bsp; if (err !=3D 0) {               &nb= sp;                     &= nbsp;                    =                     &nbs= p;                     &n= bsp;            
 5398                = ;         /*          =                      = ;                     &nb= sp;                     &= nbsp;                    =                     &nbs= p;  
 5399  &= nbsp;                    =   * Use abd_copy_to_buf() rather than           = ;                     &nb= sp;                     &= nbsp;                    =          
<= span style=3D"font-variant-ligatures: no-common-ligatures; color: #595959">=  5400                &= nbsp;         * abd_borrow_buf_copy() so that we are su= re to &n= bsp;                     =                      = ;                     &nb= sp;        
&nbs= p;5401                 = ;         * include the buf in crash dumps.     =                     &nbs= p;                     &n= bsp;                     =                  
=
 5402        &n= bsp;                 */      = ;                     &nb= sp;                     &= nbsp;                    =                     &nbs= p;                     &n= bsp;    
 5403 &nbs= p;                     &n= bsp; void *buf<= /span> =3D kmem_alloc(psize, KM_SL= EEP);                    =                      = ;                     &nb= sp;                  
 5404        =                 abd_copy_to= _buf(buf, abd, psize);         =                      = ;                     &nb= sp;                     &= nbsp;              
<= div style=3D"margin: 0px; font-style: normal; font-variant-caps: normal; fo= nt-stretch: normal; font-size: 12px; line-height: normal; font-family: Menl= o; font-size-adjust: none; font-kerning: auto; font-variant-alternates: nor= mal; font-variant-ligatures: normal; font-variant-numeric: normal; font-var= iant-east-asian: normal; font-variant-position: normal; font-feature-settin= gs: normal; font-optical-sizing: auto; font-variation-settings: normal;"> 5405           &nbs= p;             panic("checksum of cached data doesn't= match BP "           &nb= sp;                     &= nbsp;                    =                  
 5406             &n= bsp;               "err=3D%= u hdr=3D%p bp=3D%p abd=3D%p buf=3D%p",           = ;                     &nb= sp;                     &= nbsp;                    =      
 = ;5407 &= nbsp;                    =       err, (void *)hdr, (v= oid *)b= p, (void *)abd, buf);          

OpenZFS though doesn’t have this p= iece of code and generally returns error as written in comment XXX.

Tom, do you think the panic() call should be replaced w= ith returning an error?


I mean Tom Caputi :) Since this code was added in &= quot;8727 Native data= and metadata encryption for zfs”.

<= span style=3D"font-size: 14px;">Tom, could you clarify,  in which case= s zio_chec= ksum_error_impl() can return error here: arc_read -> arc_hdr_verify_checksu= m ->&= nbsp;zio_checksum_error_impl ? Is is so critical to panic?

= —
Vitaliy Gusev


—
Vit= aliy Gusev

On 11 Nov 2024, a= t 21:36, Toomas Soome via illumos-developer <developer@lists.illumos.org= > wrote:



On 30. Oct 2024, at 20:57, Gar= y Mills <gary_mills@fastmail.fm> wrote:

I'm not sure if this is a bug or just ZFS b= eing careful, but I got a
panic and reboot while I was doing a "p= kg update".  The system
has an AMD 6-core CPU with B550 supp= ort hardware.  The next
"pkg update" completed normally= , without a panic.  Here's what
I found in /var/adm/messages.=  Does it look familiar?

Oct 30 09:14:31 b550 unix: [ID 836= 849 kern.notice] 
Oc= t 30 09:14:31 b550 ^Mpanic[cpu4]/thread=3Dfffffe2cc9e88780: 
Oct 30 09:14:31 b550 genunix: [ID = 129249 kern.notice] checksum of cached data doesn't match BP err=3D50 h= dr=3Dfffffe3d478f51c0 bp=3Dfffffe0040433988 abd=3Dfffffe3d478f7cc0 buf=3Dff= fffe3b5a6f9000
Oct 30 09:14:31 b550 unix: [ID 100000 kern.notice] 
Oct 30 09:14:31 b550 ge= nunix: [ID 655072 kern.notice] fffffe0040433760 zfs:zfs_nfsshare_inited+378= b87f0 ()
Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0= 040433890 zfs:arc_read+de1 ()
Oct 30 09:14:31 b550 genunix: [ID 655072= kern.notice] fffffe00404338e0 zfs:dbuf_issue_final_prefetch+77 ()
Oct= 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433a70 zfs:dbu= f_prefetch_impl+502 ()
Oct 30 09:14:31 b550 genunix: [ID 655072 kern.n= otice] fffffe0040433b20 zfs:dmu_zfetch+2ed ()
Oct 30 09:14:31 b550 gen= unix: [ID 655072 kern.notice] fffffe0040433bd0 zfs:dmu_buf_hold_array_by_dn= ode+321 ()
Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffff= e0040433c70 zfs:dmu_read_uio_dnode+54 ()
Oct 30 09:14:31 b550 genunix:= [ID 655072 kern.notice] fffffe0040433cc0 zfs:dmu_read_uio_dbuf+51 ()
= Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433d60 zfs:= zfs_read+19c ()
Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] = fffffe0040433de0 genunix:fop_read+60 ()
Oct 30 09:14:31 b550 genunix: = [ID 655072 kern.notice] fffffe0040433f00 genunix:read+2b5 ()
Oct 30 09= :14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433f10 unix:brand_sy= s_syscall+1fe ()
Oct 30 09:14:31 b550 unix: [ID 100000 kern.notice] 
Oct 30 09:14:31 b550 = genunix: [ID 111219 kern.notice] dumping to /dev/zvol/dsk/rpool/dump, offse= t 65536, content: kernel
Oct 30 09:14:31 b550 ahci: [ID 405573 kern.in= fo] NOTICE: ahci0: ahci_tran_reset_dport port 0 reset port
Oct 30 09:1= 4:32 b550 ahci: [ID 405573 kern.info] NOTICE: ahci0: ahci_tran_reset_dport = port 1 reset port
Oct 30 09:14:50 b550 genunix: [ID 100000 kern.notice= ] 
Oct 30 09:14:50 b= 550 genunix: [ID 665016 kern.notice] ^M100% done: 859875 pages dumped, 
Oct 30 09:14:50 b550 ge= nunix: [ID 851671 kern.notice] dump succeeded
Oct 30 09:15:34 b550 gen= unix: [ID 107833 kern.notice] ^MOpenIndiana Hipster 2022.10 Version illumos= -806838751b 64-bit



Dan got blown up while running zfs-tests (rsend), a= nd that resulted on me picking one series of updates from OpenZFS concernin= g dbuf and dmu. There are still few XXX notes for myself, but so far both d= ebug and non-debug builds have been behaving nicely (debug build used to ru= n zfs-tests). I have seen myself also panic from arc (ASSERT fired while ru= nning zfs-tests on debuilg build — that was before the work mentioned= above). Most likely need to pick some arc bits as well.

The current wip branch i= s: https= ://github.com/tsoome/illumos-gate/tree/rsend if you like to test. = The problem about those panics is that they seem to be random, or at least = not easily repeatable.

rgds,
toomas



= --Apple-Mail=_CE4150A3-872C-480C-867F-84D8663E5BE7--