From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4 Received: from tb-ob1.topicbox.com (tb-ob1.topicbox.com [64.147.108.173]) by inbox.vuxu.org (Postfix) with ESMTP id 4C63724CB1 for ; Mon, 11 Nov 2024 22:14:16 +0100 (CET) Received: from tb-mx1.topicbox.com (tb-mx1.nyi.icgroup.com [10.90.30.61]) by tb-ob1.topicbox.com (Postfix) with ESMTP id 35E5F3D41A for ; Mon, 11 Nov 2024 16:14:16 -0500 (EST) (envelope-from bounce.mM5484aceef4b12b181bfff6f0.r81958daa-7202-11ef-bbf2-18142b2d11b0@illumos.bounce.topicbox.com) Received: by tb-mx1.topicbox.com (Postfix, from userid 1132) id 3280424BE33; Mon, 11 Nov 2024 16:14:16 -0500 (EST) ARC-Authentication-Results: i=2; topicbox.com; arc=pass; dkim=pass (2048-bit rsa key sha256) header.d=icloud.com header.i=@icloud.com header.b=iPinqqsN header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=icloud.com; spf=pass smtp.mailfrom=gusev.vitaliy@icloud.com smtp.helo=pv50p00im-ztbu10011701.me.com; x-internal-arc=fail (as.1.topicbox.com=pass, ams.1.topicbox.com=fail (message has been altered)) (Message modified while forwarding at Topicbox) ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=message-id:content-type:mime-version:subject :date:in-reply-to:cc:to:references:list-help:list-id:list-post :list-subscribe:reply-to:content-transfer-encoding:from :list-unsubscribe; s=sysmsg-1; t=1731359656; bh=Ek8rFpIc6malvBuN tPSY9iJ53knhhqaS5CUhLANlkEE=; b=f3qN8c1kwZzhP8eZwoIGVlvDOkpJiiog 8SxXB8vMdVsi0G3fq+0MGFYjiXC7qfJ14++eNQrU3AH76SSgHfLgJKs0PwCVjmog 1fA4AaTcwHvsOBooroyiXzmfXnh0aePDhkNgaF27dSgcD2gU3wofGyEAJz19YJVu 0GAklyzmNkA= ARC-Seal: i=2; a=rsa-sha256; cv=pass; d=topicbox.com; s=sysmsg-1; t= 1731359656; b=Zpr4xyldWcopn/C8Wo511oCNzr/Rl6EwOX+tdNoNgRv/DkbIOq rsHHvxS30X6CZIQieCqhwRwGmCSosZtqnOVINJCCPKdFJ857QxJODs3IYQeYwJH0 Ff5PyXp4f5q/uHiGW94VCx5xnXXxOosgyKpWOgnl4kxkLqAFukN73Yrtg= Authentication-Results: topicbox.com; arc=pass; dkim=pass (2048-bit rsa key sha256) header.d=icloud.com header.i=@icloud.com header.b=iPinqqsN header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=icloud.com; spf=pass smtp.mailfrom=gusev.vitaliy@icloud.com smtp.helo=pv50p00im-ztbu10011701.me.com; x-internal-arc=fail (as.1.topicbox.com=pass, ams.1.topicbox.com=fail (message has been altered)) (Message modified while forwarding at Topicbox) X-Received-Authentication-Results: tb-mx1.topicbox.com; arc=none (no signatures found); bimi=declined (Domain declined to participate); dkim=pass (2048-bit rsa key sha256) header.d=icloud.com header.i=@icloud.com header.b=iPinqqsN header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=icloud.com; iprev=pass smtp.remote-ip=17.58.6.53 (pv50p00im-ztbu10011701.me.com); spf=pass smtp.mailfrom=gusev.vitaliy@icloud.com smtp.helo=pv50p00im-ztbu10011701.me.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=pv50p00im-ztbu10011701.me.com policy.ptr=pv50p00im-ztbu10011701.me.com; x-return-mx=pass header.domain=icloud.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-return-mx=pass smtp.domain=icloud.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lists.illumos.org; h= message-id:content-type:mime-version:subject:date:in-reply-to:cc :to:references:list-help:list-id:list-post:list-subscribe :reply-to:content-transfer-encoding:from:list-unsubscribe; s= dkim-1; t=1731359655; x=1731446055; bh=QjAX7aU41kDNf7nDktZwh4lA6 I6XPeHhhRv5ngwL9vI=; b=W0pW7Td0g0EsTEKOJVQMT28jt7XiAfv8nYOdalKy7 Se7NtIOlNZdhsaVAhAytRltmDYXv33MWVqqPikBQFqs+YoFHB1Z3cYnXo9I5MeZK H0tRCUhNXTIvVZxVsysoTM8+ACw9eJIX47fIikze+zKXd9+mMpEKO9pXc8rCj07U WE= Received: from tb-mx1.topicbox.com (localhost.local [127.0.0.1]) by tb-mx1.topicbox.com (Postfix) with ESMTP id 860CA24B79A for ; Mon, 11 Nov 2024 16:11:52 -0500 (EST) (envelope-from gusev.vitaliy@icloud.com) Received: from tb-mx1.topicbox.com (localhost [127.0.0.1]) by tb-mx1.topicbox.com (Authentication Milter) with ESMTP id 59EFEC28CA5; Mon, 11 Nov 2024 16:11:52 -0500 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1731359512; b=XIPX5ppCvXdHJHk9VidLGRmk26dPjT3n0FPrPsfoatTIp7xDkt RjL3lrbeJlT4MTSS1DWVpvrC/Ab1pcOv7oFJCjK8EHypR8oj05o3sgBTqhA/xNPT 0SMbErCCCqBcRhTWqUt640Pr5+dM11g6vWtwfSUjzz8kxbN5gMBmTDGVFc9mcjp6 jcxGFFrPC5seCkQmRqaRjidrlGlgT9gXd50X5NNhx87wD1HGd67HqQ0Q+5JDBMSZ 926nWavIUgu35RBLe0z1JMH6HgJYmGuNzonsbiA6rBDUYno6L+L6wSPxVK6sBPso HOiVCpmE1/w4OTl82K6T/NunIdZMOKh+t1UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=from:message-id:content-type:mime-version :subject:date:in-reply-to:cc:to:references; s=arcseal; t= 1731359512; bh=xVOGCAHIJbjROLsoHA6BbwZuAB5gFwRXG1PjmLHz6/M=; b=D soyTM6d6YONoLSjcEqnxWVph9nON4s+BOCMZPezGk+uIpYZ8HPfdjwg0XkNWkiIB Y99sVTlOUpjBwyzdqj8yoxntLvBI1UHU7p4uI1koSCprPN35yLke2lpx2sXSNjxV yyz1Vcedvhff1zmAQN/g3cTWWpuwE/D/CNxCalsxLzVT+GbCrP6J0lEPyJT3JQJU DNqbTkUb+2nXmUbqdFt1yjq12h/jGdcEtYCEF7rZaOTy1yQ+BFT3dIxFhtWuB3J/ FNd2v3PM8d1EOU2fw8vQFIeg0gRRUxJYflt2jWBAbtaYQ3m7sWvIXrRarwigVV0L eB9YqbWrGmt+fmgDNhD2w== ARC-Authentication-Results: i=1; tb-mx1.topicbox.com; arc=none (no signatures found); bimi=declined (Domain declined to participate); dkim=pass (2048-bit rsa key sha256) header.d=icloud.com header.i=@icloud.com header.b=iPinqqsN header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=icloud.com; iprev=pass smtp.remote-ip=17.58.6.53 (pv50p00im-ztbu10011701.me.com); spf=pass smtp.mailfrom=gusev.vitaliy@icloud.com smtp.helo=pv50p00im-ztbu10011701.me.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=pv50p00im-ztbu10011701.me.com policy.ptr=pv50p00im-ztbu10011701.me.com; x-return-mx=pass header.domain=icloud.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-return-mx=pass smtp.domain=icloud.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgeefuddruddvgddugeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffktgggufffjgevvfhfofesrgdtmherhhdtjeen ucfhrhhomhepghhushgvvhdrvhhithgrlhhihiesihgtlhhouhgurdgtohhmnecuggftrf grthhtvghrnhepueegteffueellefgveejlefhffehteejvdfhgfetfeffteelgfdufeeu hfehgfdtnecuffhomhgrihhnpehgihhthhhusgdrtghomhdpthhophhitggsohigrdgtoh hmnecukfhppedujedrheekrdeirdehfedpudejrdehiedrledruddtnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehinhgvthepudejrdehkedriedrheefpdhhvghloh epphhvhedtphdttdhimhdqiihtsghuuddttdduudejtddurdhmvgdrtghomhdpmhgrihhl fhhrohhmpeeoghhushgvvhdrvhhithgrlhhihiesihgtlhhouhgurdgtohhmqedpnhgspg hrtghpthhtohepuddprhgtphhtthhopeeouggvvhgvlhhophgvrheslhhishhtshdrihhl lhhumhhoshdrohhrgheq X-ME-VSScore: -100 X-ME-VSCategory: clean Received-SPF: pass (icloud.com: 17.58.6.53 is authorized to use 'gusev.vitaliy@icloud.com' in 'mfrom' identity (mechanism 'ip4:17.58.0.0/16' matched)) receiver=tb-mx1.topicbox.com; identity=mailfrom; envelope-from="gusev.vitaliy@icloud.com"; helo=pv50p00im-ztbu10011701.me.com; client-ip=17.58.6.53 Received: from pv50p00im-ztbu10011701.me.com (pv50p00im-ztbu10011701.me.com [17.58.6.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx1.topicbox.com (Postfix) with ESMTPS for ; Mon, 11 Nov 2024 16:11:51 -0500 (EST) (envelope-from gusev.vitaliy@icloud.com) Received: from smtpclient.apple (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-ztbu10011701.me.com (Postfix) with ESMTPSA id D2C6C740315; Mon, 11 Nov 2024 21:11:47 +0000 (UTC) Message-Id: <3959AC6D-6D8E-4139-A107-7809AB79B12B@icloud.com> Content-Type: multipart/alternative; boundary="Apple-Mail=_80041C1F-15D5-4800-A76E-220E17C34077" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\)) Subject: Re: [developer] Panic during pkg update Date: Tue, 12 Nov 2024 00:11:22 +0300 In-Reply-To: <17219899-949B-417B-8226-B3BC012C9EA4@me.com> Cc: Tom Caputi To: illumos-developer , Toomas Soome via illumos-developer References: <17219899-949B-417B-8226-B3BC012C9EA4@me.com> X-Mailer: Apple Mail (2.3776.700.51) X-Proofpoint-GUID: Xae86-TtJzu5HgTTlKxFzAt1QwpaWtjd X-Proofpoint-ORIG-GUID: Xae86-TtJzu5HgTTlKxFzAt1QwpaWtjd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-11-11_08,2024-11-08_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 suspectscore=0 mlxscore=0 phishscore=0 spamscore=0 malwarescore=0 clxscore=1011 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2411110170 Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: 95eb6188-a071-11ef-9ca0-e6becf42f9a8 Archived-At: =?UTF-8?B?PGh0dHBzOi8vaWxsdW1vcy50b3BpY2JveC5jb20vZ3JvdXBz?= =?UTF-8?B?L2RldmVsb3Blci9UZTExNTNjN2FhYTNlMDVjNy1NNTQ4NGFjZWVmNGIxMmIx?= =?UTF-8?B?ODFiZmZmNmYwPg==?= List-Help: List-Id: "illumos-developer" List-Post: List-Software: Topicbox v0 List-Subscribe: Precedence: list Reply-To: illumos-developer Content-Transfer-Encoding: 7bit From: "gusev.vitaliy via illumos-developer" List-Unsubscribe: , Topicbox-Delivery-ID: 2:illumos:a901537c-2aea-11e7-965f-d98f9f16e227:81958daa-7202-11ef-bbf2-18142b2d11b0:M5484aceef4b12b181bfff6f0:1:w1CqEX2tdthp28VHz8Xc5_Hd-p2m_i_XRwq5xB47fL4 --Apple-Mail=_80041C1F-15D5-4800-A76E-220E17C34077 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Panic comes from this function: usr/src/uts/common/fs/zfs/arc.c 5369 /*=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 5370 * XXX this should be changed to return an error, and callers=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20 5371 * re-read from disk on failure (on nondebug bits).=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20 5372 */=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 5373 static void=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 5374 arc_hdr_verify_checksum(spa_t *spa, arc_buf_hdr_t *hdr, const blkptr_= t *bp) =E2=80=A6 5395 err =3D zio_checksum_error_impl(spa, bp,=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20 5396 BP_GET_CHECKSUM(bp), abd, psize, 0, NULL);=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20 5397 if (err !=3D 0) {=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20 5398 /*=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20 5399 * Use abd_copy_to_buf() rather than=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20 5400 * abd_borrow_buf_copy() so that we are sure = to=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 5401 * include the buf in crash dumps.=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20 5402 */=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20 5403 void *buf =3D kmem_alloc(psize, KM_SLEEP);=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20 5404 abd_copy_to_buf(buf, abd, psize);=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20 5405 panic("checksum of cached data doesn't match = BP "=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 5406 "err=3D%u hdr=3D%p bp=3D%p abd=3D%p buf= =3D%p",=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20 5407 err, (void *)hdr, (void *)bp, (void *)abd= , buf);=20=20=20=20=20=20=20=20=20=20 OpenZFS though doesn=E2=80=99t have this piece of code and generally return= s error as written in comment XXX. Tom, do you think the panic() call should be replaced with returning an err= or? =E2=80=94 Vitaliy Gusev > On 11 Nov 2024, at 21:36, Toomas Soome via illumos-developer wrote: >=20 >=20 >=20 >> On 30. Oct 2024, at 20:57, Gary Mills wrote: >>=20 >> I'm not sure if this is a bug or just ZFS being careful, but I got a >> panic and reboot while I was doing a "pkg update". The system >> has an AMD 6-core CPU with B550 support hardware. The next >> "pkg update" completed normally, without a panic. Here's what >> I found in /var/adm/messages. Does it look familiar? >>=20 >> Oct 30 09:14:31 b550 unix: [ID 836849 kern.notice]=20 >> Oct 30 09:14:31 b550 ^Mpanic[cpu4]/thread=3Dfffffe2cc9e88780:=20 >> Oct 30 09:14:31 b550 genunix: [ID 129249 kern.notice] checksum of cached= data doesn't match BP err=3D50 hdr=3Dfffffe3d478f51c0 bp=3Dfffffe004043398= 8 abd=3Dfffffe3d478f7cc0 buf=3Dfffffe3b5a6f9000 >> Oct 30 09:14:31 b550 unix: [ID 100000 kern.notice]=20 >> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433760 z= fs:zfs_nfsshare_inited+378b87f0 () >> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433890 z= fs:arc_read+de1 () >> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe00404338e0 z= fs:dbuf_issue_final_prefetch+77 () >> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433a70 z= fs:dbuf_prefetch_impl+502 () >> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433b20 z= fs:dmu_zfetch+2ed () >> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433bd0 z= fs:dmu_buf_hold_array_by_dnode+321 () >> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433c70 z= fs:dmu_read_uio_dnode+54 () >> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433cc0 z= fs:dmu_read_uio_dbuf+51 () >> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433d60 z= fs:zfs_read+19c () >> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433de0 g= enunix:fop_read+60 () >> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433f00 g= enunix:read+2b5 () >> Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433f10 u= nix:brand_sys_syscall+1fe () >> Oct 30 09:14:31 b550 unix: [ID 100000 kern.notice]=20 >> Oct 30 09:14:31 b550 genunix: [ID 111219 kern.notice] dumping to /dev/zv= ol/dsk/rpool/dump, offset 65536, content: kernel >> Oct 30 09:14:31 b550 ahci: [ID 405573 kern.info] NOTICE: ahci0: ahci_tra= n_reset_dport port 0 reset port >> Oct 30 09:14:32 b550 ahci: [ID 405573 kern.info] NOTICE: ahci0: ahci_tra= n_reset_dport port 1 reset port >> Oct 30 09:14:50 b550 genunix: [ID 100000 kern.notice]=20 >> Oct 30 09:14:50 b550 genunix: [ID 665016 kern.notice] ^M100% done: 85987= 5 pages dumped,=20 >> Oct 30 09:14:50 b550 genunix: [ID 851671 kern.notice] dump succeeded >> Oct 30 09:15:34 b550 genunix: [ID 107833 kern.notice] ^MOpenIndiana Hips= ter 2022.10 Version illumos-806838751b 64-bit >>=20 >>=20 >=20 > Dan got blown up while running zfs-tests (rsend), and that resulted on me= picking one series of updates from OpenZFS concerning dbuf and dmu. There = are still few XXX notes for myself, but so far both debug and non-debug bui= lds have been behaving nicely (debug build used to run zfs-tests). I have s= een myself also panic from arc (ASSERT fired while running zfs-tests on deb= uilg build =E2=80=94 that was before the work mentioned above). Most likely= need to pick some arc bits as well. >=20 > The current wip branch is: https://github.com/tsoome/illumos-gate/tree/rs= end if you like to test. The problem about those panics is that they seem t= o be random, or at least not easily repeatable. >=20 > rgds, > toomas >=20 > illumos / illumos-developer / see d= iscussions + participants <= https://illumos.topicbox.com/groups/developer/members> + delivery=C2=A0opti= ons Permalink <= https://illumos.topicbox.com/groups/developer/Te1153c7aaa3e05c7-Mb8af562876= 078fc2e3f7037c> ------------------------------------------ illumos: illumos-developer Permalink: https://illumos.topicbox.com/groups/developer/Te1153c7aaa3e05c7-= M5484aceef4b12b181bfff6f0 Delivery options: https://illumos.topicbox.com/groups/developer/subscription --Apple-Mail=_80041C1F-15D5-4800-A76E-220E17C34077 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=UTF-8 Panic comes from th= is function:

usr/src/uts/common/fs/zfs/arc.c

 5369 /*       = ;                     &nb= sp;                     &= nbsp;                    =                     &nbs= p;                     &n= bsp;                     =        

 5370 = * XXX this should be changed to return an e= rror, and callers                   &n= bsp;                     =                      = ;                     &nb= sp;

 5371  * re-read from = disk on failure (on nondebug bits).              = ;                     &nb= sp;                     &= nbsp;                    =                

 5372  */             =                      = ;                     &nb= sp;                     &= nbsp;                    =                     &nbs= p;                     &n= bsp;

 5373 static= void   &n= bsp;                     =                      = ;                     &nb= sp;                     &= nbsp;                    =                     &nbs= p;  

 5374 arc_hdr_verify_checksum(spa_t *<= span style=3D"font-variant-ligatures: no-common-ligatures; color: rgb(205, = 160, 116);">spa, arc_buf_hdr_t *hdr, const<= span style=3D"font-variant-ligatures: no-common-ligatures; color: rgb(206, = 206, 206);"> blkptr_t *bp)


  &h= ellip;

 5395  =               err =3D zio_checks= um_error_impl(spa, bp,        &= nbsp;                    =                     &nbs= p;                     &n= bsp;                  <= /span>

 5396          =           BP_GET_CHECKSUM(bp), abd, psize, 0, NULL);                   =                     &nbs= p;                     &n= bsp;                    <= /span>

 5397         &nb= sp;       if (err !=3D 0) {         &nbs= p;                     &n= bsp;                     =                      = ;                     &nb= sp;                  

 5398             =             /*      &n= bsp;                     =                      = ;                     &nb= sp;                     &= nbsp;                    =      

 5399          &= nbsp;                    =                     &nbs= p;                     &n= bsp;          

&nbs= p;5400                 = ;         * abd_borrow_buf_copy() so that we are sure t= o  =                     &nbs= p;                     &n= bsp;                     =        

 5401 =                   &nb= sp;     * include the buf in crash dumps.        &nbs= p;                     &n= bsp;                     =                      = ;              

 5402              &= nbsp;           */           &nbs= p;                     &n= bsp;                     =                      = ;                     &nb= sp;                    

 5403         &nbs= p;               voi= d *buf =3D = kmem_alloc(psize, KM_SLEEP);      &n= bsp;                     =                      = ;                     &nb= sp;          

 5404                  =       abd_copy_to_buf(buf, a= bd, psize);                   =                      = ;                     &nb= sp;                     &= nbsp;    

 5405   =                      = ; panic("che= cksum of cached data doesn't match BP "  =                     &nbs= p;                     &n= bsp;                     =      

 5406      =                     &nbs= p; "err=3D%u hdr=3D%p bp=3D%p abd=3D%p buf=3D%p",    &n= bsp;                     =                      = ;                     &nb= sp;            

 5407                 &nbs= p;           err, (void= *)hdr, (void *)bp, (void *)abd, buf);       &nb= sp;  


OpenZFS though doesn’t h= ave this piece of code and generally returns error as written in comment XX= X.

Tom, do you think the panic() call should be = replaced with returning an error?

<= div>Vitaliy Gusev

On 11 Nov = 2024, at 21:36, Toomas Soome via illumos-developer <developer@lists.illu= mos.org> wrote:



On 30. Oct 2024, at 20:= 57, Gary Mills <gary_mills@fastmail.fm> wrote:

I'm not sure if this is a bug or jus= t ZFS being careful, but I got a
panic and reboot while I was doing a = "pkg update".  The system
has an AMD 6-core CPU with B5= 50 support hardware.  The next
"pkg update" completed n= ormally, without a panic.  Here's what
I found in /var/adm/me= ssages.  Does it look familiar?

Oct 30 09:14:31 b550 unix: = [ID 836849 kern.notice] <= br />Oct 30 09:14:31 b550 ^Mpanic[cpu4]/thread=3Dfffffe2cc9e88780: 
Oct 30 09:14:31 b550 genuni= x: [ID 129249 kern.notice] checksum of cached data doesn't match BP err= =3D50 hdr=3Dfffffe3d478f51c0 bp=3Dfffffe0040433988 abd=3Dfffffe3d478f7cc0 b= uf=3Dfffffe3b5a6f9000
Oct 30 09:14:31 b550 unix: [ID 100000 kern.notic= e] 
Oct 30 09:14:31 = b550 genunix: [ID 655072 kern.notice] fffffe0040433760 zfs:zfs_nfsshare_ini= ted+378b87f0 ()
Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] = fffffe0040433890 zfs:arc_read+de1 ()
Oct 30 09:14:31 b550 genunix: [ID= 655072 kern.notice] fffffe00404338e0 zfs:dbuf_issue_final_prefetch+77 ()Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433a70 = zfs:dbuf_prefetch_impl+502 ()
Oct 30 09:14:31 b550 genunix: [ID 655072= kern.notice] fffffe0040433b20 zfs:dmu_zfetch+2ed ()
Oct 30 09:14:31 b= 550 genunix: [ID 655072 kern.notice] fffffe0040433bd0 zfs:dmu_buf_hold_arra= y_by_dnode+321 ()
Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice= ] fffffe0040433c70 zfs:dmu_read_uio_dnode+54 ()
Oct 30 09:14:31 b550 g= enunix: [ID 655072 kern.notice] fffffe0040433cc0 zfs:dmu_read_uio_dbuf+51 (= )
Oct 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433d= 60 zfs:zfs_read+19c ()
Oct 30 09:14:31 b550 genunix: [ID 655072 kern.n= otice] fffffe0040433de0 genunix:fop_read+60 ()
Oct 30 09:14:31 b550 ge= nunix: [ID 655072 kern.notice] fffffe0040433f00 genunix:read+2b5 ()
Oc= t 30 09:14:31 b550 genunix: [ID 655072 kern.notice] fffffe0040433f10 unix:b= rand_sys_syscall+1fe ()
Oct 30 09:14:31 b550 unix: [ID 100000 kern.not= ice] 
Oct 30 09:14:3= 1 b550 genunix: [ID 111219 kern.notice] dumping to /dev/zvol/dsk/rpool/dump= , offset 65536, content: kernel
Oct 30 09:14:31 b550 ahci: [ID 405573 = kern.info] NOTICE: ahci0: ahci_tran_reset_dport port 0 reset port
Oct = 30 09:14:32 b550 ahci: [ID 405573 kern.info] NOTICE: ahci0: ahci_tran_reset= _dport port 1 reset port
Oct 30 09:14:50 b550 genunix: [ID 100000 kern= .notice] 
Oct 30 09:= 14:50 b550 genunix: [ID 665016 kern.notice] ^M100% done: 859875 pages dumpe= d, 
Oct 30 09:14:50 = b550 genunix: [ID 851671 kern.notice] dump succeeded
Oct 30 09:15:34 b= 550 genunix: [ID 107833 kern.notice] ^MOpenIndiana Hipster 2022.10 Version = illumos-806838751b 64-bit



<= /div>
Dan got blown up while running zfs-tests (rs= end), and that resulted on me picking one series of updates from OpenZFS co= ncerning dbuf and dmu. There are still few XXX notes for myself, but so far= both debug and non-debug builds have been behaving nicely (debug build use= d to run zfs-tests). I have seen myself also panic from arc (ASSERT fired w= hile running zfs-tests on debuilg build — that was before the work me= ntioned above). Most likely need to pick some arc bits as well.

The current wip b= ranch is: https://github.com/tsoome/illumos-gate/tree/rsend if you like to= test. The problem about those panics is that they seem to be random, or at= least not easily repeatable.

rgds,
toomas

= --Apple-Mail=_80041C1F-15D5-4800-A76E-220E17C34077--