[developer] [REVIEW] 16585 ping ignores ipv6 scope id in target address

["Bill Sommerfeld via illumos-developer" <developer@lists.illumos.org>]

Issue: https://www.illumos.org/issues/16585
CR: https://code.illumos.org/c/illumos-gate/+/3755
Diff: 
https://code.illumos.org/~diff/91dc2df4483aaa88d9a9bc35b73956d795bcf4d0

Next in my queue of ipv6 scope fixes, the "ping" command:

Ping accepts addresses with attached scope, as in this link-local
multicast "all nodes" ping:

        ping ff02::1%lan0

but discards the scope, leading to potential confusion (it sends the
ping out the wrong interface).  The fix generally involves deferring
disassembly of the "struct sockaddr_in6" so the scope is available
alongside the address.

Also along for the ride (and, alas, dominating the diffs) are some
other source cleanups:

  - Printing the scope tag for received traffic.

  - Printing a warning when a scoped address is used along with the
    "-i" option (another way to specify a specific output interface).

  - Moving function prototype declarations for external functions from
    ping*.c to ping.

  - Restructuring the "pr_name" function into address-family-specific
    variants to reduce the amount of casting required.

  - cstyle whitespace fixes

Thanks in advance for your review.

                                        - Bill



------------------------------------------
illumos: illumos-developer
Permalink: https://illumos.topicbox.com/groups/developer/T935428f17dc3d883-M02a7f11076aad391c565761a
Delivery options: https://illumos.topicbox.com/groups/developer/subscription