From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4 Received: from tb-ob0.topicbox.com (tb-ob0.topicbox.com [64.147.108.117]) by inbox.vuxu.org (Postfix) with ESMTP id 7A9972F7D4 for ; Mon, 28 Oct 2024 20:45:23 +0100 (CET) Received: from tb-mx0.topicbox.com (tb-mx0.nyi.icgroup.com [10.90.30.73]) by tb-ob0.topicbox.com (Postfix) with ESMTP id 5BF163C678 for ; Mon, 28 Oct 2024 15:45:22 -0400 (EDT) (envelope-from bounce.mM02a7f11076aad391c565761a.r81958daa-7202-11ef-bbf2-18142b2d11b0@illumos.bounce.topicbox.com) Received: by tb-mx0.topicbox.com (Postfix, from userid 1132) id 59B41FDAE9; Mon, 28 Oct 2024 15:45:22 -0400 (EDT) ARC-Authentication-Results: i=2; topicbox.com; arc=pass; dkim=pass (2048-bit rsa key sha256) header.d=hamachi.org header.i=@hamachi.org header.b=pfxwo2Kh header.a=rsa-sha256 header.s=hamachi-202410 x-bits=2048; dmarc=pass policy.published-domain-policy=reject policy.applied-disposition=none policy.evaluated-disposition=none (p=reject,d=none,d.eval=none) policy.policy-from=p header.from=hamachi.org; spf=pass smtp.mailfrom=sommerfeld@hamachi.org smtp.helo=the-governor.hamachi.org; x-internal-arc=fail (as.1.topicbox.com=pass, ams.1.topicbox.com=fail (message has been altered)) (Message modified while forwarding at Topicbox) ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=message-id:date:mime-version:to:content-type :content-transfer-encoding:list-help:list-id:list-post :list-subscribe:reply-to:subject:from:list-unsubscribe; s= sysmsg-1; t=1730144722; bh=rGvOSgj/Mtp56e13S3SKSNTKTwb8cWn704pLz 1yD4gQ=; b=pDDS0qs59J5pSzvX7/cFyfWppwvbuxU1J0yFqMZP1fJ5Wi53CcUUF v1eduyhX584scDUhB/0dwshV4i2Z9UVRD4t7SiYEreiXvgv7pSGonQTuNOsdb0tk 1kyLGA+GIo3oIpi2WV+XrMD9+2vJQQxDHyfTEXIc/C/sX9jGvRjtGU= ARC-Seal: i=2; a=rsa-sha256; cv=pass; d=topicbox.com; s=sysmsg-1; t= 1730144722; b=AgypFIg/avOIMMKHPpKyJR2x26Os3IIGkajy8fOELc8xC+MYUO irrPtadLiClieWTBTXzB3m8qgL0s9J8/6XV1txnDo35fAO1T+Ru6PLVp7zUlZWcX UdSO23X9UmL9pzYO+862+e/3XdmhWOB01VdDXlQH5tSGmUj0RD5G3Ww30= Authentication-Results: topicbox.com; arc=pass; dkim=pass (2048-bit rsa key sha256) header.d=hamachi.org header.i=@hamachi.org header.b=pfxwo2Kh header.a=rsa-sha256 header.s=hamachi-202410 x-bits=2048; dmarc=pass policy.published-domain-policy=reject policy.applied-disposition=none policy.evaluated-disposition=none (p=reject,d=none,d.eval=none) policy.policy-from=p header.from=hamachi.org; spf=pass smtp.mailfrom=sommerfeld@hamachi.org smtp.helo=the-governor.hamachi.org; x-internal-arc=fail (as.1.topicbox.com=pass, ams.1.topicbox.com=fail (message has been altered)) (Message modified while forwarding at Topicbox) X-Received-Authentication-Results: the-governor.hamachi.org; auth=pass; dkim=pass (2048-bit rsa key sha256) header.d=hamachi.org header.i=@hamachi.org header.b=pfxwo2Kh header.a=rsa-sha256 header.s=hamachi-202410; x-aligned-from=pass (Address match); x-local-user=pass; x-spam=pass score=-2.00 required=5.00 X-Received-Authentication-Results: tb-mx0.topicbox.com; arc=none (no signatures found); bimi=none (No BIMI records found); dkim=pass (2048-bit rsa key sha256) header.d=hamachi.org header.i=@hamachi.org header.b=pfxwo2Kh header.a=rsa-sha256 header.s=hamachi-202410 x-bits=2048; dmarc=pass policy.published-domain-policy=reject policy.applied-disposition=none policy.evaluated-disposition=none (p=reject,d=none,d.eval=none) policy.policy-from=p header.from=hamachi.org; iprev=pass smtp.remote-ip=173.11.94.225 (the-governor.hamachi.org); spf=pass smtp.mailfrom=sommerfeld@hamachi.org smtp.helo=the-governor.hamachi.org; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=the-governor.hamachi.org policy.ptr=the-governor.hamachi.org; x-return-mx=pass header.domain=hamachi.org policy.is_org=yes (MX Records found: the-governor.hamachi.org,smtp-backup-in.hamachi.org); x-return-mx=pass smtp.domain=hamachi.org policy.is_org=yes (MX Records found: the-governor.hamachi.org,smtp-backup-in.hamachi.org); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=0 state=0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lists.illumos.org; h= message-id:date:mime-version:to:content-type :content-transfer-encoding:list-help:list-id:list-post :list-subscribe:reply-to:subject:from:list-unsubscribe; s= dkim-1; t=1730144722; x=1730231122; bh=/X6RpDgGisUbkU+6RZ9jmIr3A TC4lsC/N1nAPyOBbds=; b=YIO0OpttW2gFBUR01rE+sDNmXEnRaW0nneS0sb/oZ Xwqh/zxA3OEMxJn+Xa3Vo5G1ibj336ybZ3FT1DTDt+jxCwqWsZMfeCPi4h/u9OBy Exk3OZJqb9S+1Q+7t04c5zve7GG01v4xokZLqWaswwF3v8Hm9etBNn2yCvrjq69U T4= Received: from tb-mx0.topicbox.com (localhost.local [127.0.0.1]) by tb-mx0.topicbox.com (Postfix) with ESMTP id 2E7D6FD401 for ; Mon, 28 Oct 2024 15:43:28 -0400 (EDT) (envelope-from sommerfeld@hamachi.org) Received: from tb-mx0.topicbox.com (localhost [127.0.0.1]) by tb-mx0.topicbox.com (Authentication Milter) with ESMTP id A551B84B74C; Mon, 28 Oct 2024 15:43:28 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1730144608; b=UnL6+5F3RoCeWm05RtQFY/fa+lNaKf1AwB1qG/Dh0sHatVTjHy hfVAI8npVF0/BJGZdoRfHWjpcMUdVVr9aYOVNXi9Z6/Fv0XAOabIw6SFJniApznW JRnLuQsrCyG77G26b9ZQg4j6ofWODphRjPdfoQNXC9hhTnmn1FPKRryujw0XE9pj T+Vm5xyvCFOjmZQEI9jUnGg2gaM3VljVLlur3eIoC1IWD8/t6bUaqIdK8XI2TvTB QYNOwlJYnhfbLYicqYUilL65shpo3A/Vhs5VDeoEemeBAKH+fIa3eoZyEf8RH1CG a4Ron9SJ6Eb5Pi7BXMC/cMe6GzrVJ1ePz0aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=message-id:date:mime-version:to:subject:from :content-type:content-transfer-encoding; s=arcseal; t= 1730144608; bh=df3Vlnqx5AnyCxXtnhU04c4K1OJNW8MwkeDLNJBeY8I=; b=m BJSL9zQRP+EkcjUekwUYJSThOJ0r7t/2r63xQZjoAYe1vFWudfqVhl5lxBeGRa7h tVIuNQqZu8Gtcokg/zjq7DOUgNT7so9zJX29zQu1OD7aPNSzBLMtmYQyYVKmXOGK 8VHLEoTC/aDaDHhF+ONZzSiOkyBqIc9BA9CZdCakHNpi8rTuEIWuwqLu3i/rXPjz abjLqbC7kTiT2BeXJ7jXu+2u7ajxrcqFXZdiOfu6PB2FJm4usQ92uN6EKgs5RFsh KqOXBnyBWiR8kfq1hzxM/pB9Y+jQKF+yM5Cya9R/2yCSb6zfQXLDA7ELVwqUMvk3 LYrSC5N2lEUxvKP8gyLOg== ARC-Authentication-Results: i=1; tb-mx0.topicbox.com; arc=none (no signatures found); bimi=none (No BIMI records found); dkim=pass (2048-bit rsa key sha256) header.d=hamachi.org header.i=@hamachi.org header.b=pfxwo2Kh header.a=rsa-sha256 header.s=hamachi-202410 x-bits=2048; dmarc=pass policy.published-domain-policy=reject policy.applied-disposition=none policy.evaluated-disposition=none (p=reject,d=none,d.eval=none) policy.policy-from=p header.from=hamachi.org; iprev=pass smtp.remote-ip=173.11.94.225 (the-governor.hamachi.org); spf=pass smtp.mailfrom=sommerfeld@hamachi.org smtp.helo=the-governor.hamachi.org; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=the-governor.hamachi.org policy.ptr=the-governor.hamachi.org; x-return-mx=pass header.domain=hamachi.org policy.is_org=yes (MX Records found: the-governor.hamachi.org,smtp-backup-in.hamachi.org); x-return-mx=pass smtp.domain=hamachi.org policy.is_org=yes (MX Records found: the-governor.hamachi.org,smtp-backup-in.hamachi.org); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=0 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdejledguddtudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecunecujfgurhepkfffgg gfvffuhfgtgfesthejredttddvjeenucfhrhhomhepuehilhhlucfuohhmmhgvrhhfvghl ugcuoehsohhmmhgvrhhfvghlugeshhgrmhgrtghhihdrohhrgheqnecuggftrfgrthhtvg hrnhepuedukeeuieeuheeiieduleekteevleeifeegudehtefhueffhfduledugfeugfeu necuffhomhgrihhnpehilhhluhhmohhsrdhorhhgnecukfhppedujeefrdduuddrleegrd dvvdehpddviedtfeemfedtvdegmegvtdehmegrsgdttdemmeefnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehinhgvthepudejfedruddurdelgedrvddvhedphhgvlh hopehthhgvqdhgohhvvghrnhhorhdrhhgrmhgrtghhihdrohhrghdpmhgrihhlfhhrohhm peeoshhomhhmvghrfhgvlhgusehhrghmrggthhhirdhorhhgqedpnhgspghrtghpthhtoh epuddprhgtphhtthhopeeouggvvhgvlhhophgvrheslhhishhtshdrihhllhhumhhoshdr ohhrgheq X-ME-VSScore: 0 X-ME-VSCategory: clean Received-SPF: pass (hamachi.org: 173.11.94.225 is authorized to use 'sommerfeld@hamachi.org' in 'mfrom' identity (mechanism 'mx' matched)) receiver=tb-mx0.topicbox.com; identity=mailfrom; envelope-from="sommerfeld@hamachi.org"; helo=the-governor.hamachi.org; client-ip=173.11.94.225 Received: from the-governor.hamachi.org (the-governor.hamachi.org [173.11.94.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx0.topicbox.com (Postfix) with ESMTPS for ; Mon, 28 Oct 2024 15:43:27 -0400 (EDT) (envelope-from sommerfeld@hamachi.org) Received: from [IPV6:2603:3024:e05:ab00::3] (hydra.hamachi.org [IPv6:2603:3024:e05:ab00::3]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sommerfeld) by the-governor.hamachi.org (Postfix) with ESMTPSA id 6F5C76BD0; Mon, 28 Oct 2024 12:43:24 -0700 (PDT) Message-ID: <3d9ac932-06d4-4d97-bd8e-4bbdd574155f@hamachi.org> Date: Mon, 28 Oct 2024 12:43:23 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: developer@lists.illumos.org Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: ea0c44c0-9564-11ef-9a41-b003098c7b06 Archived-At: =?UTF-8?B?PGh0dHBzOi8vaWxsdW1vcy50b3BpY2JveC5jb20vZ3JvdXBz?= =?UTF-8?B?L2RldmVsb3Blci9UOTM1NDI4ZjE3ZGMzZDg4My1NMDJhN2YxMTA3NmFhZDM5?= =?UTF-8?B?MWM1NjU3NjFhPg==?= List-Help: List-Id: "illumos-developer" List-Post: List-Software: Topicbox v0 List-Subscribe: Precedence: list Reply-To: illumos-developer Subject: [developer] [REVIEW] 16585 ping ignores ipv6 scope id in target address From: "Bill Sommerfeld via illumos-developer" List-Unsubscribe: , Topicbox-Delivery-ID: 2:illumos:a901537c-2aea-11e7-965f-d98f9f16e227:81958daa-7202-11ef-bbf2-18142b2d11b0:M02a7f11076aad391c565761a:1:WNmjtBOgrPItCutf8pjCmWP-0SpTX9WV6EUEr6z0ZgM Issue: https://www.illumos.org/issues/16585 CR: https://code.illumos.org/c/illumos-gate/+/3755 Diff:=20 https://code.illumos.org/~diff/91dc2df4483aaa88d9a9bc35b73956d795bcf4d0 Next in my queue of ipv6 scope fixes, the "ping" command: Ping accepts addresses with attached scope, as in this link-local multicast "all nodes" ping: ping ff02::1%lan0 but discards the scope, leading to potential confusion (it sends the ping out the wrong interface). The fix generally involves deferring disassembly of the "struct sockaddr_in6" so the scope is available alongside the address. Also along for the ride (and, alas, dominating the diffs) are some other source cleanups: - Printing the scope tag for received traffic. - Printing a warning when a scoped address is used along with the "-i" option (another way to specify a specific output interface). - Moving function prototype declarations for external functions from ping*.c to ping. - Restructuring the "pr_name" function into address-family-specific variants to reduce the amount of casting required. - cstyle whitespace fixes Thanks in advance for your review. - Bill ------------------------------------------ illumos: illumos-developer Permalink: https://illumos.topicbox.com/groups/developer/T935428f17dc3d883-= M02a7f11076aad391c565761a Delivery options: https://illumos.topicbox.com/groups/developer/subscription