From: Toomas Soome <tsoome@me.com>
To: illumos-developer <developer@lists.illumos.org>
Subject: REVIEW: 15685 iscsi: the comparison will always evaluate as 'true'
Date: Tue, 23 May 2023 14:53:05 +0300 [thread overview]
Message-ID: <426E955B-B7F4-4091-AC30-513396470C0E@me.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 155 bytes --]
Hi!
Please review: https://code.illumos.org/c/illumos-gate/+/2875
bunch of never-NULL string pointers are used in if statements…
thanks,
toomas
[-- Attachment #2: Type: text/html, Size: 925 bytes --]
next reply other threads:[~2023-05-23 11:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 11:53 Toomas Soome [this message]
2024-05-24 11:04 ` Toomas Soome
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=426E955B-B7F4-4091-AC30-513396470C0E@me.com \
--to=tsoome@me.com \
--cc=developer@lists.illumos.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).