From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from tb-mx0.topicbox.com (localhost.local [127.0.0.1]) by tb-mx0.topicbox.com (Postfix) with ESMTP id E11BA19F7562 for ; Tue, 23 May 2023 07:53:18 -0400 (EDT) (envelope-from tsoome@me.com) Received: from tb-mx0.topicbox.com (localhost [127.0.0.1]) by tb-mx0.topicbox.com (Authentication Milter) with ESMTP id 6A818050B82; Tue, 23 May 2023 07:53:18 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1684842798; b=PY2+EL1HWz+sZ6nocA34KK39Ow+VNZDgNWILRcj9mr8L+oq32x anQqDNXPk9+DxP+wfu4/vjJqss6ik3KVgs4F97XmOGfbUhPp+lquf6/YrmMKpzfT NjGSYKm2mbIcwY7tttPdxR0/o4KCy08ZlgyVFqeM9mNgQMAaQv74HzBcqcPp9mKd rDqRpnHBbPJuaRKclYmkQfUAx28d3oreLpHWyv8zatdpLW04afFMwAgw+BMrUIT6 MIUNhuHnLOvcrjwy+aWcDoixzkVJVHUJWzZVvPp2YZtayENS1ofkPqit9DWu7Zy+ Otx7we+JYr6xscWPi6fbjSAJBfQ+aE3Gt8Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=from:content-type:mime-version:subject :message-id:date:to; s=arcseal; t=1684842798; bh=4ZevXNEGwG62Pi5 0p7F7JuhtduUSs285y0mqkWlQNRE=; b=rZ/QlsCGZTvyVTCV6TP9aQYfKSubFBX f7B1KJFRtWYA8PWXQ6FInPUpp1SVNwOgvyFc6HbiG56EsDEFpBRYLqO/vL+TOXCM DPf/l8LyTiq3smr4S3GE18J5udTBrzzg90j6LB8ffMoGJ9c+/Wz3ThSYOYLk8G+R Hsx5gvfOCzguzOrdQe1SzY4zudvp+iM+x4onw/xgAr/kKxAyUlxnNKNnDblIR4dC 3zTxhkVVBxtFoNeaBMCFYPvFcMe2LlvLtmpJ+lhnJBiOmaESPLmlcf7SP2to+CR3 R1EGsTQUd+mTxH/trYLIHJhItibVYVcuP7tKcaPFIvsHli7B57eOinw== ARC-Authentication-Results: i=1; tb-mx0.topicbox.com; arc=none (no signatures found); bimi=declined (Domain declined to participate); dkim=pass (2048-bit rsa key sha256) header.d=me.com header.i=@me.com header.b=jJ/bNmLM header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=me.com; iprev=pass smtp.remote-ip=17.58.63.172 (st43p00im-ztfb10061701.me.com); spf=pass smtp.mailfrom=tsoome@me.com smtp.helo=st43p00im-ztfb10061701.me.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=st43p00im-ztfb10061701.me.com policy.ptr=st43p00im-ztfb10061701.me.com; x-return-mx=pass header.domain=me.com policy.is_org=yes (MX Records found: mx02.mail.icloud.com,mx01.mail.icloud.com); x-return-mx=pass smtp.domain=me.com policy.is_org=yes (MX Records found: mx02.mail.icloud.com,mx01.mail.icloud.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 Authentication-Results: tb-mx0.topicbox.com; arc=none (no signatures found); bimi=declined (Domain declined to participate); dkim=pass (2048-bit rsa key sha256) header.d=me.com header.i=@me.com header.b=jJ/bNmLM header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=me.com; iprev=pass smtp.remote-ip=17.58.63.172 (st43p00im-ztfb10061701.me.com); spf=pass smtp.mailfrom=tsoome@me.com smtp.helo=st43p00im-ztfb10061701.me.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=st43p00im-ztfb10061701.me.com policy.ptr=st43p00im-ztfb10061701.me.com; x-return-mx=pass header.domain=me.com policy.is_org=yes (MX Records found: mx02.mail.icloud.com,mx01.mail.icloud.com); x-return-mx=pass smtp.domain=me.com policy.is_org=yes (MX Records found: mx02.mail.icloud.com,mx01.mail.icloud.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejfedggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephfgtggfukfffvffosegrtdhmrehhtdejnecuhfhr ohhmpefvohhomhgrshcuufhoohhmvgcuoehtshhoohhmvgesmhgvrdgtohhmqeenucggtf frrghtthgvrhhnpeekheduiedvudehjedtteejtdffffefheffleffvddtteeifeehgfeg veeutdelfeenucffohhmrghinhepihhllhhumhhoshdrohhrghenucfkphepudejrdehke drieefrddujedvpddujedrgedvrddvhedurdegudenucevlhhushhtvghrufhiiigvpedt necurfgrrhgrmhepihhnvghtpedujedrheekrdeifedrudejvddphhgvlhhopehsthegfe hptddtihhmqdiithhfsgdutddtiedujedtuddrmhgvrdgtohhmpdhmrghilhhfrhhomhep oehtshhoohhmvgesmhgvrdgtohhmqe X-ME-VSScore: -100 X-ME-VSCategory: clean Received-SPF: pass (me.com: 17.58.63.172 is authorized to use 'tsoome@me.com' in 'mfrom' identity (mechanism 'ip4:17.58.0.0/16' matched)) receiver=tb-mx0.topicbox.com; identity=mailfrom; envelope-from="tsoome@me.com"; helo=st43p00im-ztfb10061701.me.com; client-ip=17.58.63.172 Received: from st43p00im-ztfb10061701.me.com (st43p00im-ztfb10061701.me.com [17.58.63.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx0.topicbox.com (Postfix) with ESMTPS for ; Tue, 23 May 2023 07:53:18 -0400 (EDT) (envelope-from tsoome@me.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1684842798; bh=4ZevXNEGwG62Pi50p7F7JuhtduUSs285y0mqkWlQNRE=; h=From:Content-Type:Mime-Version:Subject:Message-Id:Date:To; b=jJ/bNmLMNWt3IGGIhJOuvV6c/QWmjfTT7T3rxbHVr9P6rNkG0lVK5WaS5GGBY9+Cf 0NaKun6X0xC+v6+2E64sPZtCApxvrJkvNXcmFWLq0AYZeX3EMRhttExW9ZX3UdoYHP TXM3tmEvqO1VuHpLRhqbXGNHo+CTnQqALv+bklvaZUOVQD/L8pOakYz8lG4TJkvZD2 p6HwfL4oOb30HXJgpACUnAfYPbicum7ZWMYtJK1pA70QsBLtZuVKfJTyTcnlfxPDa4 8HYQTbKWW71MTev66ySXsJhx6YOt8FSH1Xej6yxy0BeBfgK7hclb8QNeuMbh9JNqu6 KKB3c1fli0UTw== Received: from smtpclient.apple (st43p00im-dlb-asmtp-mailmevip.me.com [17.42.251.41]) by st43p00im-ztfb10061701.me.com (Postfix) with ESMTPSA id 84A672E06CF for ; Tue, 23 May 2023 11:53:17 +0000 (UTC) From: Toomas Soome Content-Type: multipart/alternative; boundary="Apple-Mail=_1C7C5F45-6D6A-4CBE-A124-2BC27C48282D" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: REVIEW: 15685 iscsi: the comparison will always evaluate as 'true' Message-Id: <426E955B-B7F4-4091-AC30-513396470C0E@me.com> Date: Tue, 23 May 2023 14:53:05 +0300 To: illumos-developer X-Mailer: Apple Mail (2.3731.600.7) X-Proofpoint-GUID: -50RiqRv9sTjh6oEcSkEhi02-Z8mheTG X-Proofpoint-ORIG-GUID: -50RiqRv9sTjh6oEcSkEhi02-Z8mheTG X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.573,18.0.572,17.11.170.22.0000000_definitions?= =?UTF-8?Q?=3D2023-05-17=5F02:2023-05-17=5F02,2020-02-14=5F11,2023-02-09?= =?UTF-8?Q?=5F01_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 bulkscore=0 malwarescore=0 clxscore=1015 spamscore=0 mlxscore=0 mlxlogscore=570 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2305230095 Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: 6b6d8706-f960-11ed-b41b-d7f4018c7b06 --Apple-Mail=_1C7C5F45-6D6A-4CBE-A124-2BC27C48282D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi! Please review: https://code.illumos.org/c/illumos-gate/+/2875 bunch of never-NULL string pointers are used in if statements=E2=80=A6 thanks, toomas= --Apple-Mail=_1C7C5F45-6D6A-4CBE-A124-2BC27C48282D Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Hi!

Please review: https://code.illumos.org/c/illumos-gate/+/2875

bunch of never-NULL = string pointers are used in if = statements=E2=80=A6

thanks,
toomas
= --Apple-Mail=_1C7C5F45-6D6A-4CBE-A124-2BC27C48282D--