From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: * X-Spam-Status: No, score=1.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE, MAILING_LIST_MULTI,SUBJ_LACKS_WORDS autolearn=no autolearn_force=no version=3.4.4 Received: from tb-ob1.topicbox.com (tb-ob1.topicbox.com [64.147.108.173]) by inbox.vuxu.org (Postfix) with ESMTP id 775CC29C42 for ; Thu, 3 Oct 2024 09:53:05 +0200 (CEST) Received: from tb-mx0.topicbox.com (tb-mx0.nyi.icgroup.com [10.90.30.73]) by tb-ob1.topicbox.com (Postfix) with ESMTP id 6CF9D20C83 for ; Thu, 3 Oct 2024 03:53:05 -0400 (EDT) (envelope-from bounce.mMff6316b884fefce90ad17e80.r81958daa-7202-11ef-bbf2-18142b2d11b0@illumos.bounce.topicbox.com) Received: by tb-mx0.topicbox.com (Postfix, from userid 1132) id 6572A2817D9F; Thu, 3 Oct 2024 03:53:05 -0400 (EDT) ARC-Authentication-Results: i=2; topicbox.com; arc=pass; dkim=pass (2048-bit rsa key sha256) header.d=me.com header.i=@me.com header.b=w1OtMj2f header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=me.com; spf=pass smtp.mailfrom=tsoome@me.com smtp.helo=pv50p00im-hyfv10011601.me.com; x-internal-arc=fail (as.1.topicbox.com=pass, ams.1.topicbox.com=fail (message has been altered)) (Message modified while forwarding at Topicbox) ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=content-type:mime-version:message-id:date:to :list-help:list-id:list-post:list-subscribe:reply-to:subject :content-transfer-encoding:from:list-unsubscribe; s=sysmsg-1; t= 1727941985; bh=itw4/Hedtk5mhu4e50KVwXZScidSq04nKQGJB7/Ym4w=; b=g stPVk+2BkTopASH5VMzGhtiW13iUfljKTzTWxZp5jMXc7qdrzLi47nqPtasY0HLQ DdAGNZ1BXULG5OD7ieve8DOgTPx+/PE3NPly/zxJQAaCo8I0vqeRkRV5zZIDkW2h 3shuSnheKy/posqlACQgej8Rm3frxlt4cEhjSrCyq4= ARC-Seal: i=2; a=rsa-sha256; cv=pass; d=topicbox.com; s=sysmsg-1; t= 1727941985; b=rPEVwvzMikA6teUgEO2dwksqztkcuRxnFQI/vkFdK06yYeXd7y rqvxAFUmMuAkamtx0jlHKYQAjj5PW7DKkXIKUjInjte6SMzpHJtFOt/9z0ZjbeAR 52ONXrat1f5H8hCWAvNWBZ7uf9SfgcDCgumGTD4rT1m+1hF8l1YZeSbIo= Authentication-Results: topicbox.com; arc=pass; dkim=pass (2048-bit rsa key sha256) header.d=me.com header.i=@me.com header.b=w1OtMj2f header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=me.com; spf=pass smtp.mailfrom=tsoome@me.com smtp.helo=pv50p00im-hyfv10011601.me.com; x-internal-arc=fail (as.1.topicbox.com=pass, ams.1.topicbox.com=fail (message has been altered)) (Message modified while forwarding at Topicbox) X-Received-Authentication-Results: tb-mx1.topicbox.com; arc=none (no signatures found); bimi=declined (Domain declined to participate); dkim=pass (2048-bit rsa key sha256) header.d=me.com header.i=@me.com header.b=w1OtMj2f header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=me.com; iprev=pass smtp.remote-ip=17.58.6.43 (pv50p00im-hyfv10011601.me.com); spf=pass smtp.mailfrom=tsoome@me.com smtp.helo=pv50p00im-hyfv10011601.me.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=pv50p00im-hyfv10011601.me.com policy.ptr=pv50p00im-hyfv10011601.me.com; x-return-mx=pass header.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-return-mx=pass smtp.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lists.illumos.org; h= content-type:mime-version:message-id:date:to:list-help:list-id :list-post:list-subscribe:reply-to:subject :content-transfer-encoding:from:list-unsubscribe; s=dkim-1; t= 1727941985; x=1728028385; bh=7bzpRIINIoApzCZR8pY6+NFnKrigxiMKFV9 kGWimwxs=; b=UBxnhO0+zfI7UUzBJ9pnzXxuoHUmI6NTGVtF2eP/S/m2Nckw2uI VHNR1AIwgS/nU9GRYcldGCg8vCBMYgSfoATlmaeFYaglMp/5GAlcZC0UBPgmpgu1 Qw0JH7A3fDt+DgiUng94pRpc74tWZCwBxgJiaWZaroGxQbLnXVkhXT0I= Received: from tb-mx1.topicbox.com (localhost.local [127.0.0.1]) by tb-mx1.topicbox.com (Postfix) with ESMTP id 4484C239E804 for ; Thu, 3 Oct 2024 03:51:17 -0400 (EDT) (envelope-from tsoome@me.com) Received: from tb-mx1.topicbox.com (localhost [127.0.0.1]) by tb-mx1.topicbox.com (Authentication Milter) with ESMTP id EB7192B269F; Thu, 3 Oct 2024 03:51:17 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1727941877; b=oI1hddIGND03UOAckCGg8MQyIKBJJaKUMvoq0dFBikrImuTBi4 loIhJmXZNuPfxTQfnt/I4tqmpXmKcJm9uOhyxcACuUdVVEpVh+2tVqmBD0XCvIAy 6mGUhOTgUHW9d43ougBYBk3tcT3itB9wFsIrruU8A4VqMlmczCAmHl0yTIOFMjTY CzTgEU3k3GvsAFy7LYI9NvQeMVt+lefEXp3YYfpqohOkECBSiz1QGbgJLTN7Wngx GK8yKux3CG+gXIAWJeqvCKYXPybeWmZr7wZtjCKw3OAZnNY3KZ0DuilX058Uea1T WK7N2Pes/UZkh24FkTpzKAHnUt8pQnm27LQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=from:content-type:mime-version:subject :message-id:date:to; s=arcseal; t=1727941877; bh=z461DONk026ImRj xSkm5Vfz8BLMtvrRBFVWqLAki4QA=; b=Sm4Wylh7z9cwvAeRAZaDk/S19XRN7/W vRMwq34f84SjI6IS8HaNxQ78O9yMCsweDddUEv6ofoU8CJUAnqm/WsnV2ggJkdW5 MIjXyMcw33IOqgr7H8FtMcR9zBprIpYfcDvrTNPdPvot6Qbmp4OXYlkT27rzc6TM qdTplHUaLnyenBJTUTCUDTdrSZLbO23DiG0vu3v6TcsfAV9Ct1PaAA1c41h8BTDt C2yBDjR+QmZHpIckWhZLQRIUT5Wcl3jxbUHCrG9JSH9eQ99Cb0RidoNyqihApOfY yfb3WN8YWEfG5TeMsoOGsom/NulsdX3S9iFPuAvXVgEkTr047R4rZIg== ARC-Authentication-Results: i=1; tb-mx1.topicbox.com; arc=none (no signatures found); bimi=declined (Domain declined to participate); dkim=pass (2048-bit rsa key sha256) header.d=me.com header.i=@me.com header.b=w1OtMj2f header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=me.com; iprev=pass smtp.remote-ip=17.58.6.43 (pv50p00im-hyfv10011601.me.com); spf=pass smtp.mailfrom=tsoome@me.com smtp.helo=pv50p00im-hyfv10011601.me.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=pv50p00im-hyfv10011601.me.com policy.ptr=pv50p00im-hyfv10011601.me.com; x-return-mx=pass header.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-return-mx=pass smtp.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgeeftddrvddvtddguddvjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhtggguffkfffvofesrgdtmherhhdtjeenucfh rhhomhepvfhoohhmrghsucfuohhomhgvuceothhsohhomhgvsehmvgdrtghomheqnecugg ftrfgrthhtvghrnhepkeehudeivdduheejtdetjedtfffffeehffelffdvtdetieefhefg geevuedtleefnecuffhomhgrihhnpehilhhluhhmohhsrdhorhhgnecukfhppedujedrhe ekrdeirdegfedpudejrdehiedrledruddtnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehinhgvthepudejrdehkedriedrgeefpdhhvghlohepphhvhedtphdttdhimh dqhhihfhhvuddttdduudeitddurdhmvgdrtghomhdpmhgrihhlfhhrohhmpeeothhsohho mhgvsehmvgdrtghomheqpdhnsggprhgtphhtthhopedupdhrtghpthhtohepoeguvghvvg hlohhpvghrsehlihhsthhsrdhilhhluhhmohhsrdhorhhgqe X-ME-VSScore: -100 X-ME-VSCategory: clean Received-SPF: pass (me.com: 17.58.6.43 is authorized to use 'tsoome@me.com' in 'mfrom' identity (mechanism 'ip4:17.58.0.0/16' matched)) receiver=tb-mx1.topicbox.com; identity=mailfrom; envelope-from="tsoome@me.com"; helo=pv50p00im-hyfv10011601.me.com; client-ip=17.58.6.43 Received: from pv50p00im-hyfv10011601.me.com (pv50p00im-hyfv10011601.me.com [17.58.6.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx1.topicbox.com (Postfix) with ESMTPS for ; Thu, 3 Oct 2024 03:51:16 -0400 (EDT) (envelope-from tsoome@me.com) Received: from smtpclient.apple (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-hyfv10011601.me.com (Postfix) with ESMTPSA id B6841C8026A for ; Thu, 3 Oct 2024 07:51:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="Apple-Mail=_FAA49D00-DF38-4635-AD90-7DB63C6CDCB6" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\)) Message-Id: <4A483101-A294-4E24-96E1-899F37B7F69A@me.com> Date: Thu, 3 Oct 2024 10:50:48 +0300 To: illumos-developer X-Mailer: Apple Mail (2.3818.100.11.1.3) X-Proofpoint-ORIG-GUID: rkHeWJqahVcVr_PiRcubl4JFVjOr4NiT X-Proofpoint-GUID: rkHeWJqahVcVr_PiRcubl4JFVjOr4NiT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-03_06,2024-10-03_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0 mlxscore=0 adultscore=0 suspectscore=0 clxscore=1015 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2410030055 Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: 484a9b44-815c-11ef-b4f6-9e68ca78c228 Archived-At: =?UTF-8?B?PGh0dHBzOi8vaWxsdW1vcy50b3BpY2JveC5jb20vZ3JvdXBz?= =?UTF-8?B?L2RldmVsb3Blci9UNmU5MGNmNTk4Zjk3ZjdmYi1NZmY2MzE2Yjg4NGZlZmNl?= =?UTF-8?B?OTBhZDE3ZTgwPg==?= List-Help: List-Id: "illumos-developer" List-Post: List-Software: Topicbox v0 List-Subscribe: Precedence: list Reply-To: illumos-developer Subject: [developer] REVIEW: 13897 & 16822 Content-Transfer-Encoding: 7bit From: "Toomas Soome via illumos-developer" List-Unsubscribe: , Topicbox-Delivery-ID: 2:illumos:a901537c-2aea-11e7-965f-d98f9f16e227:81958daa-7202-11ef-bbf2-18142b2d11b0:Mff6316b884fefce90ad17e80:1:6mZgvL7fBDWtp4AkqXOSCyVKi_hN26cyh5EKTEQLhtY --Apple-Mail=_FAA49D00-DF38-4635-AD90-7DB63C6CDCB6 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 hi! Please review: 13897 loader: implement mount/unmount rootfs https://code.illumos.org/c/illumos-gate/+/1564 and 16822 EFI loader: Don't free bcache for DEVT_DISK devs https://code.illumos.org/c/illumos-gate/+/3726 Those are logically related updates addressing the same problem, which is l= osing cached data (in loader block cache) as we repeatedly open and close f= iles from the same rootfs and with every open, we need to re-read the file = system metadata. The solution there is to keep rootfs =E2=80=9Cmounted=E2= =80=9D, that is, keep its metadata till we change value of =E2=80=9Ccurrde= v=E2=80=9D variable. Since we do not have integrated the metrics mechanism to make it possible t= o measure the speedup (referred in the issue #16822), we only can do limite= d measurements and need to rely on performance data posted with FreeBSD com= mits. Thanks, Toomas ------------------------------------------ illumos: illumos-developer Permalink: https://illumos.topicbox.com/groups/developer/T6e90cf598f97f7fb-= Mff6316b884fefce90ad17e80 Delivery options: https://illumos.topicbox.com/groups/developer/subscription --Apple-Mail=_FAA49D00-DF38-4635-AD90-7DB63C6CDCB6 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=UTF-8 hi!

Please review:

13897 loader: = implement mount/unmount rootfs

https://c= ode.illumos.org/c/illumos-gate/+/1564


and

16822 EFI loader: Do= n't free bcache for DEVT_DISK devs

=

https://code.illumos.org/c/illumos-gate/+/3726


Those are logically related updates addressing the same problem, which is = losing cached data (in loader block cache) as we repeatedly open and close = files from the same rootfs and with every open, we need to re-read the file= system metadata. The solution there is to keep rootfs “mounted&rdquo= ;, that is, keep its metadata till we change  value of “currdev&= rdquo; variable.


Since we do not have integrated the me= trics mechanism to make it possible to measure the speedup (referred in the= issue #16822), we only can do limited measurements and need to rely on per= formance data posted with FreeBSD commits.


Thanks,

Toomas

= --Apple-Mail=_FAA49D00-DF38-4635-AD90-7DB63C6CDCB6--