public inbox for developer@lists.illumos.org (since 2011-08)
 help / color / mirror / Atom feed
From: Bill Sommerfeld <sommerfeld@hamachi.org>
To: developer@lists.illumos.org
Subject: [REVIEW] 16742 VERSION set in env/illumos may be unrelated to build tree
Date: Thu, 29 Aug 2024 17:12:29 -0700	[thread overview]
Message-ID: <4ef03fe8-db2c-4121-a1d6-e317a7c67c7e@hamachi.org> (raw)

Issue: https://www.illumos.org/issues/16742
CR: https://code.illumos.org/c/illumos-gate/+/3654
Diff: 
https://code.illumos.org/~diff/668d0a86fb66e14b87927873193c6660ff8a10d5

While working on 16719 I realized that there's a flaw in how VERSION
is set in the env file.

In short, it's set too soon - it runs a "git describe" on whatever
happens to be the current directory where nightly is being run.  That
directory might not be inside $CODEMGR_WS (or even inside a git tree
at all).

So I think it's best to move the logic to set a default VERSION into
nightly itself.

This will reorder the sections within the mail_msg file - the "Build
version" section will appear slightly later, just before the
"Bootstrap build errors" section.

Thanks in advance for your review.






                 reply	other threads:[~2024-08-30  0:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ef03fe8-db2c-4121-a1d6-e317a7c67c7e@hamachi.org \
    --to=sommerfeld@hamachi.org \
    --cc=developer@lists.illumos.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).