* [REVIEW] 16742 VERSION set in env/illumos may be unrelated to build tree
@ 2024-08-30 0:12 Bill Sommerfeld
0 siblings, 0 replies; only message in thread
From: Bill Sommerfeld @ 2024-08-30 0:12 UTC (permalink / raw)
To: developer
Issue: https://www.illumos.org/issues/16742
CR: https://code.illumos.org/c/illumos-gate/+/3654
Diff:
https://code.illumos.org/~diff/668d0a86fb66e14b87927873193c6660ff8a10d5
While working on 16719 I realized that there's a flaw in how VERSION
is set in the env file.
In short, it's set too soon - it runs a "git describe" on whatever
happens to be the current directory where nightly is being run. That
directory might not be inside $CODEMGR_WS (or even inside a git tree
at all).
So I think it's best to move the logic to set a default VERSION into
nightly itself.
This will reorder the sections within the mail_msg file - the "Build
version" section will appear slightly later, just before the
"Bootstrap build errors" section.
Thanks in advance for your review.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-08-30 0:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-30 0:12 [REVIEW] 16742 VERSION set in env/illumos may be unrelated to build tree Bill Sommerfeld
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).