From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from tb-mx1.topicbox.com (localhost.local [127.0.0.1]) by tb-mx1.topicbox.com (Postfix) with ESMTP id 9F6F220FB2BC for ; Thu, 29 Aug 2024 20:12:46 -0400 (EDT) (envelope-from sommerfeld@hamachi.org) Received: from tb-mx1.topicbox.com (localhost [127.0.0.1]) by tb-mx1.topicbox.com (Authentication Milter) with ESMTP id 09A9DF723A7; Thu, 29 Aug 2024 20:12:46 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1724976766; b=HEeHLdnkYd23vJtj9gobJW/7Mab4LFEB8He8hgstxFCoB9Wctd k53oti+VsV8MyGQc9BZf22vTKUJ53XngfONfSh/FW/94O75/+CKvrjaiwY73FmUJ Pqmz+pE/lG0RARpfX4QQhljoeSUmxfx1z8TS2tijfUMOIW47O7teBfIx0r273WYJ sGfakKpV+6vqx5kwSDWuHhSM4++Y0C4jjWsM/4n7t83rTO0R46hXmBwW3ioARDV7 0qs4uCtJfZgAVWw0yIqaiyhr/BDuaC4LYQG1UVc4FxTMbTv5A2X8b9H+0E7apeAn QaVvlS0ntKLjxGQxFAnYtj8FcQJqD7QB/QCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=message-id:date:mime-version:to:subject:from :content-type:content-transfer-encoding; s=arcseal; t= 1724976766; bh=eR3ez6uheDYusim6jOPe6S1/Bbq88ssTfZwxwE55DKA=; b=j nAYpo3jNqJN/MclquBG+zteYqluETbM0nqf1vcr5Xb89R+kEl7q4fBo3m0ezOAc6 0j50LnHX+SgHHteDHexV23YnOmdI6GOUZOSJojoEZSOQ0cHsSJVJWDyePDjrqoOr Yer9W6HzoYRxxGe6OxMVuvH3e7030CRlCC/Y/VKATWBZeceZoyMzxlzfWkd1QeQT vkmQ2qf4SFgcrAkZo5RBjqsU+C+j4hp/UYCsOxaiy7t19Vsf3eZUz71G3hKIJ8a1 D7bDSiSKQrmfyUXy3JMpAJa2Q1zV4s1I14x1ZcxtlNSFl7JSPw1qx4yxy9j3u5eb YIbo9AVFkDi+JDOhZPFLA== ARC-Authentication-Results: i=1; tb-mx1.topicbox.com; arc=none (no signatures found); bimi=none (No BIMI records found); dkim=pass (2048-bit rsa key sha256) header.d=hamachi.org header.i=@hamachi.org header.b=fe2dasnV header.a=rsa-sha256 header.s=hamachi-202408 x-bits=2048; dmarc=pass policy.published-domain-policy=reject policy.applied-disposition=none policy.evaluated-disposition=none (p=reject,d=none,d.eval=none) policy.policy-from=p header.from=hamachi.org; iprev=pass smtp.remote-ip=173.11.94.225 (the-governor.hamachi.org); spf=pass smtp.mailfrom=sommerfeld@hamachi.org smtp.helo=the-governor.hamachi.org; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=the-governor.hamachi.org policy.ptr=the-governor.hamachi.org; x-return-mx=pass header.domain=hamachi.org policy.is_org=yes (MX Records found: smtp-backup-in.hamachi.org,the-governor.hamachi.org); x-return-mx=pass smtp.domain=hamachi.org policy.is_org=yes (MX Records found: smtp-backup-in.hamachi.org,the-governor.hamachi.org); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=0 state=0 Authentication-Results: tb-mx1.topicbox.com; arc=none (no signatures found); bimi=none (No BIMI records found); dkim=pass (2048-bit rsa key sha256) header.d=hamachi.org header.i=@hamachi.org header.b=fe2dasnV header.a=rsa-sha256 header.s=hamachi-202408 x-bits=2048; dmarc=pass policy.published-domain-policy=reject policy.applied-disposition=none policy.evaluated-disposition=none (p=reject,d=none,d.eval=none) policy.policy-from=p header.from=hamachi.org; iprev=pass smtp.remote-ip=173.11.94.225 (the-governor.hamachi.org); spf=pass smtp.mailfrom=sommerfeld@hamachi.org smtp.helo=the-governor.hamachi.org; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=the-governor.hamachi.org policy.ptr=the-governor.hamachi.org; x-return-mx=pass header.domain=hamachi.org policy.is_org=yes (MX Records found: smtp-backup-in.hamachi.org,the-governor.hamachi.org); x-return-mx=pass smtp.domain=hamachi.org policy.is_org=yes (MX Records found: smtp-backup-in.hamachi.org,the-governor.hamachi.org); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=0 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgeeftddrudefhedgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfg fvuffhtgfgsehtjeertddtvdejnecuhfhrohhmpeeuihhllhcuufhomhhmvghrfhgvlhgu uceoshhomhhmvghrfhgvlhgusehhrghmrggthhhirdhorhhgqeenucggtffrrghtthgvrh hnpeeuudekueeiueehieeiudelkeetveelieefgeduheethfeufffhudeludfguefgueen ucffohhmrghinhepihhllhhumhhoshdrohhrghenucfkphepudejfedruddurdelgedrvd dvhedpvdeitdefmeeftddvgeemvgdtheemrggstddtmeemfeenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepihhnvghtpedujeefrdduuddrleegrddvvdehpdhhvghloh epthhhvgdqghhovhgvrhhnohhrrdhhrghmrggthhhirdhorhhgpdhmrghilhhfrhhomhep oehsohhmmhgvrhhfvghlugeshhgrmhgrtghhihdrohhrgheqpdhnsggprhgtphhtthhope dupdhrtghpthhtohepoeguvghvvghlohhpvghrsehlihhsthhsrdhilhhluhhmohhsrdho rhhgqe X-ME-VSScore: 0 X-ME-VSCategory: clean Received-SPF: pass (hamachi.org: 173.11.94.225 is authorized to use 'sommerfeld@hamachi.org' in 'mfrom' identity (mechanism 'mx' matched)) receiver=tb-mx1.topicbox.com; identity=mailfrom; envelope-from="sommerfeld@hamachi.org"; helo=the-governor.hamachi.org; client-ip=173.11.94.225 Received: from the-governor.hamachi.org (the-governor.hamachi.org [173.11.94.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx1.topicbox.com (Postfix) with ESMTPS for ; Thu, 29 Aug 2024 20:12:45 -0400 (EDT) (envelope-from sommerfeld@hamachi.org) Received: from [IPV6:2603:3024:e05:ab00::3] (hydra.hamachi.org [IPv6:2603:3024:e05:ab00::3]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sommerfeld) by the-governor.hamachi.org (Postfix) with ESMTPSA id BCCD03525; Thu, 29 Aug 2024 17:12:30 -0700 (PDT) Authentication-Results: the-governor.hamachi.org; auth=pass; dkim=pass (2048-bit rsa key sha256) header.d=hamachi.org header.i=@hamachi.org header.b=fe2dasnV header.a=rsa-sha256 header.s=hamachi-202408; x-aligned-from=pass (Address match); x-local-user=pass; x-spam=pass score=-2.00 required=5.00 X-Spam-hits: BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,NO_RECEIVED,NO_RELAYS, T_SCC_BODY_TEXT_LINE X-Spam-Status: No, score=-2.00 required=5.00 X-Spam-score: -2.00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hamachi.org; s=hamachi-202408; t=1724976750; bh=eR3ez6uheDYusim6jOPe6S1/Bbq88ssTfZwxwE55DKA=; h=Date:To:Subject:From; b=fe2dasnVTxWm1ltUzaMm55zZ54xrp3dSVzPuK3SF4Yufxc/I/D9PsRgdtg3zGiqqo S8jmjoG9TPDV7mJ7ssgYtgely3Ofra1XlJSb6ulpIwjwOAS/h1Kl9z2gxyirz14n8x cCN2oYjD+opJWtKhoo5cO+7v1sw24/V/Z1rNloX8ipMGYpVAzghJnHZIRlb1t8I4qg 9j7sdJux5lteVQv5QP7SPuGHyzKmxsuj5eYt/UjUMMjB0NI2eI9sXGN58/a70SUy0+ zxh9S02cIVYL9sEx31p5Z2pXocwhQJeOOULpqYcyMQHdW0uOmioHpK4nXaVmDZ/zU9 EcP7VFBy7bNJw== Message-ID: <4ef03fe8-db2c-4121-a1d6-e317a7c67c7e@hamachi.org> Date: Thu, 29 Aug 2024 17:12:29 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: developer@lists.illumos.org Subject: [REVIEW] 16742 VERSION set in env/illumos may be unrelated to build tree From: Bill Sommerfeld Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: 995fb5f4-6664-11ef-b7f3-e499ccee093e Issue: https://www.illumos.org/issues/16742 CR: https://code.illumos.org/c/illumos-gate/+/3654 Diff: https://code.illumos.org/~diff/668d0a86fb66e14b87927873193c6660ff8a10d5 While working on 16719 I realized that there's a flaw in how VERSION is set in the env file. In short, it's set too soon - it runs a "git describe" on whatever happens to be the current directory where nightly is being run. That directory might not be inside $CODEMGR_WS (or even inside a git tree at all). So I think it's best to move the logic to set a default VERSION into nightly itself. This will reorder the sections within the mail_msg file - the "Build version" section will appear slightly later, just before the "Bootstrap build errors" section. Thanks in advance for your review.