[REVIEW] 16437 workaround gerrit misclassifying awk test T.misc as binary

[REVIEW] 16437 workaround gerrit misclassifying awk test T.misc as binary

[Bill Sommerfeld]

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

Issue: https://www.illumos.org/issues/16437
CR: https://code.illumos.org/c/illumos-gate/+/3395
Diff: attached

While responding to code review feedback on #16435 I found that
Gerrit's implementation of git viewed the awk test
usr/src/test/util-tests/tests/awk/tests/T.misc as a non-diffable
binary file.

Some digging around determined that the trigger for problem was an
ASCII carriage return in the middle of a line; with that changed in
the script to the backslash-r equivalent, Gerrit no longer has a
problem creating diffs in subsequent reviews.

Unfortunately this means that Gerrit will not be able to directly 
display diffs for this change; if you want to see what I've uploaded to 
the change, your best bet is to:

	git fetch ssh://code.illumos.org/illumos-gate \
		refs/changes/95/3395/1 && git show FETCH_HEAD

I've attached a diff I've generated - it's perhaps best read by feeding 
it through "cat -vt" as it involves a change to a line that contains a 
litany of embedded ASCII carriage-control codes.

Thanks in advance for your review.

[-- Attachment #2: bug16437.diff --]
[-- Type: text/x-patch, Size: 801 bytes --]

commit f105fa0bf0467b20bfc3f3ef5e816aba2b40c38c
Author: Bill Sommerfeld <sommerfeld@hamachi.org>
Date:   Mon Apr 1 16:07:41 2024 -0700

    16437 workaround gerrit misclassifying awk test T.misc as binary
    
    Change-Id: Ia52a48a68bd02734e0b8bd39c4957c3e4179a301

diff --git a/usr/src/test/util-tests/tests/awk/tests/T.misc b/usr/src/test/util-tests/tests/awk/tests/T.misc
index 04e9794de9..062f93b19b 100755
--- a/usr/src/test/util-tests/tests/awk/tests/T.misc
+++ b/usr/src/test/util-tests/tests/awk/tests/T.misc
@@ -307,7 +307,7 @@ $AWK '#
 ' >/dev/null 2> $TEMP0
 grep 'line [45]' $TEMP0 >/dev/null || fail '\aBAD: T.misc lineno'
 
-echo 'x\f\r\b\v\a\y' > $TEMP1
+echo 'x\f\r\b\v\a\y' > $TEMP1
 $AWK 'BEGIN { print "x\f\r\b\v\a\\y" }' > $TEMP2
 cmp -s $TEMP1 $TEMP2 || fail '\aBAD: T.misc weird chars'