From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from tb-mx0.topicbox.com (localhost.local [127.0.0.1]) by tb-mx0.topicbox.com (Postfix) with ESMTP id 59239202B109 for ; Wed, 24 Jul 2024 03:31:01 -0400 (EDT) (envelope-from prvs=19355204aa=illumos@fiddaman.net) Received: from tb-mx0.topicbox.com (localhost [127.0.0.1]) by tb-mx0.topicbox.com (Authentication Milter) with ESMTP id 43B6273C4AB; Wed, 24 Jul 2024 03:31:01 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1721806261; b=EFPyxFU35OUqab0jC8B1RlGwgZTYlT1R84l+e34rJj3uVk34mP NkjzKVr3nBNN+FMQEFYB2yU1vaGw/HEUtmNblage6MJtsiET2gcYqYoqOPJbGAE9 6mhEzRmcbVSko8mTzVNHNhwCExofBf68sciQrKrMUzNDno1nePj/1+IXUx1lPB3c uaZReLrLyUfrbVCOys2gjNGFrefi4E3aAQbsxY4hwEeAmDufrf8hCtjFpRjKr+PW lZQyDIQzcUvqbudMLm4PMicTXAtAL8FxKkkFPCVl1Q/RQbISaVqsvycdn29V7MWH 25fLstpSbhs7XyltVKixc0LTKZwA2sdhxKwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=date:from:to:subject:message-id:mime-version :content-type; s=arcseal; t=1721806261; bh=hVnSAe7+zDZjyq+BART92 4wleB7WxDhkBSPJLMmFL7Y=; b=Ud2gkztoLjy5yNoNOAzeOzU0vp5OlcfIkHxJi 4lAfr7lFvXRClspNj/bwVMvJmEx3hCOFsJkfXH7IZhsjYUj/wKS93coI3ju4+BzA e69gU/yJqH85hnBN/GFMiMJBXyN2ysJSXq6WCZc2jGAAeEvVH65E9w8kM1zrY3k+ 4RK5Y8MZSzqQ2VZXuyCkI5TWscUmRumL1iuz8Re90D3m8aTiNycSDQIjbzdXaOP0 Oz9w/KmICXSFnszlDMnbsnYVWM3suB2I174lY0SzHBAcZO3Z5JSE7Ozx9ktGmMMC doCt7qw0cxC85NQtxefMzzLDNuIxpz3/2Fndf618SIuG9Bb7Q== ARC-Authentication-Results: i=1; tb-mx0.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=pass (1024-bit rsa key sha256) header.d=fiddaman.net header.i=@fiddaman.net header.b=bStJzq3w header.a=rsa-sha256 header.s=boomer x-bits=1024; dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=fiddaman.net; iprev=pass smtp.remote-ip=89.248.55.103 (mail.citrus-it.net); spf=pass smtp.mailfrom="prvs=19355204aa=illumos@fiddaman.net" smtp.helo=mail.citrus-it.net; x-aligned-from=domain_pass (Domain match); x-me-sender=none; x-ptr=pass smtp.helo=mail.citrus-it.net policy.ptr=mail.citrus-it.net; x-return-mx=pass header.domain=fiddaman.net policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-return-mx=pass smtp.domain=fiddaman.net policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=0 state=0 Authentication-Results: tb-mx0.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=pass (1024-bit rsa key sha256) header.d=fiddaman.net header.i=@fiddaman.net header.b=bStJzq3w header.a=rsa-sha256 header.s=boomer x-bits=1024; dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=fiddaman.net; iprev=pass smtp.remote-ip=89.248.55.103 (mail.citrus-it.net); spf=pass smtp.mailfrom="prvs=19355204aa=illumos@fiddaman.net" smtp.helo=mail.citrus-it.net; x-aligned-from=domain_pass (Domain match); x-me-sender=none; x-ptr=pass smtp.helo=mail.citrus-it.net policy.ptr=mail.citrus-it.net; x-return-mx=pass header.domain=fiddaman.net policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-return-mx=pass smtp.domain=fiddaman.net policy.is_org=yes (MX Records found: mail21.citrus-it.net,mail30.citrus-it.net,mail98.citrus-it.net,mail99.citrus-it.net); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=0 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgeeftddriedtgdduvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuf fkgggtsehttdertddttddvnecuhfhrohhmpeetnhguhicuhfhiuggurghmrghnuceoihhl lhhumhhoshesfhhiuggurghmrghnrdhnvghtqeenucggtffrrghtthgvrhhnpeejveekje ffkedvfeekfeekueegjedukeethfeigeeugfeuieefvdfhgfeuleekgeenucffohhmrghi nhepihhllhhumhhoshdrohhrghdpghhithhhuhgsrdgtohhmnecukfhppeekledrvdegke drheehrddutdefpdekledrvdegkedrheehrdejleenucevlhhushhtvghrufhiiigvpedt necurfgrrhgrmhepihhnvghtpeekledrvdegkedrheehrddutdefpdhhvghlohepmhgrih hlrdgtihhtrhhushdqihhtrdhnvghtpdhmrghilhhfrhhomhepoehprhhvshepudelfeeh hedvtdegrggrpehilhhluhhmohhssehfihguuggrmhgrnhdrnhgvtheqpdhnsggprhgtph htthhopedupdhrtghpthhtohepoeguvghvvghlohhpvghrsehlihhsthhsrdhilhhluhhm ohhsrdhorhhgqe X-ME-VSScore: 0 X-ME-VSCategory: clean Received-SPF: pass (fiddaman.net: 89.248.55.103 is authorized to use 'prvs=19355204aa=illumos@fiddaman.net' in 'mfrom' identity (mechanism 'ip4:89.248.55.64/26' matched)) receiver=tb-mx0.topicbox.com; identity=mailfrom; envelope-from="prvs=19355204aa=illumos@fiddaman.net"; helo=mail.citrus-it.net; client-ip=89.248.55.103 Received: from mail.citrus-it.net (mail.citrus-it.net [89.248.55.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx0.topicbox.com (Postfix) with ESMTPS for ; Wed, 24 Jul 2024 03:30:59 -0400 (EDT) (envelope-from prvs=19355204aa=illumos@fiddaman.net) Authentication-Results: citrusmail; dkim=pass header.i=@fiddaman.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fiddaman.net; s=boomer; t=1721806258; bh=hVnSAe7+zDZjyq+BART924wleB7WxDhkBSPJLMmFL7Y=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; b=bStJzq3wmArEyN/q8v7KkVIEhXqfry5/4nitPuVksnWNNU8vpKkrXxO5xp9vdTnRD mfEIW3jtSw6gWZOJtXQY8jLDT9UN4727gAUR+Nom5BPlpWMVTVr5lXqIESyQSBxNs/ ji+H4/L5alGp7Qqqh0bSf8XzjPF9nvsI0Mt2x2jM= Received: from reaper.citrus-it.net (reaper.citrus-it.net [89.248.55.79]) by mail.citrus-it.net with ESMTP id 46O7UvKd020316 for ; Wed, 24 Jul 2024 07:30:58 GMT Date: Wed, 24 Jul 2024 07:30:56 +0000 (UTC) From: Andy Fiddaman To: developer@lists.illumos.org Subject: HEADS-UP: struct pam_message in conversation function is now const Message-ID: <5b282ce8-f651-412f-8387-a2be8e8243f2@fiddaman.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Citrus-Version: 6.0.3ba253c X-Citrus-ID: 546O7UvKd020316 X-Citrus-Virus-Scanned: Clean X-Citrus-Spam: Whitelisted X-Citrus-Trust: Trusted Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: b125b104-498e-11ef-ac8b-c2f2028c7b06 (I'm sending this out on Dominik's behalf): "15657 struct pam_message in conversation function should be const" has recently been integrated and it updates the definition of the pam_message parameter to a conversation function to be const. This brings it in line with what was already in at least one man page (https://illumos.org/man/3PAM/pam_start), and with other systems such as FreeBSD and Linux. This should improve compatibility with 3rd party software which already generally expects this. However, some software has conditionals based on illumos/Solaris to select a non-const variant on those platforms. (A good example is https://github.com/openssh/openssh-portable/blob/V_9_8/auth-pam.c#L70-L75) Doing so is usually just a compiler warning, but can become an error if software is: - built with clang >= 16 - built with gcc >= 14 - built with `-Werror` We are working on patching 3rd party software upstream. If you hit a problem, please reach out, but you can also define `_PAM_LEGACY_NONCONST` as a last resort to get back the legacy non-const interface. Regards, Dominik