public inbox for developer@lists.illumos.org (since 2011-08)
 help / color / mirror / Atom feed
* [REVIEW] 16720 nightly has easily fixable whitespace nits
@ 2024-08-20  0:35 Bill Sommerfeld
  0 siblings, 0 replies; only message in thread
From: Bill Sommerfeld @ 2024-08-20  0:35 UTC (permalink / raw)
  To: developer

Issue: https://www.illumos.org/issues/16720
CR: https://code.illumos.org/c/illumos-gate/+/3641
Diff: https://code.illumos.org/~diff/856dfa3a2b2862c492af7844c44da03a38400592

I'm working on a couple changes to nightly and I noticed some
preexisting pbchk noise ("space followed by tab" warnings in regexp
charsets) that I'd like to fix.

As it's a whitespace-only change, the best way to review it is probably via "git diff HEAD~ | cat -vt":

diff --git a/usr/src/tools/scripts/nightly b/usr/src/tools/scripts/nightly
index c74c350df7..3eba9dcb4b 100755
--- a/usr/src/tools/scripts/nightly
+++ b/usr/src/tools/scripts/nightly
@@ -192,13 +192,13 @@ function build {
   ^Iecho "\n==== Build errors ($LABEL) ====\n" >> $mail_msg_file
  ^Iegrep ":" $SRC/${INSTALLOG}.out |
-^I    egrep -e "(^${MAKE}:|[ ^I]error[: ^I\n]|ld: guidance:)" | \
+^I    egrep -e "(^${MAKE}:|[^I ]error[:^I \n]|ld: guidance:)" | \
  ^I    egrep -v ": (Entering|Leaving) directory " | \
  ^I    egrep -v "Ignoring unknown host" | \
  ^I    egrep -v "cc .* -o error " | \
  ^I    egrep -v "warning" | tee $TMPDIR/build_errs${SUFFIX} \
  ^I    >> $mail_msg_file
-^I    sed -n "/^Undefined[ ^I]*first referenced$/,/^ld: fatal:/p" \
+^I    sed -n "/^Undefined[^I ]*first referenced$/,/^ld: fatal:/p" \
  ^I    < $SRC/${INSTALLOG}.out >> $mail_msg_file
  ^Iif [[ -s $TMPDIR/build_errs${SUFFIX} ]]; then
  ^I^Ibuild_ok=n
@@ -373,7 +373,7 @@ function bootstrap_tools {
  ^Iecho "\n==== Bootstrap build errors ====\n" >> $mail_msg_file
   ^Iegrep ":" ${TOOLS}/$INSTALLOG.out |
-^I    egrep -e "(${MAKE}:|[ ^I]error[: ^I\n])" | \
+^I    egrep -e "(${MAKE}:|[^I ]error[:^I \n])" | \
  ^I    egrep -v ": (Entering|Leaving) directory " | \
  ^I    egrep -v warning | tee $TMPDIR/bootstrap_errors >> $mail_msg_file
  @@ -404,7 +404,7 @@ function build_tools {
  ^Iecho "\n==== Tools build errors ====\n" >> $mail_msg_file
   ^Iegrep ":" ${TOOLS}/${INSTALLOG}.out |
-^I^Iegrep -e "(${MAKE}:|[ ^I]error[: ^I\n])" | \
+^I^Iegrep -e "(${MAKE}:|[^I ]error[:^I \n])" | \
  ^I^Iegrep -v ": (Entering|Leaving) directory " | \
  ^I^Iegrep -v "Ignoring unknown host" | \
  ^I^Iegrep -v warning | tee $TMPDIR/tools_errors >> $mail_msg_file
@@ -855,7 +855,7 @@ then
  ^Ithen
  ^I^I# Note: there is a hard tab and space character in the []s
  ^I^I# below.
-^I^Iegrep -i "^[ ^I]*${hostname}[ ^I\.]" \
+^I^Iegrep -i "^[^I ]*${hostname}[^I \.]" \
  ^I^I^I$HOME/.make.machines | read host jobs
  ^I^Imaxjobs=${jobs##*=}
  ^Ifi


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-08-20  0:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-20  0:35 [REVIEW] 16720 nightly has easily fixable whitespace nits Bill Sommerfeld

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).