From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from tb-mx1.topicbox.com (localhost.local [127.0.0.1]) by tb-mx1.topicbox.com (Postfix) with ESMTP id 2F5F9202C2BE for ; Mon, 19 Aug 2024 20:35:05 -0400 (EDT) (envelope-from sommerfeld@hamachi.org) Received: from tb-mx1.topicbox.com (localhost [127.0.0.1]) by tb-mx1.topicbox.com (Authentication Milter) with ESMTP id 112355160CE; Mon, 19 Aug 2024 20:35:05 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1724114105; b=B5Dl6QLJGzcieY/nB7my/EiTXsDrf0SDHAJKRk0JLPanyKtBBy YXCO5wyoWlQFG2SxKmAbMgK11emzQgWlXOSzNG7Q3oonOqUYksd46BR43hsg7tlP ZmWHnQVz7Nze0w+wZ2rJiBqoZxFQGIPs6oNsc98J217jaCCrODRy5DXeI1CxLmGt bfvnW/T9CBrPFgY4SpinPo83XuGBPOn9Ob0pxKRhvpG17d19NT9KWYnMK5DANVyb WEU1EEh2I7KiMFdGe3dLYaxEcRUq0r+LL+Bg11De6h1HnXPAy5ZEw9ILC2TwXQac Nu7fhdD3zKKacSIk+8iiREXVrUUnJWXUr+4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=message-id:date:mime-version:to:subject:from :content-type:content-transfer-encoding; s=arcseal; t= 1724114105; bh=AFeeV4/TAbHk/lcSR5UvUkhLaHrlY+S6yfIBibM6DtY=; b=J uSQFcLFZpoX+Ta+RJEhn+6cnzVbLTO3sPtKaneacFGnkgPChlE3H7iKynZ3AO8bz McJKlhaxLSGpZlea6DWGLrz/saPVN7lcCO8I4kTzlpldZn3hfIwMRSJjNzZ0Paza CO2oDVH3g/ZWNotI6rVFlyxgdASfQfJed6cbEhnrsgHfPxIGKZvwhqfcv6bRyEb3 qywtx3xeSEi68mYhf/3od9nGekEZlbtEKh7UiZ63o6f+JPZDa59VWG/g4lIDTBI+ gZ2b/dxeKWw4wMIZbnHGScjaXX2Sio9z/SGNJkUs+bLvuWfdo3e8UVC5CxloIfV2 hGGsSlZC57yCayRXg9iyg== ARC-Authentication-Results: i=1; tb-mx1.topicbox.com; arc=none (no signatures found); bimi=none (No BIMI records found); dkim=pass (2048-bit rsa key sha256) header.d=hamachi.org header.i=@hamachi.org header.b=soZz6kT4 header.a=rsa-sha256 header.s=hamachi-202408 x-bits=2048; dmarc=pass policy.published-domain-policy=reject policy.applied-disposition=none policy.evaluated-disposition=none (p=reject,d=none,d.eval=none) policy.policy-from=p header.from=hamachi.org; iprev=pass smtp.remote-ip=173.11.94.225 (the-governor.hamachi.org); spf=pass smtp.mailfrom=sommerfeld@hamachi.org smtp.helo=the-governor.hamachi.org; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=the-governor.hamachi.org policy.ptr=the-governor.hamachi.org; x-return-mx=pass header.domain=hamachi.org policy.is_org=yes (MX Records found: the-governor.hamachi.org,smtp-backup-in.hamachi.org); x-return-mx=pass smtp.domain=hamachi.org policy.is_org=yes (MX Records found: the-governor.hamachi.org,smtp-backup-in.hamachi.org); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=0 state=0 Authentication-Results: tb-mx1.topicbox.com; arc=none (no signatures found); bimi=none (No BIMI records found); dkim=pass (2048-bit rsa key sha256) header.d=hamachi.org header.i=@hamachi.org header.b=soZz6kT4 header.a=rsa-sha256 header.s=hamachi-202408 x-bits=2048; dmarc=pass policy.published-domain-policy=reject policy.applied-disposition=none policy.evaluated-disposition=none (p=reject,d=none,d.eval=none) policy.policy-from=p header.from=hamachi.org; iprev=pass smtp.remote-ip=173.11.94.225 (the-governor.hamachi.org); spf=pass smtp.mailfrom=sommerfeld@hamachi.org smtp.helo=the-governor.hamachi.org; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=the-governor.hamachi.org policy.ptr=the-governor.hamachi.org; x-return-mx=pass header.domain=hamachi.org policy.is_org=yes (MX Records found: the-governor.hamachi.org,smtp-backup-in.hamachi.org); x-return-mx=pass smtp.domain=hamachi.org policy.is_org=yes (MX Records found: the-governor.hamachi.org,smtp-backup-in.hamachi.org); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=0 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgeeftddrudduhedgfeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfg fvuffhtgfgsehtjeertddtvdejnecuhfhrohhmpeeuihhllhcuufhomhhmvghrfhgvlhgu uceoshhomhhmvghrfhgvlhgusehhrghmrggthhhirdhorhhgqeenucggtffrrghtthgvrh hnpeeuudekueeiueehieeiudelkeetveelieefgeduheethfeufffhudeludfguefgueen ucffohhmrghinhepihhllhhumhhoshdrohhrghenucfkphepudejfedruddurdelgedrvd dvhedpvdeitdefmeeftddvgeemvgdtheemrggstddtmeemfeenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepihhnvghtpedujeefrdduuddrleegrddvvdehpdhhvghloh epthhhvgdqghhovhgvrhhnohhrrdhhrghmrggthhhirdhorhhgpdhmrghilhhfrhhomhep oehsohhmmhgvrhhfvghlugeshhgrmhgrtghhihdrohhrgheqpdhnsggprhgtphhtthhope dupdhrtghpthhtohepoeguvghvvghlohhpvghrsehlihhsthhsrdhilhhluhhmohhsrdho rhhgqe X-ME-VSScore: 0 X-ME-VSCategory: clean Received-SPF: pass (hamachi.org: 173.11.94.225 is authorized to use 'sommerfeld@hamachi.org' in 'mfrom' identity (mechanism 'mx' matched)) receiver=tb-mx1.topicbox.com; identity=mailfrom; envelope-from="sommerfeld@hamachi.org"; helo=the-governor.hamachi.org; client-ip=173.11.94.225 Received: from the-governor.hamachi.org (the-governor.hamachi.org [173.11.94.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx1.topicbox.com (Postfix) with ESMTPS for ; Mon, 19 Aug 2024 20:35:04 -0400 (EDT) (envelope-from sommerfeld@hamachi.org) Received: from [IPV6:2603:3024:e05:ab00::3] (hydra.hamachi.org [IPv6:2603:3024:e05:ab00::3]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sommerfeld) by the-governor.hamachi.org (Postfix) with ESMTPSA id 382822978; Mon, 19 Aug 2024 17:34:47 -0700 (PDT) Authentication-Results: the-governor.hamachi.org; auth=pass; dkim=pass (2048-bit rsa key sha256) header.d=hamachi.org header.i=@hamachi.org header.b=soZz6kT4 header.a=rsa-sha256 header.s=hamachi-202408; x-aligned-from=pass (Address match); x-local-user=pass; x-spam=pass score=-2.00 required=5.00 X-Spam-hits: BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,NO_RECEIVED,NO_RELAYS, T_SCC_BODY_TEXT_LINE X-Spam-Status: No, score=-2.00 required=5.00 X-Spam-score: -2.00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hamachi.org; s=hamachi-202408; t=1724114087; bh=AFeeV4/TAbHk/lcSR5UvUkhLaHrlY+S6yfIBibM6DtY=; h=Date:To:Subject:From; b=soZz6kT4hYf3yzIppd+VywEqX0p3VeH/5+d9n9s6FxOQV89s8rAscHS+teu2dWzlO iPt7jBc0umPAnc+MUdO5lKgP9eFh08ucznn3JWzh6z9Y2tG5OWz6nI0bXTYIXFlr9o SSqi6eIxwDbT3aSnHwcrsc2004qfbhhESfCcRS7aM1WN9nDoqdVDNLlrh1RNqsXn5y 7BtQfk+jz1Q2grT53GshtjzbSPPLSlb/d1gVLRPg2u8+/IZO+/N6LK026ugV38RRXZ ICUPrGrFd2vrHU1MYH91U+/QhuH20zUhSd1U0UMp4bBiYYcDGi0iBeQPX5zVzd6tlL HGQEdifHNkgmQ== Message-ID: <67918d56-3a56-464d-92f7-fac5b25be6da@hamachi.org> Date: Mon, 19 Aug 2024 17:35:00 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: developer@lists.illumos.org Subject: [REVIEW] 16720 nightly has easily fixable whitespace nits From: Bill Sommerfeld Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: 0f4eda6e-5e8c-11ef-a6b9-e2d6f2e04907 Issue: https://www.illumos.org/issues/16720 CR: https://code.illumos.org/c/illumos-gate/+/3641 Diff: https://code.illumos.org/~diff/856dfa3a2b2862c492af7844c44da03a38400592 I'm working on a couple changes to nightly and I noticed some preexisting pbchk noise ("space followed by tab" warnings in regexp charsets) that I'd like to fix. As it's a whitespace-only change, the best way to review it is probably via "git diff HEAD~ | cat -vt": diff --git a/usr/src/tools/scripts/nightly b/usr/src/tools/scripts/nightly index c74c350df7..3eba9dcb4b 100755 --- a/usr/src/tools/scripts/nightly +++ b/usr/src/tools/scripts/nightly @@ -192,13 +192,13 @@ function build { ^Iecho "\n==== Build errors ($LABEL) ====\n" >> $mail_msg_file ^Iegrep ":" $SRC/${INSTALLOG}.out | -^I egrep -e "(^${MAKE}:|[ ^I]error[: ^I\n]|ld: guidance:)" | \ +^I egrep -e "(^${MAKE}:|[^I ]error[:^I \n]|ld: guidance:)" | \ ^I egrep -v ": (Entering|Leaving) directory " | \ ^I egrep -v "Ignoring unknown host" | \ ^I egrep -v "cc .* -o error " | \ ^I egrep -v "warning" | tee $TMPDIR/build_errs${SUFFIX} \ ^I >> $mail_msg_file -^I sed -n "/^Undefined[ ^I]*first referenced$/,/^ld: fatal:/p" \ +^I sed -n "/^Undefined[^I ]*first referenced$/,/^ld: fatal:/p" \ ^I < $SRC/${INSTALLOG}.out >> $mail_msg_file ^Iif [[ -s $TMPDIR/build_errs${SUFFIX} ]]; then ^I^Ibuild_ok=n @@ -373,7 +373,7 @@ function bootstrap_tools { ^Iecho "\n==== Bootstrap build errors ====\n" >> $mail_msg_file ^Iegrep ":" ${TOOLS}/$INSTALLOG.out | -^I egrep -e "(${MAKE}:|[ ^I]error[: ^I\n])" | \ +^I egrep -e "(${MAKE}:|[^I ]error[:^I \n])" | \ ^I egrep -v ": (Entering|Leaving) directory " | \ ^I egrep -v warning | tee $TMPDIR/bootstrap_errors >> $mail_msg_file @@ -404,7 +404,7 @@ function build_tools { ^Iecho "\n==== Tools build errors ====\n" >> $mail_msg_file ^Iegrep ":" ${TOOLS}/${INSTALLOG}.out | -^I^Iegrep -e "(${MAKE}:|[ ^I]error[: ^I\n])" | \ +^I^Iegrep -e "(${MAKE}:|[^I ]error[:^I \n])" | \ ^I^Iegrep -v ": (Entering|Leaving) directory " | \ ^I^Iegrep -v "Ignoring unknown host" | \ ^I^Iegrep -v warning | tee $TMPDIR/tools_errors >> $mail_msg_file @@ -855,7 +855,7 @@ then ^Ithen ^I^I# Note: there is a hard tab and space character in the []s ^I^I# below. -^I^Iegrep -i "^[ ^I]*${hostname}[ ^I\.]" \ +^I^Iegrep -i "^[^I ]*${hostname}[^I \.]" \ ^I^I^I$HOME/.make.machines | read host jobs ^I^Imaxjobs=${jobs##*=} ^Ifi