15442 Want datalink media observability and Testing Help

15442 Want datalink media observability and Testing Help

[Robert Mustacchi]

Hi folks,

With Rich sponsoring IPD 39, I've put together prototypes of this for
most major drivers and an update to mac, dladm, and libtopo
(https://code.illumos.org/c/illumos-gate/+/2682). This should cover
something if you use any of the following:

* igb and e1000g (https://code.illumos.org/c/illumos-gate/+/2683)
* ixgbe (https://code.illumos.org/c/illumos-gate/+/2684)
* mlxcx (https://code.illumos.org/c/illumos-gate/+/2685)
* i40e (https://code.illumos.org/c/illumos-gate/+/2686)
* cxgbe (https://code.illumos.org/c/illumos-gate/+/2687)
* bnxe (https://code.illumos.org/c/illumos-gate/+/2689)
* qede (https://code.illumos.org/c/illumos-gate/+/2690)
* bnx (https://code.illumos.org/c/illumos-gate/+/2691)
* bge (https://code.illumos.org/c/illumos-gate/+/2692)
* sfxge (https://code.illumos.org/c/illumos-gate/+/2693)
* mii-based drivers including afe, atge, dfme, efe, elxl, hme, iprb,
pcn, rtls, and yge (https://code.illumos.org/c/illumos-gate/+/2688)

While review would be helpful, getting additional testing of the media
property and verifying that it matches what you're using would be even
more appreciated! Note, dladm will complain about the property when used
against other non-Ethernet devices (just like it does with things like
fec and speed advertisements). Here's an example of what you might
expect to see:

$ dladm show-linkprop -p media
LINK         PROPERTY        PERM VALUE          DEFAULT        POSSIBLE
igb0         media           r-   1000BASE-T     --             --
igb1         media           r-   none           --             --
cxgbe0       media           r-   100GBASE-CR4   --             --
cxgbe1       media           r-   unknown        --             --
rm@romulus ~ $

Dan and Andy have kindly built bits for SmartOS and OmniOS for folks to
try this out. Here are Andy's instructions if you're using r38, r42,
r44, or bloody:

I've built signed hot-fixes for all of the supported OmniOS releases,
and for
bloody in case anyone is running those pieces.

Depending on the release that someone is running they need to adjust the
URL* in the following example

    pfexec pkg apply-hot-fix \
        --be-name=mac-media \
        https://hf.omnios.org/r38/15422-mac-media.p5p

and then reboot to the new boot environment.

* 'r38', 'r42', 'r44' and 'bloody' are there.

Dan is building bits that'll show up at
https://kebe.com/~danmcd/webrevs/ipd39/ later today. If you'd prefer to
build everything yourself, you can either cherry-pick from gerrit or
here is a git branch you can pull at
https://github.com/rmustacc/illumos-gate/commits/mac-media.

Please don't hesitate to reach out if you have any questions.

Thanks,
Robert

Re: [developer] 15442 Want datalink media observability and Testing Help

[Dan McDonald]

That directory is now populated.  My copy scripts were overly generous, so just concentrate on the platform-2023*.{iso,tgz} ones.

Dan

Sent from my iPhone (typos, autocorrect, and all)

> On Mar 5, 2023, at 11:41 AM, Robert Mustacchi <rm@fingolfin.org> wrote:
> 
> Hi folks,
> 
> With Rich sponsoring IPD 39, I've put together prototypes of this for
> most major drivers and an update to mac, dladm, and libtopo
> (https://code.illumos.org/c/illumos-gate/+/2682). This should cover
> something if you use any of the following:
> 
> * igb and e1000g (https://code.illumos.org/c/illumos-gate/+/2683)
> * ixgbe (https://code.illumos.org/c/illumos-gate/+/2684)
> * mlxcx (https://code.illumos.org/c/illumos-gate/+/2685)
> * i40e (https://code.illumos.org/c/illumos-gate/+/2686)
> * cxgbe (https://code.illumos.org/c/illumos-gate/+/2687)
> * bnxe (https://code.illumos.org/c/illumos-gate/+/2689)
> * qede (https://code.illumos.org/c/illumos-gate/+/2690)
> * bnx (https://code.illumos.org/c/illumos-gate/+/2691)
> * bge (https://code.illumos.org/c/illumos-gate/+/2692)
> * sfxge (https://code.illumos.org/c/illumos-gate/+/2693)
> * mii-based drivers including afe, atge, dfme, efe, elxl, hme, iprb,
> pcn, rtls, and yge (https://code.illumos.org/c/illumos-gate/+/2688)
> 
> While review would be helpful, getting additional testing of the media
> property and verifying that it matches what you're using would be even
> more appreciated! Note, dladm will complain about the property when used
> against other non-Ethernet devices (just like it does with things like
> fec and speed advertisements). Here's an example of what you might
> expect to see:
> 
> $ dladm show-linkprop -p media
> LINK         PROPERTY        PERM VALUE          DEFAULT        POSSIBLE
> igb0         media           r-   1000BASE-T     --             --
> igb1         media           r-   none           --             --
> cxgbe0       media           r-   100GBASE-CR4   --             --
> cxgbe1       media           r-   unknown        --             --
> rm@romulus ~ $
> 
> Dan and Andy have kindly built bits for SmartOS and OmniOS for folks to
> try this out. Here are Andy's instructions if you're using r38, r42,
> r44, or bloody:
> 
> I've built signed hot-fixes for all of the supported OmniOS releases,
> and for
> bloody in case anyone is running those pieces.
> 
> Depending on the release that someone is running they need to adjust the
> URL* in the following example
> 
>    pfexec pkg apply-hot-fix \
>        --be-name=mac-media \
>        https://hf.omnios.org/r38/15422-mac-media.p5p
> 
> and then reboot to the new boot environment.
> 
> * 'r38', 'r42', 'r44' and 'bloody' are there.
> 
> Dan is building bits that'll show up at
> https://kebe.com/~danmcd/webrevs/ipd39/ later today. If you'd prefer to
> build everything yourself, you can either cherry-pick from gerrit or
> here is a git branch you can pull at
> https://github.com/rmustacc/illumos-gate/commits/mac-media.
> 
> Please don't hesitate to reach out if you have any questions.
> 
> Thanks,
> Robert
> 
> ------------------------------------------
> illumos: illumos-developer
> Permalink: https://illumos.topicbox.com/groups/developer/T8be723e7cfef93c9-M1a14fa06c48698db3939b46f
> Delivery options: https://illumos.topicbox.com/groups/developer/subscription

Re: [developer] 15442 Want datalink media observability and Testing Help

[Gary Mills]

On Sun, Mar 05, 2023 at 08:41:43AM -0800, Robert Mustacchi wrote:
> 
> With Rich sponsoring IPD 39, I've put together prototypes of this for
> most major drivers and an update to mac, dladm, and libtopo
> (https://code.illumos.org/c/illumos-gate/+/2682). This should cover
> something if you use any of the following:
> 
> * igb and e1000g (https://code.illumos.org/c/illumos-gate/+/2683)
> * ixgbe (https://code.illumos.org/c/illumos-gate/+/2684)
> * mlxcx (https://code.illumos.org/c/illumos-gate/+/2685)
> * i40e (https://code.illumos.org/c/illumos-gate/+/2686)
> * cxgbe (https://code.illumos.org/c/illumos-gate/+/2687)
> * bnxe (https://code.illumos.org/c/illumos-gate/+/2689)
> * qede (https://code.illumos.org/c/illumos-gate/+/2690)
> * bnx (https://code.illumos.org/c/illumos-gate/+/2691)
> * bge (https://code.illumos.org/c/illumos-gate/+/2692)
> * sfxge (https://code.illumos.org/c/illumos-gate/+/2693)
> * mii-based drivers including afe, atge, dfme, efe, elxl, hme, iprb,
> pcn, rtls, and yge (https://code.illumos.org/c/illumos-gate/+/2688)

My systems use rge ethernet interfaces almost exclusively.  Is the
code for rge going to be updated?  Will the driver continue to work
without updates?  I'm certainly willing to test with this interface.


-- 
-Gary Mills-		-refurb-		-Winnipeg, Manitoba, Canada-

Re: [developer] 15442 Want datalink media observability and Testing Help

[Dan McDonald]

On Mar 6, 2023, at 10:26 AM, Gary Mills <gary_mills@fastmail.fm> wrote:
> 
> On Sun, Mar 05, 2023 at 08:41:43AM -0800, Robert Mustacchi wrote:
>> 
>> With Rich sponsoring IPD 39, I've put together prototypes of this for
>> most major drivers and an update to mac, dladm, and libtopo
>> (https://code.illumos.org/c/illumos-gate/+/2682). This should cover
>> something if you use any of the following:
>> 
>> * igb and e1000g (https://code.illumos.org/c/illumos-gate/+/2683)
>> * ixgbe (https://code.illumos.org/c/illumos-gate/+/2684)
>> * mlxcx (https://code.illumos.org/c/illumos-gate/+/2685)
>> * i40e (https://code.illumos.org/c/illumos-gate/+/2686)
>> * cxgbe (https://code.illumos.org/c/illumos-gate/+/2687)
>> * bnxe (https://code.illumos.org/c/illumos-gate/+/2689)
>> * qede (https://code.illumos.org/c/illumos-gate/+/2690)
>> * bnx (https://code.illumos.org/c/illumos-gate/+/2691)
>> * bge (https://code.illumos.org/c/illumos-gate/+/2692)
>> * sfxge (https://code.illumos.org/c/illumos-gate/+/2693)
>> * mii-based drivers including afe, atge, dfme, efe, elxl, hme, iprb,
>> pcn, rtls, and yge (https://code.illumos.org/c/illumos-gate/+/2688)
> 
> My systems use rge ethernet interfaces almost exclusively.  Is the
> code for rge going to be updated?  Will the driver continue to work
> without updates?  I'm certainly willing to test with this interface.

Your rge(4D) will keep working, it just won't give useful output IF AND
ONLY IF you specify the `-p media` property in `dladm show-linkprop`.

This isn't a breaking change at all, it's just a new feature.

Hope this helps,
Dan

Re: [developer] 15442 Want datalink media observability and Testing Help

[Till Wegmüller]

Would it be a good first Issue to add rge support for at least my cards? 
I have many cards with rge.

-Till

On 06.03.23 16:29, Dan McDonald wrote:
> On Mar 6, 2023, at 10:26 AM, Gary Mills <gary_mills@fastmail.fm> wrote:
>>
>> On Sun, Mar 05, 2023 at 08:41:43AM -0800, Robert Mustacchi wrote:
>>>
>>> With Rich sponsoring IPD 39, I've put together prototypes of this for
>>> most major drivers and an update to mac, dladm, and libtopo
>>> (https://code.illumos.org/c/illumos-gate/+/2682). This should cover
>>> something if you use any of the following:
>>>
>>> * igb and e1000g (https://code.illumos.org/c/illumos-gate/+/2683)
>>> * ixgbe (https://code.illumos.org/c/illumos-gate/+/2684)
>>> * mlxcx (https://code.illumos.org/c/illumos-gate/+/2685)
>>> * i40e (https://code.illumos.org/c/illumos-gate/+/2686)
>>> * cxgbe (https://code.illumos.org/c/illumos-gate/+/2687)
>>> * bnxe (https://code.illumos.org/c/illumos-gate/+/2689)
>>> * qede (https://code.illumos.org/c/illumos-gate/+/2690)
>>> * bnx (https://code.illumos.org/c/illumos-gate/+/2691)
>>> * bge (https://code.illumos.org/c/illumos-gate/+/2692)
>>> * sfxge (https://code.illumos.org/c/illumos-gate/+/2693)
>>> * mii-based drivers including afe, atge, dfme, efe, elxl, hme, iprb,
>>> pcn, rtls, and yge (https://code.illumos.org/c/illumos-gate/+/2688)
>>
>> My systems use rge ethernet interfaces almost exclusively.  Is the
>> code for rge going to be updated?  Will the driver continue to work
>> without updates?  I'm certainly willing to test with this interface.
> 
> Your rge(4D) will keep working, it just won't give useful output IF AND
> ONLY IF you specify the `-p media` property in `dladm show-linkprop`.
> 
> This isn't a breaking change at all, it's just a new feature.
> 
> Hope this helps,
> Dan
> 
> 
> ------------------------------------------
> illumos: illumos-developer
> Permalink: https://illumos.topicbox.com/groups/developer/T8be723e7cfef93c9-M13b7f4a06a21764426831b7e
> Delivery options: https://illumos.topicbox.com/groups/developer/subscription