From: Alan Coopersmith <alan.coopersmith@oracle.com>
To: developer@lists.illumos.org
Subject: Re: [developer] Recent GCC improvements
Date: Wed, 22 May 2024 08:06:34 -0700 [thread overview]
Message-ID: <6d696203-a945-4566-b37c-2e88fc11bbe5@oracle.com> (raw)
In-Reply-To: <Zk3dXdrYhRAq1LLR@mnx.io>
On 5/22/24 04:56, Jonathan Perkin wrote:
> Hi,
>
> Rich encouraged me to ping the list about a couple of GCC fixes I've recently
> worked on. I'm reasonably confident that they would be useful for other
> distributions to pick up, and perhaps eventually make their way upstream.
>
> First, this fix for __STDC_VERSION__ being defined in C++ code:
>
> https://github.com/jperkin/notes/blob/main/gcc-cpp-stdc/README.md
>
> This fixes at least one third-party package (scipy), and probably others that
> depend on cython. I also have memories of fixing this manually in third party
> code in the past, so it's likely some other upstream issues are being masked.
The upstream g++ bug explaining why this was necessary is:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57025
Since gcc has now dropped support for Solaris 11.3 & older [1],
and illumos removed the offending bit of sys/feature_tests.h 6 years ago [2],
perhaps you could suggest that the definition can be dropped now for gcc 15.
[1] https://gcc.gnu.org/pipermail/libstdc++/2024-May/058672.html
[2]
https://github.com/illumos/illumos-gate/commit/be4355ddcfa407e2d3e4a06973af5cbef6ccdbae
-alan-
next prev parent reply other threads:[~2024-05-22 15:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 11:56 Jonathan Perkin
2024-05-22 15:06 ` Alan Coopersmith [this message]
2024-05-22 15:58 ` [developer] " Robert Mustacchi
2024-05-22 16:21 ` Jonathan Perkin
2024-05-24 12:32 ` Jonathan Perkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d696203-a945-4566-b37c-2e88fc11bbe5@oracle.com \
--to=alan.coopersmith@oracle.com \
--cc=developer@lists.illumos.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).