From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from tb-mx0.topicbox.com (localhost.local [127.0.0.1]) by tb-mx0.topicbox.com (Postfix) with ESMTP id 129A91E9A855 for ; Thu, 11 Jul 2024 12:40:24 -0400 (EDT) (envelope-from prvs=1922fb123a=andy@omnios.org) Received: from tb-mx0.topicbox.com (localhost [127.0.0.1]) by tb-mx0.topicbox.com (Authentication Milter) with ESMTP id 2AE94B91880; Thu, 11 Jul 2024 12:40:24 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1720716024; b=PjioTyzUNtkXOMHgk2E/eoHNR7pkiR6pUr6GrhwEVmQsPl/Xma FFdhUaaLgPeF1AcBR8clKzuklCFNPCqsqC/dHacKlMHwPqwo+Bhf3R+mPqxRirmv 9bYH5pPZrVUfnlRauSS3ATktFE2IOWxJOhL/b0FqWm//9pqf5KtOLncW/wpNgwg3 wUIhr+8b9Rz2vG2cl61ckiucNMOnHsbcLNE4cxKhbglYP3UeYgasljQBjzQd7Atd OJPadR4GrMi82p+ZgEG21YeLkXB2nT1Ob2bHzTPKSWUC5gqzXHgRXdzyrw4Xqyl4 /Z0JHTF6FuojOFvBG2fz26akTEBJ2vmXsusg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=date:from:to:subject:in-reply-to:message-id :references:mime-version:content-type; s=arcseal; t=1720716024; bh=9+9//TASZbrlUhgPfS6PNFFuT2qvT9tpTTuSeEwFclA=; b=bwoJGVkZN7mC KN7ChGYxdoCDrsacRD/YSzP0QZSxLIWQMDV14BtdeH4U8xiCbpY4//zWryaIYn5N 7OcX32pagAar1TsXj0NmEc14lFxZQi4qBxKZS7ygew6srQEM+vEu9QYh+CkgH6Lv 5XKT+m/bxbYhf6AXOBl1MX5nMM+XLO1+CP45H8ECSZXtuv8Tndb+OoUVchwnrY5/ W8tvibZfpo6r7JB2rLXDr8MzgHG7X9OiskMwnzQ2m+co8++X8GH4/QOTDnDycHDb EbJavfA581GqyhQUkgRdzfcsW6uWFlqmz0p/4ndoGFAoMp47Lo1k90zIJxdsuvMb irLZ3FUqMw== ARC-Authentication-Results: i=1; tb-mx0.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=pass (1024-bit rsa key sha256) header.d=omnios.org header.i=@omnios.org header.b=f01z5Plm header.a=rsa-sha256 header.s=omnios202205 x-bits=1024; dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=omnios.org; iprev=pass smtp.remote-ip=89.248.55.103 (mail.citrus-it.net); spf=none smtp.mailfrom="prvs=1922fb123a=andy@omnios.org" smtp.helo=mail.citrus-it.net; x-aligned-from=domain_pass (Domain match); x-me-sender=none; x-ptr=pass smtp.helo=mail.citrus-it.net policy.ptr=mail.citrus-it.net; x-return-mx=pass header.domain=omnios.org policy.is_org=yes (MX Records found: mail99.citrus-it.net,mail30.citrus-it.net,mail21.citrus-it.net,mail98.citrus-it.net); x-return-mx=pass smtp.domain=omnios.org policy.is_org=yes (MX Records found: mail99.citrus-it.net,mail30.citrus-it.net,mail21.citrus-it.net,mail98.citrus-it.net); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 Authentication-Results: tb-mx0.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=pass (1024-bit rsa key sha256) header.d=omnios.org header.i=@omnios.org header.b=f01z5Plm header.a=rsa-sha256 header.s=omnios202205 x-bits=1024; dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=omnios.org; iprev=pass smtp.remote-ip=89.248.55.103 (mail.citrus-it.net); spf=none smtp.mailfrom="prvs=1922fb123a=andy@omnios.org" smtp.helo=mail.citrus-it.net; x-aligned-from=domain_pass (Domain match); x-me-sender=none; x-ptr=pass smtp.helo=mail.citrus-it.net policy.ptr=mail.citrus-it.net; x-return-mx=pass header.domain=omnios.org policy.is_org=yes (MX Records found: mail99.citrus-it.net,mail30.citrus-it.net,mail21.citrus-it.net,mail98.citrus-it.net); x-return-mx=pass smtp.domain=omnios.org policy.is_org=yes (MX Records found: mail99.citrus-it.net,mail30.citrus-it.net,mail21.citrus-it.net,mail98.citrus-it.net); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgeeftddrfeeggddutdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepfffhvffujgfkfhggtgesthdtredttddtvdenucfh rhhomheptehnugihucfhihguuggrmhgrnhcuoegrnhguhiesohhmnhhiohhsrdhorhhgqe enucggtffrrghtthgvrhhnpeffuedthffgfeegkeetjeejgeejheetgeekkeeiiedvgfet feduieffudefiefgueenucfkphepkeelrddvgeekrdehhedruddtfedpkeelrddvgeekrd ehhedrjeelnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepkeel rddvgeekrdehhedruddtfedphhgvlhhopehmrghilhdrtghithhruhhsqdhithdrnhgvth dpmhgrihhlfhhrohhmpeeophhrvhhspeduledvvdhfsgduvdefrgeprghnugihsehomhhn ihhoshdrohhrgheqpdhnsggprhgtphhtthhopedupdhrtghpthhtohepoeguvghvvghloh hpvghrsehlihhsthhsrdhilhhluhhmohhsrdhorhhgqe X-ME-VSScore: -100 X-ME-VSCategory: clean Received-SPF: none (omnios.org: No applicable sender policy available) receiver=tb-mx0.topicbox.com; identity=mailfrom; envelope-from="prvs=1922fb123a=andy@omnios.org"; helo=mail.citrus-it.net; client-ip=89.248.55.103 Received: from mail.citrus-it.net (mail.citrus-it.net [89.248.55.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx0.topicbox.com (Postfix) with ESMTPS for ; Thu, 11 Jul 2024 12:40:22 -0400 (EDT) (envelope-from prvs=1922fb123a=andy@omnios.org) Authentication-Results: citrusmail; dkim=pass header.i=@omnios.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=omnios.org; s=omnios202205; t=1720716020; bh=X65YZIK+zpwVymF6kvy4RHOckNThi/E/7tY3k0j6W30=; h=Date:From:To:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=f01z5PlmN4RDXOO/m6lYrrdX0flajjGpfep05m3JpBC0rYWP9ziLiiZYbIE5J/xU8 3nW1L/Qtn1hh2SinOeFcU6q2Uo2vsiPMeLgl5hSuzxjzrwZfa4TjPlgibpNP2RiUFB 41PstXuto1HptY7u/91blwq+DwNLCMri3j7Mwrvs= Received: from reaper.citrus-it.net (reaper.citrus-it.net [89.248.55.79]) by mail.citrus-it.net with ESMTP id 46BGeKXd027804 for ; Thu, 11 Jul 2024 16:40:20 GMT Date: Thu, 11 Jul 2024 16:40:19 +0000 (UTC) From: Andy Fiddaman To: illumos-developer Subject: Re: [developer] Recent NVMe changes break testing on a VMware guest? In-Reply-To: <7A4BFA41-067A-4719-94DD-83E3DBC1152D@mnx.io> Message-ID: <73ab4969-0bce-413f-b3af-90d9b2aef930@omnios.org> References: <1A82FA49-90F0-4B2B-AF0F-B6BF90F9A62F@mnx.io> <7A4BFA41-067A-4719-94DD-83E3DBC1152D@mnx.io> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Citrus-Version: 6.0.3ba253c X-Citrus-ID: 546BGeKXd027804 X-Citrus-Spam: Whitelisted X-Citrus-Trust: Trusted Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: 47f28dd6-3fa4-11ef-b5c8-4faa048c7b06 On Thu, 11 Jul 2024, Dan McDonald wrote: > Reproducible in both 32- and 64-bit BTW: > > [root@coal /tmp/test]# /opt/nvme-tests/tests/unit/firmware.32 >& /tmp/32 > [root@coal /tmp/test]# /opt/nvme-tests/tests/unit/firmware.64 >& /tmp/64 > [root@coal /tmp/test]# diff /tmp/{32,64} > 56,57c56,57 > < TEST PASSED: valid ffirmware.32: TEST FAILED: invalid fw load numd 8k gran (3): found wrong return value NVME_FIELD_ERR_OK (0), expected NVME_FIELD_ERR_BAD_VALUE (3) > < firmware.32: TEST FAILED: invalid fw load numd 8k gran (4): found wrong return value NVME_FIELD_ERR_OK (0), expected NVME_FIELD_ERR_BAD_VALUE (3) > --- > > TEST PASSED: valid ffirmware.64: TEST FAILED: invalid fw load numd 8k gran (3): found wrong return value NVME_FIELD_ERR_OK (0), expected NVME_FIELD_ERR_BAD_VALUE (3) > > firmware.64: TEST FAILED: invalid fw load numd 8k gran (4): found wrong return value NVME_FIELD_ERR_OK (0), expected NVME_FIELD_ERR_BAD_VALUE (3) > [root@coal /tmp/test]# This is fallout from 16633 nvme firmware updates cannot enforce update That change relaxed the restrictions on the allowed firmware chunk size so that it no-longer needed to confirm to the firmware upgrade granularity, and as a result the tests are seeing NVME_FIELD_ERR_OK where they expect a bad value error. I will file a followup and fix it, sorry about that. Andy