From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from tb-mx1.topicbox.com (localhost.local [127.0.0.1]) by tb-mx1.topicbox.com (Postfix) with ESMTP id 8B7CF1552DB3 for ; Mon, 10 Jun 2024 15:26:32 -0400 (EDT) (envelope-from danmcd@mnx.io) Received: from tb-mx1.topicbox.com (localhost [127.0.0.1]) by tb-mx1.topicbox.com (Authentication Milter) with ESMTP id 2A9BBA870B4; Mon, 10 Jun 2024 15:26:32 -0400 ARC-Seal: i=2; a=rsa-sha256; cv=pass; d=topicbox.com; s=arcseal; t= 1718047592; b=w27P5j6FQMl+4MPZE5Yih5EVUsdeVq6s+amLSJ4arGxPLQSxbH SLdhceZDe+SJDRQ+3SW1QV4y3sIYBzC2xB1TAoCqrpYlGnVYOErHdu4mTa6j79AI sX6njt/wq5iBrRxdD4VYhe/4dNfYT328RHWMhWF9Ewu/6fElzIMOBtOBA54n04YF hqjBYOwTULXHaARaH4Um2zYgoNMHjJG+wzFNkhyTsRRF9/Jl0CNbfZAWYghIPTE5 W253ArEud+HwqvHQiRCiu3JYFB/KT/SK4Kpv+Gz3snJhu7tjc7pGozVZX8dJO2o+ fEU7mY1wOW4txIQfO7HjqA8q/EqAuqYkm3oA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=from:to:subject:date:message-id:content-type :content-id:content-transfer-encoding:mime-version; s=arcseal; t=1718047592; bh=GGAoy4LtyZLC/98gwQebYiAT3aBDGyPqLqefL13XP4U=; b= KVx9O+5nILmEH2cwQHlbad30KyrsNa2og2fByZVa80mkeZo7lCOoN7DXrTYXYzFX T8F1jIhDf/RUo4Ylq8FqGEkvB41Fn79b/PSSFmSwWF/f7d+tbpd8c48e870hagFq BNrRsTNl6L3zV5jG5Ri8aGhboy3ztiy9M5FhK0eYN0xTpD0LE3yfSEcaj49Uz/pM xUtQEpryaRkYY9lL9+aDFjrdXU1KKi42VTYvbAe9k6qoONoxY0+5uIuInqezpyaZ Ya6Nn+MptkEMAEHhoRLy6RmLz52Y7UfxexbeaDm9YmE8jm6yhXQM10fBuWZh7e5s R/l69mUcy3HBtkgfQ41+ZA== ARC-Authentication-Results: i=2; tb-mx1.topicbox.com; arc=pass (as.1.microsoft.com=pass, ams.1.microsoft.com=pass) smtp.remote-ip=40.107.100.133; bimi=skipped (DMARC Policy is not at enforcement); dkim=pass (2048-bit rsa key sha256) header.d=mnx.io header.i=@mnx.io header.b=LYIE0UW5 header.a=rsa-sha256 header.s=selector1 x-bits=2048; dmarc=pass policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=mnx.io; iprev=pass smtp.remote-ip=40.107.100.133 (mail-bn8nam04on2133.outbound.protection.outlook.com); spf=permerror smtp.mailfrom=danmcd@mnx.io smtp.helo=NAM04-BN8-obe.outbound.protection.outlook.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=fail smtp.helo=NAM04-BN8-obe.outbound.protection.outlook.com policy.ptr=mail-bn8nam04on2133.outbound.protection.outlook.com; x-return-mx=pass header.domain=mnx.io policy.is_org=yes (MX Records found: mx1-us1.ppe-hosted.com,mx2-us1.ppe-hosted.com); x-return-mx=pass smtp.domain=mnx.io policy.is_org=yes (MX Records found: mx1-us1.ppe-hosted.com,mx2-us1.ppe-hosted.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 Authentication-Results: tb-mx1.topicbox.com; arc=pass (as.1.microsoft.com=pass, ams.1.microsoft.com=pass) smtp.remote-ip=40.107.100.133; bimi=skipped (DMARC Policy is not at enforcement); dkim=pass (2048-bit rsa key sha256) header.d=mnx.io header.i=@mnx.io header.b=LYIE0UW5 header.a=rsa-sha256 header.s=selector1 x-bits=2048; dmarc=pass policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=mnx.io; iprev=pass smtp.remote-ip=40.107.100.133 (mail-bn8nam04on2133.outbound.protection.outlook.com); spf=permerror smtp.mailfrom=danmcd@mnx.io smtp.helo=NAM04-BN8-obe.outbound.protection.outlook.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=fail smtp.helo=NAM04-BN8-obe.outbound.protection.outlook.com policy.ptr=mail-bn8nam04on2133.outbound.protection.outlook.com; x-return-mx=pass header.domain=mnx.io policy.is_org=yes (MX Records found: mx1-us1.ppe-hosted.com,mx2-us1.ppe-hosted.com); x-return-mx=pass smtp.domain=mnx.io policy.is_org=yes (MX Records found: mx1-us1.ppe-hosted.com,mx2-us1.ppe-hosted.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgedvledrfedutddgudefhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffuthffkfgtgfggsehtqhhmtddttddvnecu hfhrohhmpeffrghnucfotgffohhnrghlugcuoegurghnmhgtugesmhhngidrihhoqeenuc ggtffrrghtthgvrhhnpeeuueeivdfhvdegtedvvdeikeetheelheejkeegtdejjedvlefg heeltdevkeegtdenucffohhmrghinhepihhllhhumhhoshdrohhrghenucfkphepgedtrd dutdejrddutddtrddufeefpddviedtfeemuddtsgeimedvtdekmeefkegumeemieenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeegtddruddtjedruddttd drudeffedphhgvlhhopefptefotdegqdeupfekqdhosggvrdhouhhtsghouhhnugdrphhr ohhtvggtthhiohhnrdhouhhtlhhoohhkrdgtohhmpdhmrghilhhfrhhomhepoegurghnmh gtugesmhhngidrihhoqedpnhgspghrtghpthhtohepuddprhgtphhtthhopeeouggvvhgv lhhophgvrheslhhishhtshdrihhllhhumhhoshdrohhrgheq X-ME-VSScore: -100 X-ME-VSCategory: clean Received-SPF: permerror (mnx.io: Included domain 'dispatch-us.ppe-hosted.com' has no applicable sender policy) receiver=tb-mx1.topicbox.com; identity=mailfrom; envelope-from="danmcd@mnx.io"; helo=NAM04-BN8-obe.outbound.protection.outlook.com; client-ip=40.107.100.133 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2133.outbound.protection.outlook.com [40.107.100.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx1.topicbox.com (Postfix) with ESMTPS for ; Mon, 10 Jun 2024 15:26:31 -0400 (EDT) (envelope-from danmcd@mnx.io) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GNwXTMQ1l9THecaE+DqId6xKtVm5Gtkn4A5wSn9H9tvUkHeTaTKNlBU2UuRA4BTupp0YbMVbt0RejiicP7npFu+GTav8e7bFdrg4selpUF9/X6Dex4tdhzWKPG245ZNucTCi3oL6Xo4vqGEQbMlJAANpX9Rvf3q1tuJbdaumhXponBXiDA6dp7SaZPaOlw9wQwMIZ30zd21JWbfoRG2XKsvwWOabzCM9a5IwMsrpdCHhynvM/HD+tb/dXFdvxrx1TpCnqvW6fohQCgi0eEdWEn82Z/M0cytd2b7o+oVg6TPradpwNrId4iDCx4xryX+wxxgY7e7ZpUO1rNlx+Vbi/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GGAoy4LtyZLC/98gwQebYiAT3aBDGyPqLqefL13XP4U=; b=Khy17+I9Hlsfc+iZ4Ssxfm9cOIqf3qfa44Y4WlOObSVJAOWfu01N2hPxSsUfJhpNgFo8SBIeIm8wvOcCKkzusau8hCrMNz1YGUlRddhim87sqA8YhJXi8YEO07W9uhyx8e1UqFTD0nibLoiU9o2sohnddlEcNa3DaVkQs2z8N8c6lJyvg2VVRTzBA6aPdURKnn99wPoTzVJLk8a+XhtILGxP46xrCc/47k+WAVt5RgcSZSrKEPNyBlh3iHEDzgkPL74EjqUfW1WmK3fANmeZN8woQsQOCSo9p66eXzCOCmRr2Tw6WGKDnXFt7tyryq2RyCL8UYGtdFyIugsJWyK3RA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mnx.io; dmarc=pass action=none header.from=mnx.io; dkim=pass header.d=mnx.io; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mnx.io; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GGAoy4LtyZLC/98gwQebYiAT3aBDGyPqLqefL13XP4U=; b=LYIE0UW5qq7XYoJCdfXkqeYrktOhfPmegGpk7axLwfOi+xLC9yE0rnrXG6iI7Vg8aYmh+84frOkE75WcsORyhYQlXoe16mwbZNUTXjMGy4Yb9V/BDzE5bIXxttmV3KXmVMMBleCe50o5ZUhXvITFgiGVhh6HP1Co2zMTwPoYfmqossWRN3cuV1PdYap6n0x1ukWDVtmVO8TqAnIwm3TzKmrnGnCr/orfKcqzHG7KHgrd2Qa3AUodwWQV4ODpDx8wSCMYg8iii+3lLAWEAiwXL14R0/85vji8decs8OLooU71tpCcu/PQodqXP/Y3Z+rcKQv0oMo0vrpbfXrNbLZ9xQ== Received: from BL3PR12MB6546.namprd12.prod.outlook.com (2603:10b6:208:38d::6) by PH7PR12MB8428.namprd12.prod.outlook.com (2603:10b6:510:243::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.24; Mon, 10 Jun 2024 19:26:25 +0000 Received: from BL3PR12MB6546.namprd12.prod.outlook.com ([fe80::87ab:7887:a69a:90c5]) by BL3PR12MB6546.namprd12.prod.outlook.com ([fe80::87ab:7887:a69a:90c5%5]) with mapi id 15.20.7633.036; Mon, 10 Jun 2024 19:26:25 +0000 From: Dan McDonald To: illumos-developer Subject: QUICK CODE REVIEW: 16601 Remove CERRWARN overrides from aggr(4D) Thread-Topic: QUICK CODE REVIEW: 16601 Remove CERRWARN overrides from aggr(4D) Thread-Index: AQHau2wVHdYbgD6mWkCERYtOwMM6vQ== Date: Mon, 10 Jun 2024 19:26:25 +0000 Message-ID: <8BD2336A-ACE0-4633-9BF1-F170F1302861@mnx.io> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BL3PR12MB6546:EE_|PH7PR12MB8428:EE_ x-ms-office365-filtering-correlation-id: 16babfc5-f112-4071-9173-08dc898337fa x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230031|366007|376005|1800799015|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?6x5W42vCsZ5zhD1oMG+rpZ+ugXAEMb5AOZNaBJAZIr2txZrL1vhWPW96NLJD?= =?us-ascii?Q?kfNGCMJb8cZmM8/xRZRUHWKORh20SorZkc9J+KMbWXMCvpTQRgf6Y9nXx0f0?= =?us-ascii?Q?+Su159VAdWubbcvY0i1a0KdKWjRq3WUBDS90CYSdWJm+C4Xk6Pt7t/+7wc9B?= =?us-ascii?Q?o/FfbaNYw2fVRSF1E55uuZ9RdZog8su/gaqHm9L31IRY+uFUZGOluoJTd2ff?= =?us-ascii?Q?D7naOEaP3jAoRi08+t9vgmTviOUhmszNMnaLAT8dY361TzhLtow3KztLrXUq?= =?us-ascii?Q?k0ZkNSrsD5u2NysKUP/zfEugB1v4s6CEdV+HbMnFcM7SDVg0rEH8ZQyRepBA?= =?us-ascii?Q?50ZRAlzyTFFzjb8awKaVnWEsa+8323Ri/vX7HAjgS5Nci5rFYOPFciHrTyYB?= =?us-ascii?Q?8t4YPnmwDmN+JcdoAwOLqlbQT9vazOcuqrSmM41qUtOusxiVbPiD0tOKAqlO?= =?us-ascii?Q?hwHq8zTGlfvh/mfcK81xw1JrV9IGoQLeGEWiuP3dhG0zU5kAlXoEmTSqPrS4?= =?us-ascii?Q?tBiISv5jp4n72zAahYbDs9Dzml4XfxXOB473s+qDqRFFDZ9GGTptTj0ppZjl?= =?us-ascii?Q?LcRg7dxZdvM3uaUlvDQve3RjbpzA+BOC6YIPsX1qt57RjXTVongmQEWlSCBF?= =?us-ascii?Q?BFR4mxPiRBQoazd5xYhdbJ0Cf7SjiHsPjPb0crU8RrCD+hmtIB2tuchJEjFP?= =?us-ascii?Q?OrxjztfrP/bZJqKXJgj4rB2B/i60gpbRMovYgcPIHvy7wQbmby0fYemO1ylZ?= =?us-ascii?Q?a/FDancZpMn4T+7CBSZgPqCqjO/xcE09lq63E5jGldyH8jjFVUxxwW9S7oFo?= =?us-ascii?Q?C3NLLF4P/I+VWyKPhel3lPQuhHx9S00MeP0SH3s/jsz75Qw9wgl4xP9w5BCk?= =?us-ascii?Q?w43bI0iR/EhQ+pFTrPekbcLhfzrEQPjG2jx9CAK19eK3gkFI+x2d+lGetlce?= =?us-ascii?Q?YoZELJKWzRPref9zr36rCpCYqNw8XtgqupU1wgIUz6IonKuCWq/AhBL6t5VZ?= =?us-ascii?Q?zPaNKuurJudmabrK8h/phV5UyU+G0esIUSvNyZm4PgYaQ8otv2V8QS3Nc4Ek?= =?us-ascii?Q?hi5nrXOOYqkwt1AYIYdRwcphQK48RGM4Ei8d/6YRdwmx9VYsIyL0qVHswFCE?= =?us-ascii?Q?zDOwLYxtAM7kycT5MwgZ2eZyTcaB1kDr1kckDuPiIfp+Ad905qqAi4FnaRw2?= =?us-ascii?Q?Mp/NrTsr34MImrcQ13gxpIHGKZmCDNJoG9Bh9dkc04XirEpeC6f80N/8rWzv?= =?us-ascii?Q?WNwIsjaiYfUtyCljbsiOyeok4CGBdmXqUB36eqYz3Hvcxr6yYwOkubp2ULgR?= =?us-ascii?Q?9oTtc07QeR+44lKdprobCYq+?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL3PR12MB6546.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(1800799015)(38070700009);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wgCj9BAjRfRCr0OUSoMOljk3b97gP3ofDd8XWmfcIIuMtyBOqnTrThAhf0zW?= =?us-ascii?Q?II1I0d7PVNhyMXeMBOH1YMg9rEBBwXYLhQvasaAHhjR3M6CgaEkkLaM1AGte?= =?us-ascii?Q?sgX9HbMt5qFlx++A5C9POYqaeihsTUe1NXB1RKbipFdaXOw/L/J0z0TFyvEO?= =?us-ascii?Q?X7CiTMS0OOGnN4L1KzfPh4JlBr03rHu/V1yDVINjlC8+cA5gXEGuoK9UzGhB?= =?us-ascii?Q?3aR4l7uIYyFxrN5byNkP4MFFaEQFB0w19P6rm3c7kXvdgJJtXELk9DDtHXyE?= =?us-ascii?Q?LjJnqScX6GYYRqjDweaz/CRQ5uL6aH3kwv03OS5tYP0+UJRi115T+7fGTLqr?= =?us-ascii?Q?M+8eAvYyowVn/nGLEVu8eM62qlI2WX/Cj0OlhuG3NSCTBZXuFEG9xmjPpEfy?= =?us-ascii?Q?cdUQrqvXxiVSFLym8+FLx6Tj9E5nfRBowT4K/DPaPi7PfmL5mg2ICqsM9ZzU?= =?us-ascii?Q?jaTQgf7lVj2xlMjjN0o3oov4FqIufmvPwUltS2MmID41FR1QY5o6WVL7GqGa?= =?us-ascii?Q?YhRlhmColR+aBH1EM1YBW5JZpILtxRSGXnKegIlJLahfs1aJ++zCqzr3GabR?= =?us-ascii?Q?ZCRaKgB6fJUlvULqprZ0eEKQwNhQ5SXsLc0B4GUqaghZMaXIrBGzXkXcbU8j?= =?us-ascii?Q?StbHIZ4c472/zk+E4L7hsEg2hcnIdk2NwvJ/qKdBrnLRSnm1/+iM9uT/F7sL?= =?us-ascii?Q?7HeYfOkJQ+UJgj3agdMuPEaEBBSZGA9l6KKyaogghC8QNm8L7QoS3UMP5hYC?= =?us-ascii?Q?jb9Cin2Iv3UrMSaf78xzX1np3sqeAFjfXDEa7x4AX//Sah9lr4hIjQgma7L7?= =?us-ascii?Q?Nn/SsFVA4wgOAjYR9Oh5uau6MfrjIp+O6aa+MA/UdNkCScMdu5D50XSUwVoC?= =?us-ascii?Q?OT74p4gQLYDTku/76rVtX2nEDCsG9BELzYwZFg27ungdcphRjg0zqR3lySMz?= =?us-ascii?Q?GdwsL5Pbb9Dc27Tj4nWw56XALtKC7UNXLr/dvECoHyqFVn3vX/d2Iy04ez0j?= =?us-ascii?Q?4bniT7pkeyndZ9SiO1MMbggXVkLt4aAyQ8zYIqMd8C9ihrkIDGRWd8E1DmQX?= =?us-ascii?Q?EGOJbYe6HBnWcQn0wENEs/NvLPMEBvjYguWxeCvhmFyT42E3EmKikTvvT8og?= =?us-ascii?Q?wrCqQxRiCFKFnwungww/LbdqUXLTSr8HofrIXXNY2yelK6g1TSsqv9VR2OJn?= =?us-ascii?Q?T+595znSnGcmTuoovw14arjr1DCFMViCPOcwUzx1hJwEq5g5x7feBBHe+1tX?= =?us-ascii?Q?T5Efwx90rNRIvSMSV5oUG9x/pevIJ7rPE1V2Q+bQGENef1/KmFvuQ5jPIO4H?= =?us-ascii?Q?WsfZQxlgLgKjWA2ItLHtwdF1p4fpHtKnYdBdWFBTkILMJx8N8xATIWMdPEN/?= =?us-ascii?Q?TmqrBgpaEFuARXbhHc12vLD+IJy1eLmxB7x1fGOzaveF65vI+7sdDqqwHjaF?= =?us-ascii?Q?2xDg//+qny3gC4kKjTz8daxiJCpo9/G4ad6NpxiZ8cakywbrJJr+rkrFLtax?= =?us-ascii?Q?Obbrv1p9XkSYVx7zN7A0yxA36q5rGT9LIAKA2GKhGYNwPN+eDNu3gSeyD+h6?= =?us-ascii?Q?cJsMSRUf7Way5QfTNTBDHsZUbDchAb6CYMde75Pj?= Content-Type: text/plain; charset="us-ascii" Content-ID: <89FABDC45F18A04593F6CB526ED4F248@namprd12.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: mnx.io X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL3PR12MB6546.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 16babfc5-f112-4071-9173-08dc898337fa X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jun 2024 19:26:25.2088 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7cbbbccb-a73b-4293-8866-194afab248db X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ElHQvQWgXYyBc/Hl76c5npVR7uQ4pjqkzcKf2JqOwUxYHU1vyYJS4bwY0uGUD9dE X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8428 X-Received-Authentication-Results: (Received Authentication-Results header removed by tb-mx1.topicbox.com) dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mnx.io; Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: 5af2ab8a-275f-11ef-9de4-d8de2e64f993 I wanted to make sure there was nothing OBVIOUSLY stupid in aggr(4D) on beh= alf of a customer, and decided to rip out the CERRWARN overrides. Nothing shocking changed, however, and disassembly diffs are in the ticket: Gerrit: https://code.illumos.org/c/illumos-gate/+/3544 Thanks, Dan