public inbox for developer@lists.illumos.org (since 2011-08)
 help / color / mirror / Atom feed
From: "Bill Sommerfeld via illumos-developer" <developer@lists.illumos.org>
To: developer@lists.illumos.org
Subject: [developer] [REVIEW] 16879 pkglint fails on openindiana with more unexpected /32 packages
Date: Sat, 2 Nov 2024 15:20:41 -0700	[thread overview]
Message-ID: <911badd6-e014-41bb-be63-46c5e0f72aa8@hamachi.org> (raw)

Issue: https://www.illumos.org/issues/16879
CR: https://code.illumos.org/c/illumos-gate/+/3802
Diff: 
https://code.illumos.org/~diff/b1a9444e1f5d06443e3976a9de97f58b87734085

About a month ago, a fix for https://www.illumos.org/issues/16820 was
integrated to fix a pkglint failure during nightly due to a
newly-introduced packaging change in openindiana.

Since then, Openindiana has created additional /32 variant packages
and once again the pkglint phase is failing when building illumos-gate
on latest stock openindiana.

I have what I think is a better solution: add a PKGEXTRASUFFIX
variable which can be set to "/32" when building on openindiana, and use 
that to expand the exception list (each package in the exception list 
file is listed twice -- once with $(PKGEXTRASUFFIX) appended, and once 
without).

This fix relies on two properties of pkglint's "missing-deps" handling:
  1) duplicate entries are harmless
  2) extra entries that don't match system packages are harmless.

I'd appreciate review; I'd also appreciate help from anyone who can
do illumos-gate builds of this change on other distributions to make 
sure I didn't break their build.

Thanks in advance for your review and your help.




------------------------------------------
illumos: illumos-developer
Permalink: https://illumos.topicbox.com/groups/developer/T766b6431bc70682f-Me798bdd0b719633da4bb0c35
Delivery options: https://illumos.topicbox.com/groups/developer/subscription

                 reply	other threads:[~2024-11-02 22:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=911badd6-e014-41bb-be63-46c5e0f72aa8@hamachi.org \
    --to=developer@lists.illumos.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).