public inbox for developer@lists.illumos.org (since 2011-08)
 help / color / mirror / Atom feed
From: "Toomas Soome via illumos-developer" <developer@lists.illumos.org>
To: illumos-developer <developer@lists.illumos.org>
Subject: [developer] REVIEW: 16833 smbsrv: array subscript 12 is above array bounds
Date: Mon, 14 Oct 2024 11:06:24 +0300	[thread overview]
Message-ID: <9B747CE8-489F-48F5-8815-19022D93A676@me.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

hi!

This is one of the reason I did create https://www.illumos.org/issues/16804 But since 16804 is opposed, I have to set this one rolling.

So, please review: https://code.illumos.org/c/illumos-gate/+/3736

Since VERIFY() does not hint compiler in any way, there is no reason to believe the bounds check is in place and we do get the warning. So, we have two options - either suppress the warning or show compiler we have bounds check. Here, in this version, we add this extra if statement.

Thanks,
Toomas
------------------------------------------
illumos: illumos-developer
Permalink: https://illumos.topicbox.com/groups/developer/T53d2b90fb40c40e0-Mc22160eebf654bf2e8ea2eac
Delivery options: https://illumos.topicbox.com/groups/developer/subscription

[-- Attachment #2: Type: text/html, Size: 2122 bytes --]

             reply	other threads:[~2024-10-14  8:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-14  8:06 Toomas Soome via illumos-developer [this message]
2024-10-20 13:09 ` [developer] " Toomas Soome via illumos-developer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9B747CE8-489F-48F5-8815-19022D93A676@me.com \
    --to=developer@lists.illumos.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).