From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=3.4.4 Received: from tb-ob1.topicbox.com (tb-ob1.topicbox.com [64.147.108.173]) by inbox.vuxu.org (Postfix) with ESMTP id 15AF327D43 for ; Mon, 14 Oct 2024 10:06:53 +0200 (CEST) Received: from tb-mx1.topicbox.com (tb-mx1.nyi.icgroup.com [10.90.30.61]) by tb-ob1.topicbox.com (Postfix) with ESMTP id B15432928D for ; Mon, 14 Oct 2024 04:06:52 -0400 (EDT) (envelope-from bounce.mMc22160eebf654bf2e8ea2eac.r81958daa-7202-11ef-bbf2-18142b2d11b0@illumos.bounce.topicbox.com) Received: by tb-mx1.topicbox.com (Postfix, from userid 1132) id 932862409E36; Mon, 14 Oct 2024 04:06:52 -0400 (EDT) ARC-Authentication-Results: i=2; topicbox.com; arc=pass; dkim=pass (2048-bit rsa key sha256) header.d=me.com header.i=@me.com header.b=k4Q4ng1x header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=me.com; spf=pass smtp.mailfrom=tsoome@me.com smtp.helo=qs51p00im-qukt01080102.me.com; x-internal-arc=fail (as.1.topicbox.com=pass, ams.1.topicbox.com=fail (message has been altered)) (Message modified while forwarding at Topicbox) ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=content-type:mime-version:message-id:date:to :list-help:list-id:list-post:list-subscribe:reply-to:subject :content-transfer-encoding:from:list-unsubscribe; s=sysmsg-1; t= 1728893212; bh=72/tXfpqTwndD6fhoCWanyytrgoPdOv/UYKa1R6HYls=; b=j qRPiop2C9+uM4LjfFnbZbNg/2WGUnOwux4KCv4xd9xOzCRor9ZdxN+nhp0TtDpTm YE+s/c/R8va4TRTKcuDbZMtCFmRbx9uIPt01fBUFDVSxaLrE5uO8qNI9jiH6TbJ2 ASBo1i2NhZUx3BUbwUhtztjCqNx9UvlTACp0Sk/svk= ARC-Seal: i=2; a=rsa-sha256; cv=pass; d=topicbox.com; s=sysmsg-1; t= 1728893212; b=m9cRIfv2Z3rSXxgkeekqaB98bXcMhn7iwqzAQpDWhCcTbxYBb1 hLtNwK9hHK0TEuXxb+2AilbEiJ0Ph20WqWkK3IuGsl8fd1oNT0lC94apTdWMqcXO zKLuMJNGBMQfV/wQlYzAKi6+J4NkU8PwTBNS3O0Aau/pa51TCAEUU9f/Y= Authentication-Results: topicbox.com; arc=pass; dkim=pass (2048-bit rsa key sha256) header.d=me.com header.i=@me.com header.b=k4Q4ng1x header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=me.com; spf=pass smtp.mailfrom=tsoome@me.com smtp.helo=qs51p00im-qukt01080102.me.com; x-internal-arc=fail (as.1.topicbox.com=pass, ams.1.topicbox.com=fail (message has been altered)) (Message modified while forwarding at Topicbox) X-Received-Authentication-Results: tb-mx0.topicbox.com; arc=none (no signatures found); bimi=declined (Domain declined to participate); dkim=pass (2048-bit rsa key sha256) header.d=me.com header.i=@me.com header.b=k4Q4ng1x header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=me.com; iprev=pass smtp.remote-ip=17.57.155.19 (qs51p00im-qukt01080102.me.com); spf=pass smtp.mailfrom=tsoome@me.com smtp.helo=qs51p00im-qukt01080102.me.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=qs51p00im-qukt01080102.me.com policy.ptr=qs51p00im-qukt01080102.me.com; x-return-mx=pass header.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-return-mx=pass smtp.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lists.illumos.org; h= content-type:mime-version:message-id:date:to:list-help:list-id :list-post:list-subscribe:reply-to:subject :content-transfer-encoding:from:list-unsubscribe; s=dkim-1; t= 1728893212; x=1728979612; bh=foXYY99oyhRP2sr1mhXVX/TBKhRzJpGW1GZ 5ocUsy+0=; b=ani23DunMDh+VKUuJA2vTOFv04Q0hPWiuX0TOZ763SPkRk0zMds 1MSYHlz8JPPIGN+OFKAvZprbDckaBzXmvzx2tiI+0hiczzRhkpioj0vx+xp8Hh47 z9jjDVm34k6n2obBgeU7D5w1s6eODv6zMkenfini/UwdgzKth1E3mNq0= Received: from tb-mx0.topicbox.com (localhost.local [127.0.0.1]) by tb-mx0.topicbox.com (Postfix) with ESMTP id D4A6A551654 for ; Mon, 14 Oct 2024 04:06:39 -0400 (EDT) (envelope-from tsoome@me.com) Received: from tb-mx0.topicbox.com (localhost [127.0.0.1]) by tb-mx0.topicbox.com (Authentication Milter) with ESMTP id 2311C8B61E2; Mon, 14 Oct 2024 04:06:39 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1728893199; b=eCxJFBfXhmAszcgRG7PnNyP2tEk6lYTwLKrwBoBkizNa/hZ/Ox Che2eE5tLBl4Ayykx/1uCYZy/3J+im8PbYQnousM1LPtP2MOcRNPhBPf/r9G+BUJ ql+NLsYTlPpiAGaF9Q8Fr/Z54IudXOobBUlob61dY6CT7C6NTHUVQ2AnndfL/KJP 4WYNzCdUaOnw9LLqC4fHM8ZcJ5t8lE56Eds+0I6DWFeQNc/02bB4d3KQjTwKS/Ne S6Y+qANRImZEqLE/P69zs0ex2SG4DES4NH0rCSN8PNinhAf93BsaAU6Ll+T1qd7i bLOwbIWLcWzT4WTmwaKkZOWjA6TT4QvXPdIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=from:content-type:mime-version:subject :message-id:date:to; s=arcseal; t=1728893199; bh=qKWjOvMy8Igfp0f 2qfSGwPw72SBw68tMldE7uETszj0=; b=wVwWCWL20dy9OV/hg8d39wXDj8LvEtZ Tsmt4aDV6Qqb09muqQJze5d9X1Joz3zd/IeKmWnZbGuPJLjSuWyh6QxKTmNDpGiL xDR2BrWcuBitOzfmD+q1TwfYZPCbiit3MRX+PcqL6qEG0nieb1r0YOy4uflp/yoZ Y+s0dB0CTKeSW6548jYihtKz9+bMEdmqhKLulCNWadPQKm2aG1xHITfyNzKXE4aG hkJs7FDWxKDAxvXSlyszvauDdI8S3ECYbVflVGEa8Sy0QyPvlQ02tfN3I4whPlH+ i3VOoy5GoRJPEFtYuHTwiZHA5CQxdXIetQQgS8AAcjkryCHeNcqL0WQ== ARC-Authentication-Results: i=1; tb-mx0.topicbox.com; arc=none (no signatures found); bimi=declined (Domain declined to participate); dkim=pass (2048-bit rsa key sha256) header.d=me.com header.i=@me.com header.b=k4Q4ng1x header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=me.com; iprev=pass smtp.remote-ip=17.57.155.19 (qs51p00im-qukt01080102.me.com); spf=pass smtp.mailfrom=tsoome@me.com smtp.helo=qs51p00im-qukt01080102.me.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=qs51p00im-qukt01080102.me.com policy.ptr=qs51p00im-qukt01080102.me.com; x-return-mx=pass header.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-return-mx=pass smtp.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdeggedguddvkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhtggguffkfffvofesrgdtmherhhdtvdenucfh rhhomhepvfhoohhmrghsucfuohhomhgvuceothhsohhomhgvsehmvgdrtghomheqnecugg ftrfgrthhtvghrnhepudehkeeufffhhfejvdejtdetiedvtdelfeeugfekvedthfehvefh udehffffvdehnecuffhomhgrihhnpehilhhluhhmohhsrdhorhhgnecukfhppedujedrhe ejrdduheehrdduledpudejrdehjedrudehhedrvdeknecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehinhgvthepudejrdehjedrudehhedrudelpdhhvghlohepqhhshe duphdttdhimhdqqhhukhhttddutdektddutddvrdhmvgdrtghomhdpmhgrihhlfhhrohhm peeothhsohhomhgvsehmvgdrtghomheqpdhnsggprhgtphhtthhopedupdhrtghpthhtoh epoeguvghvvghlohhpvghrsehlihhsthhsrdhilhhluhhmohhsrdhorhhgqe X-ME-VSScore: -100 X-ME-VSCategory: clean Received-SPF: pass (me.com: 17.57.155.19 is authorized to use 'tsoome@me.com' in 'mfrom' identity (mechanism 'ip4:17.57.155.0/24' matched)) receiver=tb-mx0.topicbox.com; identity=mailfrom; envelope-from="tsoome@me.com"; helo=qs51p00im-qukt01080102.me.com; client-ip=17.57.155.19 Received: from qs51p00im-qukt01080102.me.com (qs51p00im-qukt01080102.me.com [17.57.155.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx0.topicbox.com (Postfix) with ESMTPS for ; Mon, 14 Oct 2024 04:06:39 -0400 (EDT) (envelope-from tsoome@me.com) Received: from smtpclient.apple (qs51p00im-dlb-asmtp-mailmevip.me.com [17.57.155.28]) by qs51p00im-qukt01080102.me.com (Postfix) with ESMTPSA id A06571CC018B for ; Mon, 14 Oct 2024 08:06:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="Apple-Mail=_87268063-DA55-48A4-8FD9-EC9823DC50A4" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\)) Message-Id: <9B747CE8-489F-48F5-8815-19022D93A676@me.com> Date: Mon, 14 Oct 2024 11:06:24 +0300 To: illumos-developer X-Mailer: Apple Mail (2.3818.100.11.1.3) X-Proofpoint-ORIG-GUID: 1GVozVEdhJAtDyicXtB-sb2gC2VQhSMV X-Proofpoint-GUID: 1GVozVEdhJAtDyicXtB-sb2gC2VQhSMV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-14_07,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 clxscore=1015 spamscore=0 phishscore=0 mlxscore=0 adultscore=0 suspectscore=0 mlxlogscore=929 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2410140058 Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: 4046ec9a-8a03-11ef-9bb2-54bb088c7b06 Archived-At: =?UTF-8?B?PGh0dHBzOi8vaWxsdW1vcy50b3BpY2JveC5jb20vZ3JvdXBz?= =?UTF-8?B?L2RldmVsb3Blci9UNTNkMmI5MGZiNDBjNDBlMC1NYzIyMTYwZWViZjY1NGJm?= =?UTF-8?B?MmU4ZWEyZWFjPg==?= List-Help: List-Id: "illumos-developer" List-Post: List-Software: Topicbox v0 List-Subscribe: Precedence: list Reply-To: illumos-developer Subject: [developer] REVIEW: 16833 smbsrv: array subscript 12 is above array bounds Content-Transfer-Encoding: 7bit From: "Toomas Soome via illumos-developer" List-Unsubscribe: , Topicbox-Delivery-ID: 2:illumos:a901537c-2aea-11e7-965f-d98f9f16e227:81958daa-7202-11ef-bbf2-18142b2d11b0:Mc22160eebf654bf2e8ea2eac:1:J5eQ1KVvO35GJsD3YHx29QrNBCiB9PCz2cYcyHuwUvw --Apple-Mail=_87268063-DA55-48A4-8FD9-EC9823DC50A4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 hi! This is one of the reason I did create https://www.illumos.org/issues/16804= But since 16804 is opposed, I have to set this one rolling. So, please review: https://code.illumos.org/c/illumos-gate/+/3736 Since VERIFY() does not hint compiler in any way, there is no reason to bel= ieve the bounds check is in place and we do get the warning. So, we have tw= o options - either suppress the warning or show compiler we have bounds che= ck. Here, in this version, we add this extra if statement. Thanks, Toomas ------------------------------------------ illumos: illumos-developer Permalink: https://illumos.topicbox.com/groups/developer/T53d2b90fb40c40e0-= Mc22160eebf654bf2e8ea2eac Delivery options: https://illumos.topicbox.com/groups/developer/subscription --Apple-Mail=_87268063-DA55-48A4-8FD9-EC9823DC50A4 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=UTF-8 hi!

This is one of the reason I did create https://www.illumos.org/issues/16804 Bu= t since 16804 is opposed, I have to set this one rolling.

<= /div>
So, please review: https://code.illumos.org/c/illumos-gate/+/3736

Since VERIFY() does not hint compiler in any w= ay, there is no reason to believe the bounds check is in place and we do ge= t the warning. So, we have two options - either suppress the warning or sho= w compiler we have bounds check. Here, in this version, we add this extra i= f statement.

Thanks,
= To= omas
= --Apple-Mail=_87268063-DA55-48A4-8FD9-EC9823DC50A4--