[developer] REVIEW: 16833 smbsrv: array subscript 12 is above array bounds

[developer] REVIEW: 16833 smbsrv: array subscript 12 is above array bounds

[Toomas Soome via illumos-developer]

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

hi!

This is one of the reason I did create https://www.illumos.org/issues/16804 But since 16804 is opposed, I have to set this one rolling.

So, please review: https://code.illumos.org/c/illumos-gate/+/3736

Since VERIFY() does not hint compiler in any way, there is no reason to believe the bounds check is in place and we do get the warning. So, we have two options - either suppress the warning or show compiler we have bounds check. Here, in this version, we add this extra if statement.

Thanks,
Toomas
------------------------------------------
illumos: illumos-developer
Permalink: https://illumos.topicbox.com/groups/developer/T53d2b90fb40c40e0-Mc22160eebf654bf2e8ea2eac
Delivery options: https://illumos.topicbox.com/groups/developer/subscription

[-- Attachment #2: Type: text/html, Size: 2122 bytes --]

[developer] Re: REVIEW: 16833 smbsrv: array subscript 12 is above array bounds

[Toomas Soome via illumos-developer]

[-- Attachment #1: Type: text/plain, Size: 891 bytes --]

Ping?

thanks,
toomas

> On 14. Oct 2024, at 11:06, Toomas Soome <tsoome@me.com> wrote:
> 
> hi!
> 
> This is one of the reason I did create https://www.illumos.org/issues/16804 But since 16804 is opposed, I have to set this one rolling.
> 
> So, please review: https://code.illumos.org/c/illumos-gate/+/3736
> 
> Since VERIFY() does not hint compiler in any way, there is no reason to believe the bounds check is in place and we do get the warning. So, we have two options - either suppress the warning or show compiler we have bounds check. Here, in this version, we add this extra if statement.
> 
> Thanks,
> Toomas

------------------------------------------
illumos: illumos-developer
Permalink: https://illumos.topicbox.com/groups/developer/T53d2b90fb40c40e0-Mc99255057cc5531aa2d7015c
Delivery options: https://illumos.topicbox.com/groups/developer/subscription

[-- Attachment #2: Type: text/html, Size: 2585 bytes --]