Re: [developer] Review - 15665 svc:/network/loopback exits successfully even if it fails

[Andy Fiddaman <illumos@fiddaman.net>]

On Wed, 7 Aug 2024, Andy Fiddaman wrote:

>
> On Fri, 26 Jul 2024, Peter Tribble wrote:
>
> > As I mentioned in my other reply, it seems that what we're after is some
> > way to mark
> > a service as having generated an error without bringing the system down by
> > going
> > into maintenance. Some sort of degraded mode.
> >
> > We have a couple of SMF exit codes that look interesting -
> > SMF_EXIT_MON_DEGRADE
> > and SMF_EXIT_MON_OFFLINE, but I'm sure they were never implemented. There's
> > even an issue in this area - https://www.illumos.org/issues/7711 (which
> > refers back to 8891
> > which is another case of something dropping into maintenance breaking the
> > entire system).
>
> I have put up https://code.illumos.org/c/illumos-gate/+/3621 which is
> resurrecting work by Andy Stormont to add the missing pieces to support
> degraded services, and then re-worked
> https://code.illumos.org/c/illumos-gate/+/3610/
> on top of that.
>
> This does seem like the best solution - the service does what it can and
> doesn't block others from coming up, yet it shows up as degraded in
> `svcs -x` and co.
>
> My testing's going well so I'll get that sent out for review in the next
> couple of days.
>
> Thanks for all the discussion and feedback on this change!

Now that https://www.illumos.org/issues/7711 has integrated, I am planning
to send the latest version of this for RTI:

    15665 svc:/network/loopback exits successfully even if it fails
    https://www.illumos.org/issues/15665
    https://code.illumos.org/c/illumos-gate/+/3610

This now uses the SMF degraded state rather than maintenance as the original
change did. I think this should address the concerns that were raised and,
again, thanks for the discussions around this.

Andy