From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from tb-mx0.topicbox.com (localhost.local [127.0.0.1]) by tb-mx0.topicbox.com (Postfix) with ESMTP id 10AA01D41E8F for ; Tue, 25 Jun 2024 05:18:13 -0400 (EDT) (envelope-from tsoome@me.com) Received: from tb-mx0.topicbox.com (localhost [127.0.0.1]) by tb-mx0.topicbox.com (Authentication Milter) with ESMTP id 81F79FEFD66; Tue, 25 Jun 2024 05:18:13 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1719307093; b=QBBDQu+1xFPB79WKaeQrT056WS2xaTVUGUKizelC4Zo0aOMPtt 7KzP+wE772xra1Xa+iG7RqVRC+DVO8DL0khoPCN6xW66lUjodr1Yg17jZFu0EExX vBRlpIJ+Ddb2HQk/PSM9EqoELfZvTuCp3d3GHwpBYnHa7Ai/hp5h0ffh0lfJO4K4 d6Mt0uYdxqcRb2FX7oxaFH43+7RksdRChpB4n0yxJcmJ8QB4+5wivnK7J02jN48k WxQpwHA5AScFHYLBM1PcgSmSsKoU+p0Q2cVGNn10z6geakOAgxihMy8sttzkMlPt y512BiUZmysRNNCCjFbEIECNUFiJFw/cHuKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=from:content-type:mime-version:subject :message-id:date:to; s=arcseal; t=1719307093; bh=LdJ3o7WlBc8XGYG Ka/Su7LoLJmHIh1HFZoHtyfgaRa0=; b=dkvCbrO19/qGHxggnKR8HfSOSVDIRqu SIaerL5jG2v9CIOefYgXtcammbOrFSHEzzPTn+In+WnFk2O8Y1iFxA8q7EY6JmHj tMZdoiIYs3UUAbQedoozrNevWkv/JqYX2bAL8+h62xHdH1wtVBFkXsOyvxMrCRwf c3ge4TMInPGGiUnwDZKWonQvT6J1izHG9xino9VboOu5alFH7RIk1zQ4XeHbLZvQ RnCv/pLh69A1+SIG06C1zfcgTXISpBCfh186IMg9jlAh4H61TtZAC39ZzyyDFdaV QdTWl089fiIzZRqxCz4j8ZmW6UGrRJ5l0D+4FBqX6KJxaUTaCdwd+eg== ARC-Authentication-Results: i=1; tb-mx0.topicbox.com; arc=none (no signatures found); bimi=declined (Domain declined to participate); dkim=pass (2048-bit rsa key sha256) header.d=me.com header.i=@me.com header.b=B+yBVteO header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=me.com; iprev=pass smtp.remote-ip=17.58.23.191 (mr85p00im-hyfv06011401.me.com); spf=pass smtp.mailfrom=tsoome@me.com smtp.helo=mr85p00im-hyfv06011401.me.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=mr85p00im-hyfv06011401.me.com policy.ptr=mr85p00im-hyfv06011401.me.com; x-return-mx=pass header.domain=me.com policy.is_org=yes (MX Records found: mx02.mail.icloud.com,mx01.mail.icloud.com); x-return-mx=pass smtp.domain=me.com policy.is_org=yes (MX Records found: mx02.mail.icloud.com,mx01.mail.icloud.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 Authentication-Results: tb-mx0.topicbox.com; arc=none (no signatures found); bimi=declined (Domain declined to participate); dkim=pass (2048-bit rsa key sha256) header.d=me.com header.i=@me.com header.b=B+yBVteO header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=me.com; iprev=pass smtp.remote-ip=17.58.23.191 (mr85p00im-hyfv06011401.me.com); spf=pass smtp.mailfrom=tsoome@me.com smtp.helo=mr85p00im-hyfv06011401.me.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=mr85p00im-hyfv06011401.me.com policy.ptr=mr85p00im-hyfv06011401.me.com; x-return-mx=pass header.domain=me.com policy.is_org=yes (MX Records found: mx02.mail.icloud.com,mx01.mail.icloud.com); x-return-mx=pass smtp.domain=me.com policy.is_org=yes (MX Records found: mx02.mail.icloud.com,mx01.mail.icloud.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgedvledrfeegfedgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephfgtggfukfffvffosegrtdhmrehhtddvnecuhfhr ohhmpefvohhomhgrshcuufhoohhmvgcuoehtshhoohhmvgesmhgvrdgtohhmqeenucggtf frrghtthgvrhhnpeduheekueffhffhjedvjedtteeivddtleefuefgkeevtdfhheevhfdu heffffdvheenucffohhmrghinhepihhllhhumhhoshdrohhrghenucfkphepudejrdehke drvdefrdduledupddujedrheejrdduhedvrddukeenucevlhhushhtvghrufhiiigvpedt necurfgrrhgrmhepihhnvghtpedujedrheekrddvfedrudeluddphhgvlhhopehmrhekhe hptddtihhmqdhhhihfvhdtiedtuddugedtuddrmhgvrdgtohhmpdhmrghilhhfrhhomhep oehtshhoohhmvgesmhgvrdgtohhmqedpnhgspghrtghpthhtohepuddprhgtphhtthhope eouggvvhgvlhhophgvrheslhhishhtshdrihhllhhumhhoshdrohhrgheq X-ME-VSScore: -100 X-ME-VSCategory: clean Received-SPF: pass (me.com: 17.58.23.191 is authorized to use 'tsoome@me.com' in 'mfrom' identity (mechanism 'ip4:17.58.0.0/16' matched)) receiver=tb-mx0.topicbox.com; identity=mailfrom; envelope-from="tsoome@me.com"; helo=mr85p00im-hyfv06011401.me.com; client-ip=17.58.23.191 Received: from mr85p00im-hyfv06011401.me.com (mr85p00im-hyfv06011401.me.com [17.58.23.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx0.topicbox.com (Postfix) with ESMTPS for ; Tue, 25 Jun 2024 05:18:12 -0400 (EDT) (envelope-from tsoome@me.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=me.com; s=1a1hai; t=1719307091; bh=LdJ3o7WlBc8XGYGKa/Su7LoLJmHIh1HFZoHtyfgaRa0=; h=From:Content-Type:Mime-Version:Subject:Message-Id:Date:To; b=B+yBVteOMt9BCApkqOcksgX32BwG5Qe4sYJ8KcaZbH/ym+zruK2t5PjCWtBtIXQg/ UNZMhP6iTxqXHca6GaYs4ykBMAu56hGFaCfoPR1pPTOtC52qxLrfU6B+lkdddzXCiw 1VpxAhkpP05wtbdCZLISpcCcIgjqO4gnRXiWE3fcyr7Zs3ZUysjO834j7e40WmHaFU XCrPDA01713D5pPI2f/Y77ul5TAhX/9qH/DJIpU9uZDJOyXSoXQHuNZ+O/ZtBZtum7 TCvvGTeg/NVD5/7O0r9ngpVsK71VPe35u0VhPpVcooW05kimk/mKJNUA8ev3g+ystQ U+lfgo4ww2rjA== Received: from smtpclient.apple (mr38p00im-dlb-asmtp-mailmevip.me.com [17.57.152.18]) by mr85p00im-hyfv06011401.me.com (Postfix) with ESMTPSA id E4534357B467 for ; Tue, 25 Jun 2024 09:18:10 +0000 (UTC) From: Toomas Soome Content-Type: multipart/alternative; boundary="Apple-Mail=_A7C1E97F-A55E-4158-8339-C3F97DEC9BDC" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\)) Subject: REVIEW: 16625 audio: suggest parentheses around assignment used as truth value Message-Id: Date: Tue, 25 Jun 2024 12:17:56 +0300 To: illumos-developer X-Mailer: Apple Mail (2.3774.600.62) X-Proofpoint-ORIG-GUID: CPXPBQaAXPdX71IDbs0W4n90ZXG8qB8z X-Proofpoint-GUID: CPXPBQaAXPdX71IDbs0W4n90ZXG8qB8z X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-25_04,2024-06-24_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 clxscore=1015 phishscore=0 mlxscore=0 mlxlogscore=746 spamscore=0 adultscore=0 suspectscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2406250063 Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: db7371a2-32d3-11ef-b580-beee068c7b06 --Apple-Mail=_A7C1E97F-A55E-4158-8339-C3F97DEC9BDC Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii hi! Please review: https://code.illumos.org/c/illumos-gate/+/3557 Number of issues in cmd/audio. thanks, toomas --Apple-Mail=_A7C1E97F-A55E-4158-8339-C3F97DEC9BDC Content-Transfer-Encoding: 7bit Content-Type: text/html; charset=us-ascii hi!


Number of issues in cmd/audio.

thanks,
toomas
--Apple-Mail=_A7C1E97F-A55E-4158-8339-C3F97DEC9BDC--