[REVIEW] xhci improvements (16512-16515)

[REVIEW] xhci improvements (16512-16515)

[Joshua M. Clulow]

Hi folks,

I have a series of improvements to the "xhci" driver that I've been
working on.  I believe they are ready for review:

  16512 xhci leaks oneshot interrupt IN transfers on pipe reset
      https://www.illumos.org/issues/16512
      https://code.illumos.org/c/illumos-gate/+/3439

  16513 xhci asks if you've heard the good news about the stop endpoint
    command
      https://www.illumos.org/issues/16513
      https://code.illumos.org/c/illumos-gate/+/3440

  16514 xhci panic on pipe open failure
      https://www.illumos.org/issues/16514
      https://code.illumos.org/c/illumos-gate/+/3441

  16515 xhci should unconfigure periodic endpoints to release bandwidth
      https://www.illumos.org/issues/16515
      https://code.illumos.org/c/illumos-gate/+/3442

Cheers.

-- 
Joshua M. Clulow
http://blog.sysmgr.org

Re: [developer] [REVIEW] xhci improvements (16512-16515)

[Gary Mills]

On Sun, Apr 28, 2024 at 09:44:36AM -0700, Joshua M. Clulow wrote:

>   16513 xhci asks if you've heard the good news about the stop endpoint
>     command
>       https://www.illumos.org/issues/16513
>       https://code.illumos.org/c/illumos-gate/+/3440

Do you have a binary of the xhci driver that I could download and
install on my test system?  I only have to reboot, and will know
within a minute if it solves my problem (reported as part of bug
13843).

I looked only at 16513.  It seems like it will work for me.  A test
would confirm that it does.  Either way I'll review the bug report.


-- 
-Gary Mills-		-refurb-		-Winnipeg, Manitoba, Canada-

Re: [developer] [REVIEW] xhci improvements (16512-16515)

[Stephan Althaus]

On 5/5/24 22:44, Gary Mills wrote:
> On Sun, Apr 28, 2024 at 09:44:36AM -0700, Joshua M. Clulow wrote:
>
>>    16513 xhci asks if you've heard the good news about the stop endpoint
>>      command
>>        https://www.illumos.org/issues/16513
>>        https://code.illumos.org/c/illumos-gate/+/3440
> Do you have a binary of the xhci driver that I could download and
> install on my test system?  I only have to reboot, and will know
> within a minute if it solves my problem (reported as part of bug
> 13843).
>
> I looked only at 16513.  It seems like it will work for me.  A test
> would confirm that it does.  Either way I'll review the bug report.
>
>
Hello!

I have a system with a APC UPS connected via USB,
that does connect/disconnect/connect/... on a USB 3 port,
and is working flawless on a USB-2.0-only port.

I could run a test on that system - if i would know how to integrate 
your work..

Regards,
Stephan

Re: [developer] [REVIEW] xhci improvements (16512-16515)

[Yuri Pankov]

On Mon, May 6, 2024, at 1:47 PM, Stephan Althaus wrote:
> On 5/5/24 22:44, Gary Mills wrote:
>> On Sun, Apr 28, 2024 at 09:44:36AM -0700, Joshua M. Clulow wrote:
>>
>>>    16513 xhci asks if you've heard the good news about the stop endpoint
>>>      command
>>>        https://www.illumos.org/issues/16513
>>>        https://code.illumos.org/c/illumos-gate/+/3440
>> Do you have a binary of the xhci driver that I could download and
>> install on my test system?  I only have to reboot, and will know
>> within a minute if it solves my problem (reported as part of bug
>> 13843).
>>
>> I looked only at 16513.  It seems like it will work for me.  A test
>> would confirm that it does.  Either way I'll review the bug report.
>>
>>
> Hello!
>
> I have a system with a APC UPS connected via USB,
> that does connect/disconnect/connect/... on a USB 3 port,
> and is working flawless on a USB-2.0-only port.
>
> I could run a test on that system - if i would know how to integrate 
> your work..

FWIW, I have the same issue with APC (now Schneider) UPS and Windows 11, so at this point I’m blaming the UPS (it would be nice if xhci improvements would fix that for you though).

Re: [developer] [REVIEW] xhci improvements (16512-16515)

[Juraj Lutter]

> On 6 May 2024, at 14:19, Yuri Pankov <yuri@aetern.org> wrote:
> 
>> Hello!
>> 
>> I have a system with a APC UPS connected via USB,
>> that does connect/disconnect/connect/... on a USB 3 port,
>> and is working flawless on a USB-2.0-only port.
>> 
>> I could run a test on that system - if i would know how to integrate 
>> your work..
> 
> FWIW, I have the same issue with APC (now Schneider) UPS and Windows 11, so at this point I’m blaming the UPS (it would be nice if xhci improvements would fix that for you though).

FWIW, the same issue with APC (Schneider) UPS and FreeBSD (13 and 14).

—
Juraj Lutter
XMPP: juraj (at) lutter.sk
GSM: +421907986576

Re: [developer] [REVIEW] xhci improvements (16512-16515)

[Gary Mills]

On Mon, May 06, 2024 at 07:19:35PM +0700, Yuri Pankov wrote:

>  FWIW, I have the same issue with APC (now Schneider) UPS and
> Windows 11, so at this point I’m blaming the UPS (it would be nice
> if xhci improvements would fix that for you though).

If you are having trouble with Windows, see Microsoft support.

If you are having trouble with an APC UPS, see APC support.  APC
support is really good.  One of my UPSes is misbehaving and they are
sending a replacement.


-- 
-Gary Mills-		-refurb-		-Winnipeg, Manitoba, Canada-

Re: [developer] [REVIEW] xhci improvements (16512-16515)

[Stephan Althaus]

Hello!

Is there progress on this topic?

If you do need some more testing, i would try to do so !?

Regards,

Stephan