From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4 Received: from tb-ob1.topicbox.com (tb-ob1.topicbox.com [64.147.108.173]) by inbox.vuxu.org (Postfix) with ESMTP id 6E67D2E154 for ; Sun, 20 Oct 2024 15:11:58 +0200 (CEST) Received: from tb-mx0.topicbox.com (tb-mx0.nyi.icgroup.com [10.90.30.73]) by tb-ob1.topicbox.com (Postfix) with ESMTP id A66AA38E72 for ; Sun, 20 Oct 2024 09:11:58 -0400 (EDT) (envelope-from bounce.mMc99255057cc5531aa2d7015c.r81958daa-7202-11ef-bbf2-18142b2d11b0@illumos.bounce.topicbox.com) Received: by tb-mx0.topicbox.com (Postfix, from userid 1132) id A42EA50784B; Sun, 20 Oct 2024 09:11:58 -0400 (EDT) ARC-Authentication-Results: i=2; topicbox.com; arc=pass; dkim=pass (2048-bit rsa key sha256) header.d=me.com header.i=@me.com header.b=m9ayupuq header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=me.com; spf=pass smtp.mailfrom=tsoome@me.com smtp.helo=pv50p00im-zteg10021301.me.com; x-internal-arc=fail (as.1.topicbox.com=pass, ams.1.topicbox.com=fail (message has been altered)) (Message modified while forwarding at Topicbox) ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=content-type:mime-version:date:references:to :in-reply-to:message-id:list-help:list-id:list-post :list-subscribe:reply-to:subject:content-transfer-encoding:from :list-unsubscribe; s=sysmsg-1; t=1729429918; bh=ngPUo0fXL7+VtCeK jftIZpi7rZwdFQSSidg4N3L9W3c=; b=nKIu/WuP/CwYT+YL+d7bqJIgSYfZRM4p aqdt5O16b9ovxTcIvFD3ax3hkaIXe6rhYRipKazYvGGfbxJAnmIenmRa1tO/gB9R MFS9OFBexplUgzx+FwFYwGr2KsPwvv2bNGKS2xW6Pi0qWmkMPnG0KNvIO+ZDY9Op 73XY3q7/WHQ= ARC-Seal: i=2; a=rsa-sha256; cv=pass; d=topicbox.com; s=sysmsg-1; t= 1729429918; b=tb2kelYmRQrs+ZQKoOwkIIxyWhrcfpIgdavNanWejH8NQFUk7+ fDOL/I1lFxaXKjDs9zCKACqROYZzOQhe5GvPfCZwJjAIvygnor1dM+vo4eSUbKWq GmyFB7idTzBO6wxcsM5ZIwSfTg2NkVsfGOXZ5j/G8c5L7qMmR86ZRzlfM= Authentication-Results: topicbox.com; arc=pass; dkim=pass (2048-bit rsa key sha256) header.d=me.com header.i=@me.com header.b=m9ayupuq header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=me.com; spf=pass smtp.mailfrom=tsoome@me.com smtp.helo=pv50p00im-zteg10021301.me.com; x-internal-arc=fail (as.1.topicbox.com=pass, ams.1.topicbox.com=fail (message has been altered)) (Message modified while forwarding at Topicbox) X-Received-Authentication-Results: tb-mx1.topicbox.com; arc=none (no signatures found); bimi=declined (Domain declined to participate); dkim=pass (2048-bit rsa key sha256) header.d=me.com header.i=@me.com header.b=m9ayupuq header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=me.com; iprev=pass smtp.remote-ip=17.58.6.46 (pv50p00im-zteg10021301.me.com); spf=pass smtp.mailfrom=tsoome@me.com smtp.helo=pv50p00im-zteg10021301.me.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=pv50p00im-zteg10021301.me.com policy.ptr=pv50p00im-zteg10021301.me.com; x-return-mx=pass header.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-return-mx=pass smtp.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lists.illumos.org; h= content-type:mime-version:date:references:to:in-reply-to :message-id:list-help:list-id:list-post:list-subscribe:reply-to :subject:content-transfer-encoding:from:list-unsubscribe; s= dkim-1; t=1729429918; x=1729516318; bh=7STibk+Y1EDiozVR6vuK9arbX IbqrHBsNSf7BafYm+M=; b=QmXrR8sZiI9CFTD05o6WBAVdkfXWIg7bhl+VgQJel ElU8F/ct0h3EPeGIvQWa1o/tNdmS2Hy8Sxy3O3gI+EvGg2O/79O8H0VXzqwrEje8 RXRFK/ymMlVx3YG+3m1LoyTn8GkWg39lZEsvgAxeKw+kkAFQaaY0Y9r5AE/ke3hG ek= Received: from tb-mx1.topicbox.com (localhost.local [127.0.0.1]) by tb-mx1.topicbox.com (Postfix) with ESMTP id A5ED79308A for ; Sun, 20 Oct 2024 09:10:05 -0400 (EDT) (envelope-from tsoome@me.com) Received: from tb-mx1.topicbox.com (localhost [127.0.0.1]) by tb-mx1.topicbox.com (Authentication Milter) with ESMTP id B7776353F4B; Sun, 20 Oct 2024 09:10:05 -0400 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1729429805; b=laAgZ00DvRe7bPD/pRlYDCzkhGDTQ790YwgprJsdI85ltFavNH mBY3PqtY5Rq3iv/R0clsW9UHPfCrAgDsr2mv0e8j/U1eapOqMv5RTPbZ9ZxkRcJu yy7FXV272ScBqx0lTlwJfUoq1gx151P9Iix9BMDoge5nNubm1Tofllac45jik0ZA R04ygchR2kJol2dJnFynIz9oOFLvKEE13oX80t8C3X+aDAAe3LehYO9UnpLqYejW c1yVePVmqIaLR8gvm42CjnHvVJDPNou24IqfxajoeR13eSXBMRYDycMkYJpX35NZ S5ucpbTUz6p7trvdFBfAeweVzhWTojkmZF+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=from:content-type:mime-version:subject:date :references:to:in-reply-to:message-id; s=arcseal; t=1729429805; bh=Jvg5iuNufMoIMoOzz2N8/YNGPMVrL3uZydq5bt+bNNk=; b=wfr6EvpVdElG pJBZfMDaNeq9RIJAUxoso+6rY8FBQzBYMotX24LIv+WMhk2RMl10Lo+rBJrpeHAZ TeKeHCVRnmdnkDpUP8FqbJn2ZmClaT7mUqE0bP96FASlqoXF6ayBZaEfOTxXgvHQ /zbts6Xzp7Zh/aL0REdJPWdeklcNc/HscMZMbcwJPw4IT9vQ68vuw0J6JZVXGf7J 5Hp1zd6FFwKFBV2ofNVa6MO0C5I+A3Hg6SIJjR0SaL4pKpDc1FbqaTRRP+Xgr4nR U2tr/Oc8GQkrz2TMkDEP9tFwmlH7SrGC5Lojzqgax2aoYW9gFu1lVRV2Qrddy6oy 912jX6D5kw== ARC-Authentication-Results: i=1; tb-mx1.topicbox.com; arc=none (no signatures found); bimi=declined (Domain declined to participate); dkim=pass (2048-bit rsa key sha256) header.d=me.com header.i=@me.com header.b=m9ayupuq header.a=rsa-sha256 header.s=1a1hai x-bits=2048; dmarc=pass policy.published-domain-policy=quarantine policy.published-subdomain-policy=quarantine policy.applied-disposition=none policy.evaluated-disposition=none (p=quarantine,sp=quarantine,d=none,d.eval=none) policy.policy-from=p header.from=me.com; iprev=pass smtp.remote-ip=17.58.6.46 (pv50p00im-zteg10021301.me.com); spf=pass smtp.mailfrom=tsoome@me.com smtp.helo=pv50p00im-zteg10021301.me.com; x-aligned-from=pass (Address match); x-me-sender=none; x-ptr=pass smtp.helo=pv50p00im-zteg10021301.me.com policy.ptr=pv50p00im-zteg10021301.me.com; x-return-mx=pass header.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-return-mx=pass smtp.domain=me.com policy.is_org=yes (MX Records found: mx01.mail.icloud.com,mx02.mail.icloud.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehjedgieduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephfgtggfuffhfvfgjkffosegrtdhmrehhtddvnecu hfhrohhmpefvohhomhgrshcuufhoohhmvgcuoehtshhoohhmvgesmhgvrdgtohhmqeenuc ggtffrrghtthgvrhhnpeeltdfffeehffelgeekveevueelfeejvdehffehieeikedtkeeg hefhvdeiueehtdenucffohhmrghinhepihhllhhumhhoshdrohhrghenucfkphepudejrd ehkedriedrgeeipddujedrheeirdelrddutdenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepihhnvghtpedujedrheekrdeirdegiedphhgvlhhopehpvhehtdhptddtih hmqdiithgvghdutddtvddufedtuddrmhgvrdgtohhmpdhmrghilhhfrhhomhepoehtshho ohhmvgesmhgvrdgtohhmqedpnhgspghrtghpthhtohepuddprhgtphhtthhopeeouggvvh gvlhhophgvrheslhhishhtshdrihhllhhumhhoshdrohhrgheq X-ME-VSScore: -100 X-ME-VSCategory: clean Received-SPF: pass (me.com: 17.58.6.46 is authorized to use 'tsoome@me.com' in 'mfrom' identity (mechanism 'ip4:17.58.0.0/16' matched)) receiver=tb-mx1.topicbox.com; identity=mailfrom; envelope-from="tsoome@me.com"; helo=pv50p00im-zteg10021301.me.com; client-ip=17.58.6.46 Received: from pv50p00im-zteg10021301.me.com (pv50p00im-zteg10021301.me.com [17.58.6.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx1.topicbox.com (Postfix) with ESMTPS for ; Sun, 20 Oct 2024 09:10:04 -0400 (EDT) (envelope-from tsoome@me.com) Received: from smtpclient.apple (pv50p00im-dlb-asmtp-mailmevip.me.com [17.56.9.10]) by pv50p00im-zteg10021301.me.com (Postfix) with ESMTPSA id A51815000E4 for ; Sun, 20 Oct 2024 13:10:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="Apple-Mail=_A86C37E0-4A8E-4345-AE4E-34E4514ACD27" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\)) Date: Sun, 20 Oct 2024 16:09:48 +0300 References: <9B747CE8-489F-48F5-8815-19022D93A676@me.com> To: illumos-developer In-Reply-To: <9B747CE8-489F-48F5-8815-19022D93A676@me.com> Message-Id: X-Mailer: Apple Mail (2.3818.100.11.1.3) X-Proofpoint-ORIG-GUID: e7I3wfoVK6nxn6LTO2GrCmz_qVQlP6CL X-Proofpoint-GUID: e7I3wfoVK6nxn6LTO2GrCmz_qVQlP6CL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-20_10,2024-10-17_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 malwarescore=0 suspectscore=0 mlxlogscore=945 phishscore=0 adultscore=0 mlxscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2410200091 Topicbox-Policy-Reasoning: allow: sender is a member Topicbox-Message-UUID: a40ec00a-8ee4-11ef-9976-be4adfbdf04e Archived-At: =?UTF-8?B?PGh0dHBzOi8vaWxsdW1vcy50b3BpY2JveC5jb20vZ3JvdXBz?= =?UTF-8?B?L2RldmVsb3Blci9UNTNkMmI5MGZiNDBjNDBlMC1NYzk5MjU1MDU3Y2M1NTMx?= =?UTF-8?B?YWEyZDcwMTVjPg==?= List-Help: List-Id: "illumos-developer" List-Post: List-Software: Topicbox v0 List-Subscribe: Precedence: list Reply-To: illumos-developer Subject: [developer] Re: REVIEW: 16833 smbsrv: array subscript 12 is above array bounds Content-Transfer-Encoding: 7bit From: "Toomas Soome via illumos-developer" List-Unsubscribe: , Topicbox-Delivery-ID: 2:illumos:a901537c-2aea-11e7-965f-d98f9f16e227:81958daa-7202-11ef-bbf2-18142b2d11b0:Mc99255057cc5531aa2d7015c:1:x7mA3o5ZnyN1ifiBrcURAthOkHUFZnuWseJMQly3ETI --Apple-Mail=_A86C37E0-4A8E-4345-AE4E-34E4514ACD27 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Ping? thanks, toomas > On 14. Oct 2024, at 11:06, Toomas Soome wrote: >=20 > hi! >=20 > This is one of the reason I did create https://www.illumos.org/issues/168= 04 But since 16804 is opposed, I have to set this one rolling. >=20 > So, please review: https://code.illumos.org/c/illumos-gate/+/3736 >=20 > Since VERIFY() does not hint compiler in any way, there is no reason to b= elieve the bounds check is in place and we do get the warning. So, we have = two options - either suppress the warning or show compiler we have bounds c= heck. Here, in this version, we add this extra if statement. >=20 > Thanks, > Toomas ------------------------------------------ illumos: illumos-developer Permalink: https://illumos.topicbox.com/groups/developer/T53d2b90fb40c40e0-= Mc99255057cc5531aa2d7015c Delivery options: https://illumos.topicbox.com/groups/developer/subscription --Apple-Mail=_A86C37E0-4A8E-4345-AE4E-34E4514ACD27 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=UTF-8 Ping?

=
thanks,
toomas

On 14. Oct 2024, at 11:06, Too= mas Soome <tsoome@me.com> wrote:

hi!

This i= s one of the reason I did create https://www.illumos.org/issues/16804 But since 16804 i= s opposed, I have to set this one rolling.


Since VERIFY() does not hint compiler in any way, there is no= reason to believe the bounds check is in place and we do get the warning. = So, we have two options - either suppress the warning or show compiler we h= ave bounds check. Here, in this version, we add this extra if statement.

Thanks,
Toomas

= --Apple-Mail=_A86C37E0-4A8E-4345-AE4E-34E4514ACD27--