From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from tb-mx0.topicbox.com (localhost.local [127.0.0.1]) by tb-mx0.topicbox.com (Postfix) with ESMTP id 689BF1113886 for ; Thu, 7 Mar 2024 16:40:09 -0500 (EST) (envelope-from richlowe@richlowe.net) Received: from tb-mx0.topicbox.com (localhost [127.0.0.1]) by tb-mx0.topicbox.com (Authentication Milter) with ESMTP id CDDB96300B6; Thu, 7 Mar 2024 16:40:09 -0500 ARC-Seal: i=1; a=rsa-sha256; cv=none; d=topicbox.com; s=arcseal; t= 1709847609; b=JXbDZJrBBgTE7XXORF4SYNjE3uB5vJ6E5+Fkkh/ZnnRngi/dXJ chnrLuEm/e8oRM2w5uuU3K5z/krSEfDecE88E6nWVECHThe9iZ8MSsW5W2V14/fw mGaRfl/j2vndwZpNrmTbwu05p7ExB9BLsL6xgSmzjj+NahRb56DeUPdhyfIQHLWJ FdSJNFp7i+JdPO4mt4S1sWr3Y18+EeHFkxnkI0i81303uOdHbPo6sYvu0pzn8KLd caXe+HkuIIQxW0tJ12H4Egg0zvbZF6UavQM+ZFYEkmFcKd3gGrFgbiaOkCXOTJo6 4nkwfYLgLJklugwGMSlRiJP1Ug0n4swuycGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= topicbox.com; h=mime-version:from:date:message-id:subject:to:cc :content-type; s=arcseal; t=1709847609; bh=z2nBghUSPir+Du34nPJLS OpIsYv91k5t+onUapQX4SY=; b=aHc87+lzCQuS0RFDzpp83sch+sjX7bPRPDXyr 60U5lQ4kmyzE56NS85AUVikuigAqxTDT5GlwqHVY4f+OtcxVP7i9qAh76DUR7RO9 na7PZNNyOmfOX1yCSJaIJNAzLOB5f29bZiY1LY+jiG/zahpEz2YujWsnHazpFZ11 n2/spX1dZf7sXqoF86k+OL4dVE8r9xV00UKJ6K47VvNDGhPUJeRAq5q7Q6HCCjqY UN1NplneqqiEJtK2PkQmVAr2xhQin7d6yfFzMyy3i+UC7Bnd8uoTNrnORrb8U9Ji xFfeuiYpQUYWfLlzfux6Zt/NBQ0JqvCER3uo8ReRQSeCzNiwg== ARC-Authentication-Results: i=1; tb-mx0.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=invalid (public key: not available, 0-bit key sha256) header.d=richlowe.net header.i=@richlowe.net header.b=V91kpBwQ header.a=-sha256 header.s=mail x-bits=0; dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=richlowe.net; iprev=pass smtp.remote-ip=209.85.222.45 (mail-ua1-f45.google.com); spf=pass smtp.mailfrom=richlowe@richlowe.net smtp.helo=mail-ua1-f45.google.com; x-aligned-from=pass (Address match); x-google-dkim=pass (2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=mvCRykXm; x-me-sender=none; x-ptr=pass smtp.helo=mail-ua1-f45.google.com policy.ptr=mail-ua1-f45.google.com; x-return-mx=pass header.domain=richlowe.net policy.is_org=yes (MX Records found: alt2.aspmx.l.google.com,alt1.aspmx.l.google.com,aspmx3.googlemail.com,aspmx2.googlemail.com,aspmx.l.google.com); x-return-mx=pass smtp.domain=richlowe.net policy.is_org=yes (MX Records found: alt2.aspmx.l.google.com,alt1.aspmx.l.google.com,aspmx3.googlemail.com,aspmx2.googlemail.com,aspmx.l.google.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 Authentication-Results: tb-mx0.topicbox.com; arc=none (no signatures found); bimi=skipped (DMARC did not pass); dkim=invalid (public key: not available, 0-bit key sha256) header.d=richlowe.net header.i=@richlowe.net header.b=V91kpBwQ header.a=-sha256 header.s=mail x-bits=0; dmarc=none policy.published-domain-policy=none policy.applied-disposition=none policy.evaluated-disposition=none (p=none,d=none,d.eval=none) policy.policy-from=p header.from=richlowe.net; iprev=pass smtp.remote-ip=209.85.222.45 (mail-ua1-f45.google.com); spf=pass smtp.mailfrom=richlowe@richlowe.net smtp.helo=mail-ua1-f45.google.com; x-aligned-from=pass (Address match); x-google-dkim=pass (2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=mvCRykXm; x-me-sender=none; x-ptr=pass smtp.helo=mail-ua1-f45.google.com policy.ptr=mail-ua1-f45.google.com; x-return-mx=pass header.domain=richlowe.net policy.is_org=yes (MX Records found: alt2.aspmx.l.google.com,alt1.aspmx.l.google.com,aspmx3.googlemail.com,aspmx2.googlemail.com,aspmx.l.google.com); x-return-mx=pass smtp.domain=richlowe.net policy.is_org=yes (MX Records found: alt2.aspmx.l.google.com,alt1.aspmx.l.google.com,aspmx3.googlemail.com,aspmx2.googlemail.com,aspmx.l.google.com); x-tls=pass smtp.version=TLSv1.2 smtp.cipher=ECDHE-RSA-AES256-GCM-SHA384 smtp.bits=256/256; x-vs=clean score=-100 state=0 X-ME-VSCause: gggruggvucftvghtrhhoucdtuddrgedvledrieefgdduhedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepggfhfffkuffvvegtsehttdertddttdejnecuhfhr ohhmpeftihgthhgrrhguucfnohifvgcuoehrihgthhhlohifvgesrhhitghhlhhofigvrd hnvghtqeenucggtffrrghtthgvrhhnpeekffdtuddtgfeigedutdelhffgieeikeevkedt feehieeiuefhueekjedugedvleenucffohhmrghinhepihhllhhumhhoshdrohhrghenuc fkphepvddtledrkeehrddvvddvrdegheenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepihhnvghtpedvtdelrdekhedrvddvvddrgeehpdhhvghlohepmhgrihhlqdhurg duqdhfgeehrdhgohhoghhlvgdrtghomhdpmhgrihhlfhhrohhmpeeorhhitghhlhhofigv sehrihgthhhlohifvgdrnhgvtheq X-ME-VSScore: -100 X-ME-VSCategory: clean Received-SPF: pass (richlowe.net: Sender is authorized to use 'richlowe@richlowe.net' in 'mfrom' identity (mechanism 'include:_spf.google.com' matched)) receiver=tb-mx0.topicbox.com; identity=mailfrom; envelope-from="richlowe@richlowe.net"; helo=mail-ua1-f45.google.com; client-ip=209.85.222.45 Received: from mail-ua1-f45.google.com (mail-ua1-f45.google.com [209.85.222.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tb-mx0.topicbox.com (Postfix) with ESMTPS for ; Thu, 7 Mar 2024 16:40:08 -0500 (EST) (envelope-from richlowe@richlowe.net) Received: by mail-ua1-f45.google.com with SMTP id a1e0cc1a2514c-7d5fce59261so1046373241.3 for ; Thu, 07 Mar 2024 13:40:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=richlowe.net; s=mail; t=1709847608; x=1710452408; darn=lists.illumos.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=z2nBghUSPir+Du34nPJLSOpIsYv91k5t+onUapQX4SY=; b=V91kpBwQLwDBeUYCwIbD0Qxi93FIS89MLVE2yo/rAnBpgJqwAgDMeY0gqTtB02Cb1Q kia5RBDdlR7SUKpD/2Gljs6FaAhiEHBbQUVVxdxeuH320GI60xkzRLEu+uNMSorLqcQf 0gHlfyLReUqJak9Jtfjd95L0x0hdCaW8JwkDc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709847608; x=1710452408; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=z2nBghUSPir+Du34nPJLSOpIsYv91k5t+onUapQX4SY=; b=mvCRykXmbu9zTLr7tUtMEWFQyO9MUbC4AKVYU8QvyO1OT+4H31eCorY/1U2vPt/dTt 2wEYSY3PW+hK1u/rq1QEQGgNLPCQwENVReQhBmU+E62QfP9o6c9iCKMmCrs8gDnRJ2lT ajDtLbp6U0sO8ceEtx1lWMwjyip1VKS3+j6gG5vBfNgG+CAZhDVZ1+ZGY9MFE0qLQRlW GrEf5ncXafUpem74NomVT9twJ6puMATvgZ3A6piuCqHLiwnX992P8/1wxFTd2fdm8q6y CSXxuVEV33v3kLqyRYdbUNDtXkbIO0LUqoUfSf2Z2bwgw0PHk91uPqT2QsPCkOl+81X3 ZfKg== X-Gm-Message-State: AOJu0YxWdeecmnRTc6QCiZEe+RPdXVzuHdD/j9iYvds9jbEaZR4AXO6v JKJBOxolhHp6jl/TY5AuxW/M27yOIrmeAP+cQIQElOzdw8ff4PJut0Cz1usK1K3gDqKOr5GrIfr y2Ur/mUD5Xg7AxaASs2QffU2oaRwv0vcd5EZey7KLK+tWRmgjQ071 X-Google-Smtp-Source: AGHT+IHxeNZ9pTER5ZITWkbu5v4jHiRK/70TXWXaajpN5dTX26kjHSi7y+1Bi889gQuaJjJZ+qgqfQCI+YNG6Dc5n9Q= X-Received: by 2002:a67:f651:0:b0:472:b533:ae68 with SMTP id u17-20020a67f651000000b00472b533ae68mr8555092vso.34.1709847607731; Thu, 07 Mar 2024 13:40:07 -0800 (PST) MIME-Version: 1.0 From: Richard Lowe Date: Thu, 7 Mar 2024 15:39:56 -0600 Message-ID: Subject: [REVIEW] 16344 -Wstrict-prototypes warnings about SIG_DFL, SIG_ERR, SIG_IGN and SIG_HOLD signal constants To: illumos-dev Cc: Jonathan Perkin , Dominik Hassler Content-Type: text/plain; charset="UTF-8" Topicbox-Policy-Reasoning: allow: sender is an admin Topicbox-Message-UUID: 49027042-dccb-11ee-aacf-3ce0fd8b7b06 https://code.illumos.org/c/illumos-gate/+/3358 This fixes SIG_* constants to please modern compilers wanting to drop K&R support, and fixes illumos-gate to not be wrong. I'd appreciate a careful look. I'd also appreciate it if we could get bulk builds of this (Jonathan? Dominik?). I haven't tested this much at all as yet, except with wsdiff (which only contains differences I can explain, fwiw, but I'm not happy with the completeness of that as yet). I plan to at least additionally verify with psig(1) that everything is still hooked up as we expect, where possible. -- Rich